Re: [PATCH v2 0/3] Add Scripts for Finding Top 25 Executed Functions
петак, 19. јун 2020., Ahmed Karaman је написао/ла: > Greetings, > > This series implements the improvements and changes requested to be > added to the two scripts. > > Thanks to Mr. Aleksandar Markovic, Mr. Alex Bennée, and Mr. Eric Blake > for their valuable feedback. > > First version of the series: > https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg04868.html > > The cover letters for v2, v3,... should repeat the core text of the original cover letter. You can keep this link above, but you must repeat the almost all text of v1 cover letter in v2, v3,... too. Any version of any series should be a stand-alone unit, and the reader should not be forced to look at the previous versions to find out what the series is really about, which is the case now for this v2 of your series. Thanks, Aleksandar Best regards, > Ahmed Karaman > > v1->v2: > - Add an empty line at the end of the MAINTAINERS file. > - Move MAINTAINERS patch to be the last in the series. > - Allow custom number of top functions to be specified. > - Check for vallgrind and perf before executing the scripts. > - Ensure sufficient permissions when running the topN_perf script. > - Use subprocess instead of os.system > - Use os.unlink() for deleting intermediate files. > - Spread out the data extraction steps. > - Enable execution permission for the scripts. > - Add script example output in the commit message. > > Ahmed Karaman (3): > scripts/performance: Add topN_perf.py script > scripts/performance: Add topN_callgrind.py script > MAINTAINERS: Add 'Performance Tools and Tests' subsection > > MAINTAINERS | 7 ++ > scripts/performance/topN_callgrind.py | 131 ++ > scripts/performance/topN_perf.py | 115 ++ > 3 files changed, 253 insertions(+) > create mode 100755 scripts/performance/topN_callgrind.py > create mode 100755 scripts/performance/topN_perf.py > > -- > 2.17.1 > >
Re: [PATCH v2 0/3] Add Scripts for Finding Top 25 Executed Functions
Patchew URL: https://patchew.org/QEMU/20200619153632.1365-1-ahmedkhaledkara...@gmail.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === CC qga/commands.o CC qga/guest-agent-command-state.o CC qga/main.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC qga/commands-posix.o CC qga/channel-posix.o CC qga/qapi-generated/qga-qapi-types.o --- GEN docs/interop/qemu-ga-ref.html GEN docs/interop/qemu-ga-ref.txt GEN docs/interop/qemu-ga-ref.7 /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-keymap /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-client LINKivshmem-server /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-nbd AS pc-bios/optionrom/multiboot.o AS pc-bios/optionrom/linuxboot.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC pc-bios/optionrom/linuxboot_dma.o AS pc-bios/optionrom/kvmvapic.o LINKqemu-storage-daemon AS pc-bios/optionrom/pvh.o CC pc-bios/optionrom/pvh_main.o BUILD pc-bios/optionrom/multiboot.img /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-img BUILD pc-bios/optionrom/linuxboot.img BUILD pc-bios/optionrom/linuxboot_dma.img BUILD pc-bios/optionrom/kvmvapic.img BUILD pc-bios/optionrom/pvh.img BUILD pc-bios/optionrom/multiboot.raw /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) BUILD pc-bios/optionrom/linuxboot.raw BUILD pc-bios/optionrom/linuxboot_dma.raw BUILD pc-bios/optionrom/kvmvapic.raw --- SIGNpc-bios/optionrom/kvmvapic.bin LINKqemu-edid SIGNpc-bios/optionrom/pvh.bin /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKfsdev/virtfs-proxy-helper LINKscsi/qemu-pr-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-bridge-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKvirtiofsd LINKvhost-user-input /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from
[PATCH v2 0/3] Add Scripts for Finding Top 25 Executed Functions
Greetings, This series implements the improvements and changes requested to be added to the two scripts. Thanks to Mr. Aleksandar Markovic, Mr. Alex Bennée, and Mr. Eric Blake for their valuable feedback. First version of the series: https://lists.nongnu.org/archive/html/qemu-devel/2020-06/msg04868.html Best regards, Ahmed Karaman v1->v2: - Add an empty line at the end of the MAINTAINERS file. - Move MAINTAINERS patch to be the last in the series. - Allow custom number of top functions to be specified. - Check for vallgrind and perf before executing the scripts. - Ensure sufficient permissions when running the topN_perf script. - Use subprocess instead of os.system - Use os.unlink() for deleting intermediate files. - Spread out the data extraction steps. - Enable execution permission for the scripts. - Add script example output in the commit message. Ahmed Karaman (3): scripts/performance: Add topN_perf.py script scripts/performance: Add topN_callgrind.py script MAINTAINERS: Add 'Performance Tools and Tests' subsection MAINTAINERS | 7 ++ scripts/performance/topN_callgrind.py | 131 ++ scripts/performance/topN_perf.py | 115 ++ 3 files changed, 253 insertions(+) create mode 100755 scripts/performance/topN_callgrind.py create mode 100755 scripts/performance/topN_perf.py -- 2.17.1
