Re: [PATCH v2 0/6] iotests: update environment and linting configuration
Am 24.09.2021 um 20:13 hat John Snow geschrieben: > On Thu, Sep 23, 2021 at 2:07 PM John Snow wrote: > > > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1 > > CI: https://gitlab.com/jsnow/qemu/-/pipelines/376236687 > > > > This series partially supersedes: > > [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI' > > > > Howdy, this is good stuff we want even if we aren't yet in agreement > > about the best way to run iotest 297 from CI. > > > > - Update linting config to tolerate pylint 2.11.1 > > - Eliminate sys.path hacking in individual test files > > - make mypy execution in test 297 faster > > > > The rest of the actual "run at CI time" stuff can get handled separately > > and later pending some discussion on the other series. > > > > V2: > > > > 001/6:[0011] [FC] 'iotests: add 'qemu' package location to PYTHONPATH in > > testenv' > > 002/6:[0025] [FC] 'iotests: add warning for rogue 'qemu' packages' > > > > - Squashed in a small optimization from Vladimir to 001, kept R-Bs. > > - Fixed the package detection logic to not panic if it can't find > > 'qemu' at all (kwolf) > > - Updated commit messages for the first two patches. > Patch 2 can just be dropped, and everything else is reviewed, so I think > this can be staged at your leisure. Thanks, applied to the block branch (without patch 2). Kevin
Re: [PATCH v2 0/6] iotests: update environment and linting configuration
On Thu, Sep 23, 2021 at 2:07 PM John Snow wrote: > GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1 > CI: https://gitlab.com/jsnow/qemu/-/pipelines/376236687 > > This series partially supersedes: > [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI' > > Howdy, this is good stuff we want even if we aren't yet in agreement > about the best way to run iotest 297 from CI. > > - Update linting config to tolerate pylint 2.11.1 > - Eliminate sys.path hacking in individual test files > - make mypy execution in test 297 faster > > The rest of the actual "run at CI time" stuff can get handled separately > and later pending some discussion on the other series. > > V2: > > 001/6:[0011] [FC] 'iotests: add 'qemu' package location to PYTHONPATH in > testenv' > 002/6:[0025] [FC] 'iotests: add warning for rogue 'qemu' packages' > > - Squashed in a small optimization from Vladimir to 001, kept R-Bs. > - Fixed the package detection logic to not panic if it can't find > 'qemu' at all (kwolf) > - Updated commit messages for the first two patches. > > --js > > John Snow (6): > iotests: add 'qemu' package location to PYTHONPATH in testenv > iotests: add warning for rogue 'qemu' packages > iotests/linters: check mypy files all at once > iotests/mirror-top-perms: Adjust imports > iotests/migrate-bitmaps-test: delint > iotests: Update for pylint 2.11.1 > > tests/qemu-iotests/235| 2 - > tests/qemu-iotests/297| 50 --- > tests/qemu-iotests/300| 7 ++- > tests/qemu-iotests/iotests.py | 2 - > tests/qemu-iotests/pylintrc | 6 ++- > tests/qemu-iotests/testenv.py | 39 --- > tests/qemu-iotests/testrunner.py | 7 +-- > tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++ > tests/qemu-iotests/tests/mirror-top-perms | 12 ++--- > 9 files changed, 99 insertions(+), 76 deletions(-) > > -- > 2.31.1 > > > Patch 2 can just be dropped, and everything else is reviewed, so I think this can be staged at your leisure. --js
[PATCH v2 0/6] iotests: update environment and linting configuration
GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-iotest-pt1 CI: https://gitlab.com/jsnow/qemu/-/pipelines/376236687 This series partially supersedes: [PATCH v3 00/16] python/iotests: Run iotest linters during Python CI' Howdy, this is good stuff we want even if we aren't yet in agreement about the best way to run iotest 297 from CI. - Update linting config to tolerate pylint 2.11.1 - Eliminate sys.path hacking in individual test files - make mypy execution in test 297 faster The rest of the actual "run at CI time" stuff can get handled separately and later pending some discussion on the other series. V2: 001/6:[0011] [FC] 'iotests: add 'qemu' package location to PYTHONPATH in testenv' 002/6:[0025] [FC] 'iotests: add warning for rogue 'qemu' packages' - Squashed in a small optimization from Vladimir to 001, kept R-Bs. - Fixed the package detection logic to not panic if it can't find 'qemu' at all (kwolf) - Updated commit messages for the first two patches. --js John Snow (6): iotests: add 'qemu' package location to PYTHONPATH in testenv iotests: add warning for rogue 'qemu' packages iotests/linters: check mypy files all at once iotests/mirror-top-perms: Adjust imports iotests/migrate-bitmaps-test: delint iotests: Update for pylint 2.11.1 tests/qemu-iotests/235| 2 - tests/qemu-iotests/297| 50 --- tests/qemu-iotests/300| 7 ++- tests/qemu-iotests/iotests.py | 2 - tests/qemu-iotests/pylintrc | 6 ++- tests/qemu-iotests/testenv.py | 39 --- tests/qemu-iotests/testrunner.py | 7 +-- tests/qemu-iotests/tests/migrate-bitmaps-test | 50 +++ tests/qemu-iotests/tests/mirror-top-perms | 12 ++--- 9 files changed, 99 insertions(+), 76 deletions(-) -- 2.31.1