Re: [PATCH v2 02/35] gitlab: add FF_SCRIPT_SECTIONS for timings

2023-01-25 Thread Philippe Mathieu-Daudé 

On 24/1/23 19:00, Alex Bennée wrote:

From: Mark Cave-Ayland 

Suggested-by: Mark Cave-Ayland 
Signed-off-by: Alex Bennée 
Reviewed-by: Thomas Huth 
---
  .gitlab-ci.d/base.yml | 5 +
  1 file changed, 5 insertions(+)


Nice!

Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v2 02/35] gitlab: add FF_SCRIPT_SECTIONS for timings

2023-01-25 Thread Daniel P . Berrangé 
On Tue, Jan 24, 2023 at 06:00:54PM +, Alex Bennée wrote:
> From: Mark Cave-Ayland 
> 
> Suggested-by: Mark Cave-Ayland 
> Signed-off-by: Alex Bennée 
> Reviewed-by: Thomas Huth 
> ---
>  .gitlab-ci.d/base.yml | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
> index 69b36c148a..50fb59e147 100644
> --- a/.gitlab-ci.d/base.yml
> +++ b/.gitlab-ci.d/base.yml
> @@ -6,6 +6,11 @@
>  # most restrictive to least restrictive
>  #
>  .base_job_template:
> +  variables:
> +# Each script line from will be in a collapsible section in the job 
> output
> +# and show the duration of each line.
> +FF_SCRIPT_SECTIONS: 1

Ooh, it is nice to learn about this. FWIW, I found it eventually
documented at

  https://docs.gitlab.com/runner/configuration/feature-flags.html

with a footnote indicating it si valid to set in the pipeline yaml
config, not only the runner.

Reviewed-by: Daniel P. Berrangé 

With regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

[PATCH v2 02/35] gitlab: add FF_SCRIPT_SECTIONS for timings

2023-01-24 Thread Alex Bennée 
From: Mark Cave-Ayland 

Suggested-by: Mark Cave-Ayland 
Signed-off-by: Alex Bennée 
Reviewed-by: Thomas Huth 
---
 .gitlab-ci.d/base.yml | 5 +
 1 file changed, 5 insertions(+)

diff --git a/.gitlab-ci.d/base.yml b/.gitlab-ci.d/base.yml
index 69b36c148a..50fb59e147 100644
--- a/.gitlab-ci.d/base.yml
+++ b/.gitlab-ci.d/base.yml
@@ -6,6 +6,11 @@
 # most restrictive to least restrictive
 #
 .base_job_template:
+  variables:
+# Each script line from will be in a collapsible section in the job output
+# and show the duration of each line.
+FF_SCRIPT_SECTIONS: 1
+
   rules:
 #
 # Stage 1: exclude scenarios where we definitely don't
-- 
2.34.1