Re: [PATCH v2 04/18] tests: print newline after QMP response in qtest logs

[Juan Quintela]

Daniel P. Berrangé  wrote:
> The QMP commands have a trailing newline, but the response does not.
> This makes the qtest logs hard to follow as the next QMP command
> appears in the same line as the previous QMP response.
>
> Reviewed-by: Thomas Huth 
> Signed-off-by: Daniel P. Berrangé 

Reviewed-by: Juan Quintela 

Re: [PATCH v2 04/18] tests: print newline after QMP response in qtest logs

[Peter Xu]

On Thu, Mar 10, 2022 at 05:18:07PM +, Daniel P. Berrangé wrote:
> The QMP commands have a trailing newline, but the response does not.
> This makes the qtest logs hard to follow as the next QMP command
> appears in the same line as the previous QMP response.
> 
> Reviewed-by: Thomas Huth 
> Signed-off-by: Daniel P. Berrangé 

Reviewed-by: Peter Xu 

-- 
Peter Xu

[PATCH v2 04/18] tests: print newline after QMP response in qtest logs

[Daniel P . Berrangé]

The QMP commands have a trailing newline, but the response does not.
This makes the qtest logs hard to follow as the next QMP command
appears in the same line as the previous QMP response.

Reviewed-by: Thomas Huth 
Signed-off-by: Daniel P. Berrangé 
---
 tests/qtest/libqtest.c | 5 -
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/tests/qtest/libqtest.c b/tests/qtest/libqtest.c
index a85f8a6d05..d5b6558876 100644
--- a/tests/qtest/libqtest.c
+++ b/tests/qtest/libqtest.c
@@ -625,10 +625,13 @@ QDict *qmp_fd_receive(int fd)
 }
 
 if (log) {
-len = write(2, , 1);
+g_assert(write(2, , 1) == 1);
 }
 json_message_parser_feed(, , 1);
 }
+if (log) {
+g_assert(write(2, "\n", 1) == 1);
+}
 json_message_parser_destroy();
 
 return qmp.response;
-- 
2.34.1