Re: [PATCH v2 05/20] hw/i386/pc_{q35, piix}: Reuse MachineClass::desc as SMB product name

[Thomas Huth]

On 31/01/2023 12.53, Bernhard Beschow wrote:

No need to repeat the descriptions.

Signed-off-by: Bernhard Beschow 
Reviewed-by: Philippe Mathieu-Daudé 
---
  hw/i386/pc_piix.c | 2 +-
  hw/i386/pc_q35.c  | 2 +-
  2 files changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Thomas Huth 

[PATCH v2 05/20] hw/i386/pc_{q35, piix}: Reuse MachineClass::desc as SMB product name

[Bernhard Beschow]

No need to repeat the descriptions.

Signed-off-by: Bernhard Beschow 
Reviewed-by: Philippe Mathieu-Daudé 
---
 hw/i386/pc_piix.c | 2 +-
 hw/i386/pc_q35.c  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index df64dd8dcc..ee9d9a4175 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -197,7 +197,7 @@ static void pc_init1(MachineState *machine,
 if (pcmc->smbios_defaults) {
 MachineClass *mc = MACHINE_GET_CLASS(machine);
 /* These values are guest ABI, do not change */
-smbios_set_defaults("QEMU", "Standard PC (i440FX + PIIX, 1996)",
+smbios_set_defaults("QEMU", mc->desc,
 mc->name, pcmc->smbios_legacy_mode,
 pcmc->smbios_uuid_encoded,
 pcms->smbios_entry_point_type);
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 88324af91f..bc4fd06c1e 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -198,7 +198,7 @@ static void pc_q35_init(MachineState *machine)
 
 if (pcmc->smbios_defaults) {
 /* These values are guest ABI, do not change */
-smbios_set_defaults("QEMU", "Standard PC (Q35 + ICH9, 2009)",
+smbios_set_defaults("QEMU", mc->desc,
 mc->name, pcmc->smbios_legacy_mode,
 pcmc->smbios_uuid_encoded,
 pcms->smbios_entry_point_type);
-- 
2.39.1