Re: [PATCH v2 07/19] target/ppc: Move REQUIRE_ALTIVEC/VECTOR to translate.c

[David Gibson]

On Tue, Aug 31, 2021 at 01:39:55PM -0300, Luis Pires wrote:
> From: Bruno Larsen 
> 
> Move REQUIRE_ALTIVEC to translate.c and rename it to REQUIRE_VECTOR.
> 
> Signed-off-by: Bruno Larsen 
> Signed-off-by: Matheus Ferst 
> Signed-off-by: Fernando Valle 
> Signed-off-by: Luis Pires 

Acked-by: David Gibson 

> ---
>  target/ppc/translate.c |  8 
>  target/ppc/translate/vector-impl.c.inc | 10 +-
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/target/ppc/translate.c b/target/ppc/translate.c
> index 171b216e17..4749ecdaa9 100644
> --- a/target/ppc/translate.c
> +++ b/target/ppc/translate.c
> @@ -7453,6 +7453,14 @@ static int times_4(DisasContext *ctx, int x)
>  # define REQUIRE_64BIT(CTX)  REQUIRE_INSNS_FLAGS(CTX, 64B)
>  #endif
>  
> +#define REQUIRE_VECTOR(CTX) \
> +do {\
> +if (unlikely(!(CTX)->altivec_enabled)) {\
> +gen_exception((CTX), POWERPC_EXCP_VPU); \
> +return true;\
> +}   \
> +} while (0)
> +
>  /*
>   * Helpers for implementing sets of trans_* functions.
>   * Defer the implementation of NAME to FUNC, with optional extra arguments.
> diff --git a/target/ppc/translate/vector-impl.c.inc 
> b/target/ppc/translate/vector-impl.c.inc
> index 117ce9b137..197e903337 100644
> --- a/target/ppc/translate/vector-impl.c.inc
> +++ b/target/ppc/translate/vector-impl.c.inc
> @@ -17,20 +17,12 @@
>   * License along with this library; if not, see 
> .
>   */
>  
> -#define REQUIRE_ALTIVEC(CTX) \
> -do {\
> -if (unlikely(!(CTX)->altivec_enabled)) {\
> -gen_exception((CTX), POWERPC_EXCP_VPU); \
> -return true;\
> -}   \
> -} while (0)
> -
>  static bool trans_VCFUGED(DisasContext *ctx, arg_VX *a)
>  {
>  TCGv_i64 tgt, src, mask;
>  
>  REQUIRE_INSNS_FLAGS2(ctx, ISA310);
> -REQUIRE_ALTIVEC(ctx);
> +REQUIRE_VECTOR(ctx);
>  
>  tgt = tcg_temp_new_i64();
>  src = tcg_temp_new_i64();

-- 
David Gibson| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson


signature.asc
Description: PGP signature

Re: [PATCH v2 07/19] target/ppc: Move REQUIRE_ALTIVEC/VECTOR to translate.c

[Richard Henderson]

On 8/31/21 9:39 AM, Luis Pires wrote:

From: Bruno Larsen

Move REQUIRE_ALTIVEC to translate.c and rename it to REQUIRE_VECTOR.

Signed-off-by: Bruno Larsen
Signed-off-by: Matheus Ferst
Signed-off-by: Fernando Valle
Signed-off-by: Luis Pires
---
  target/ppc/translate.c |  8 
  target/ppc/translate/vector-impl.c.inc | 10 +-
  2 files changed, 9 insertions(+), 9 deletions(-)


Reviewed-by: Richard Henderson 

r~

[PATCH v2 07/19] target/ppc: Move REQUIRE_ALTIVEC/VECTOR to translate.c

[Luis Pires]

From: Bruno Larsen 

Move REQUIRE_ALTIVEC to translate.c and rename it to REQUIRE_VECTOR.

Signed-off-by: Bruno Larsen 
Signed-off-by: Matheus Ferst 
Signed-off-by: Fernando Valle 
Signed-off-by: Luis Pires 
---
 target/ppc/translate.c |  8 
 target/ppc/translate/vector-impl.c.inc | 10 +-
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 171b216e17..4749ecdaa9 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -7453,6 +7453,14 @@ static int times_4(DisasContext *ctx, int x)
 # define REQUIRE_64BIT(CTX)  REQUIRE_INSNS_FLAGS(CTX, 64B)
 #endif
 
+#define REQUIRE_VECTOR(CTX) \
+do {\
+if (unlikely(!(CTX)->altivec_enabled)) {\
+gen_exception((CTX), POWERPC_EXCP_VPU); \
+return true;\
+}   \
+} while (0)
+
 /*
  * Helpers for implementing sets of trans_* functions.
  * Defer the implementation of NAME to FUNC, with optional extra arguments.
diff --git a/target/ppc/translate/vector-impl.c.inc 
b/target/ppc/translate/vector-impl.c.inc
index 117ce9b137..197e903337 100644
--- a/target/ppc/translate/vector-impl.c.inc
+++ b/target/ppc/translate/vector-impl.c.inc
@@ -17,20 +17,12 @@
  * License along with this library; if not, see .
  */
 
-#define REQUIRE_ALTIVEC(CTX) \
-do {\
-if (unlikely(!(CTX)->altivec_enabled)) {\
-gen_exception((CTX), POWERPC_EXCP_VPU); \
-return true;\
-}   \
-} while (0)
-
 static bool trans_VCFUGED(DisasContext *ctx, arg_VX *a)
 {
 TCGv_i64 tgt, src, mask;
 
 REQUIRE_INSNS_FLAGS2(ctx, ISA310);
-REQUIRE_ALTIVEC(ctx);
+REQUIRE_VECTOR(ctx);
 
 tgt = tcg_temp_new_i64();
 src = tcg_temp_new_i64();
-- 
2.25.1