Re: [PATCH v2 1/2] target/s390x: Use mutable temporary value for op_ts

[David Hildenbrand]

On 18.03.24 21:27, Ilya Leoshkevich wrote:

From: Ido Plat 

Otherwise TCG would assume the register that holds t1 would be constant
and reuse whenever it needs the value within it.

Cc: qemu-sta...@nongnu.org
Fixes: f1ea739bd598 ("target/s390x: Use tcg_constant_* in local contexts")
Reviewed-by: Ilya Leoshkevich 
Reviewed-by: Richard Henderson 
[iii: Adjust a newline and capitalization, add tags]
Signed-off-by: Ido Plat 
Signed-off-by: Ilya Leoshkevich 
---


Reviewed-by: David Hildenbrand 

--
Cheers,

David / dhildenb

[PATCH v2 1/2] target/s390x: Use mutable temporary value for op_ts

[Ilya Leoshkevich]

From: Ido Plat 

Otherwise TCG would assume the register that holds t1 would be constant
and reuse whenever it needs the value within it.

Cc: qemu-sta...@nongnu.org
Fixes: f1ea739bd598 ("target/s390x: Use tcg_constant_* in local contexts")
Reviewed-by: Ilya Leoshkevich 
Reviewed-by: Richard Henderson 
[iii: Adjust a newline and capitalization, add tags]
Signed-off-by: Ido Plat 
Signed-off-by: Ilya Leoshkevich 
---
 target/s390x/tcg/translate.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 0d0c672c959..57b7db1ee96 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -4781,9 +4781,10 @@ static DisasJumpType op_trXX(DisasContext *s, DisasOps 
*o)
 
 static DisasJumpType op_ts(DisasContext *s, DisasOps *o)
 {
-TCGv_i32 t1 = tcg_constant_i32(0xff);
+TCGv_i32 ff = tcg_constant_i32(0xff);
+TCGv_i32 t1 = tcg_temp_new_i32();
 
-tcg_gen_atomic_xchg_i32(t1, o->in2, t1, get_mem_index(s), MO_UB);
+tcg_gen_atomic_xchg_i32(t1, o->in2, ff, get_mem_index(s), MO_UB);
 tcg_gen_extract_i32(cc_op, t1, 7, 1);
 set_cc_static(s);
 return DISAS_NEXT;
-- 
2.44.0