Re: [PATCH v2 1/4] hw/i2c: name I2CNode list in I2CBus

[Philippe Mathieu-Daudé]

On 4/9/21 6:25 PM, Patrick Venture wrote:
> To enable passing the current_devs field as a parameter, we need to use
> a named struct type.
> 
> Tested: BMC firmware with i2c devices booted to userspace.
> 
> Signed-off-by: Patrick Venture 
> Reviewed-by: Hao Wu 
> ---
>  include/hw/i2c/i2c.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé 

[PATCH v2 1/4] hw/i2c: name I2CNode list in I2CBus

[Patrick Venture]

To enable passing the current_devs field as a parameter, we need to use
a named struct type.

Tested: BMC firmware with i2c devices booted to userspace.

Signed-off-by: Patrick Venture 
Reviewed-by: Hao Wu 
---
 include/hw/i2c/i2c.h | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h
index 277dd9f2d6..1f7c268c86 100644
--- a/include/hw/i2c/i2c.h
+++ b/include/hw/i2c/i2c.h
@@ -58,9 +58,11 @@ struct I2CNode {
 QLIST_ENTRY(I2CNode) next;
 };
 
+typedef QLIST_HEAD(I2CNodeList, I2CNode) I2CNodeList;
+
 struct I2CBus {
 BusState qbus;
-QLIST_HEAD(, I2CNode) current_devs;
+I2CNodeList current_devs;
 uint8_t saved_address;
 bool broadcast;
 };
-- 
2.31.1.295.g9ea45b61b8-goog