Re: [PATCH v2 10/10] vt82c686: Remove unneeded includes and defines

[Philippe Mathieu-Daudé]

On 12/28/20 3:08 AM, BALATON Zoltan via wrote:
> These are not used or not needed.
> 
> Signed-off-by: BALATON Zoltan 
> ---
> v2: Added back a few that we get indirectly but keep it explicit
> 
>  hw/isa/vt82c686.c | 5 -
>  1 file changed, 5 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé 

[PATCH v2 10/10] vt82c686: Remove unneeded includes and defines

[BALATON Zoltan via]

These are not used or not needed.

Signed-off-by: BALATON Zoltan 
---
v2: Added back a few that we get indirectly but keep it explicit

 hw/isa/vt82c686.c | 5 -
 1 file changed, 5 deletions(-)

diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
index d7ce15bf9f..02d6759c00 100644
--- a/hw/isa/vt82c686.c
+++ b/hw/isa/vt82c686.c
@@ -16,9 +16,7 @@
 #include "hw/qdev-properties.h"
 #include "hw/isa/isa.h"
 #include "hw/isa/superio.h"
-#include "hw/sysbus.h"
 #include "migration/vmstate.h"
-#include "hw/mips/mips.h"
 #include "hw/isa/apm.h"
 #include "hw/acpi/acpi.h"
 #include "hw/i2c/pm_smbus.h"
@@ -26,7 +24,6 @@
 #include "qemu/module.h"
 #include "qemu/timer.h"
 #include "exec/address-spaces.h"
-#include "qom/object.h"
 #include "trace.h"
 
 typedef struct SuperIOConfig {
@@ -136,8 +133,6 @@ static void vt82c686b_write_config(PCIDevice *d, uint32_t 
addr,
 }
 }
 
-#define ACPI_DBG_IO_ADDR  0xb044
-
 struct VT686PMState {
 PCIDevice dev;
 MemoryRegion io;
-- 
2.21.3