Re: [PATCH v2 11/19] plugins/core: add missing break in cb_to_tcg_flags

2020-02-13 Thread Philippe Mathieu-Daudé
On 2/13/20 11:51 PM, Alex Bennée wrote:
> From: "Emilio G. Cota" 
> 
> Reported-by: Robert Henry 
> Signed-off-by: Emilio G. Cota 
> Signed-off-by: Alex Bennée 
> Reviewed-by: Richard Henderson 
> Message-Id: <20200105072940.32204-1-c...@braap.org>

Fixes: 54cb65d8588

Reviewed-by: Philippe Mathieu-Daudé 

> Cc: qemu-sta...@nongnu.org
> ---
>  plugins/core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/plugins/core.c b/plugins/core.c
> index 9e1b9e7a915..ed863011baf 100644
> --- a/plugins/core.c
> +++ b/plugins/core.c
> @@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags(enum 
> qemu_plugin_cb_flags flags)
>  switch (flags) {
>  case QEMU_PLUGIN_CB_RW_REGS:
>  ret = 0;
> +break;
>  case QEMU_PLUGIN_CB_R_REGS:
>  ret = TCG_CALL_NO_WG;
>  break;
> 



[PATCH v2 11/19] plugins/core: add missing break in cb_to_tcg_flags

2020-02-13 Thread Alex Bennée
From: "Emilio G. Cota" 

Reported-by: Robert Henry 
Signed-off-by: Emilio G. Cota 
Signed-off-by: Alex Bennée 
Reviewed-by: Richard Henderson 
Message-Id: <20200105072940.32204-1-c...@braap.org>
Cc: qemu-sta...@nongnu.org
---
 plugins/core.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/plugins/core.c b/plugins/core.c
index 9e1b9e7a915..ed863011baf 100644
--- a/plugins/core.c
+++ b/plugins/core.c
@@ -286,6 +286,7 @@ static inline uint32_t cb_to_tcg_flags(enum 
qemu_plugin_cb_flags flags)
 switch (flags) {
 case QEMU_PLUGIN_CB_RW_REGS:
 ret = 0;
+break;
 case QEMU_PLUGIN_CB_R_REGS:
 ret = TCG_CALL_NO_WG;
 break;
-- 
2.20.1