Re: [PATCH v2 23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub

2024-05-14 Thread Helge Deller
* Richard Henderson :
> Signed-off-by: Richard Henderson 

Reviewed-by: Helge Deller 



Re: [PATCH v2 23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub

2024-05-13 Thread Philippe Mathieu-Daudé

On 13/5/24 09:46, Richard Henderson wrote:

Signed-off-by: Richard Henderson 
---
  target/hppa/translate.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé 





[PATCH v2 23/45] target/hppa: Use TCG_COND_TST* in do_unit_addsub

2024-05-13 Thread Richard Henderson
Signed-off-by: Richard Henderson 
---
 target/hppa/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 50cc6decd8..47f4b23d1b 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -1419,8 +1419,8 @@ static void do_unit_addsub(DisasContext *ctx, unsigned 
rt, TCGv_i64 in1,
 tcg_gen_shri_i64(cb, cb, 1);
 }
 
-tcg_gen_andi_i64(cb, cb, test_cb);
-cond = cond_make_ti(cf & 1 ? TCG_COND_EQ : TCG_COND_NE, cb, 0);
+cond = cond_make_ti(cf & 1 ? TCG_COND_TSTEQ : TCG_COND_TSTNE,
+cb, test_cb);
 }
 
 if (is_tc) {
-- 
2.34.1