Re: [PATCH v2 4/4] qemu-options: enable -smbios option on RISC-V

2024-01-22 Thread Andrew Jones
On Fri, Dec 29, 2023 at 01:07:24PM +0100, Heinrich Schuchardt wrote:
> With SMBIOS support added for RISC-V we also should enable the command line
> option.
> 
> Signed-off-by: Heinrich Schuchardt 
> ---
> v2:
>   new patch
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 7bdb414345..5ed82df11f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2705,7 +2705,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
>  "specify SMBIOS type 17 fields\n"
>  "-smbios 
> type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
>  "specify SMBIOS type 41 fields\n",
> -QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
> +QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH | QEMU_ARCH_RISCV)
>  SRST
>  ``-smbios file=binary``
>  Load SMBIOS entry from binary file.
> -- 
> 2.43.0
> 
>

Reviewed-by: Andrew Jones 



Re: [PATCH v2 4/4] qemu-options: enable -smbios option on RISC-V

2024-01-04 Thread Alistair Francis
On Fri, Dec 29, 2023 at 10:08 PM Heinrich Schuchardt
 wrote:
>
> With SMBIOS support added for RISC-V we also should enable the command line
> option.
>
> Signed-off-by: Heinrich Schuchardt 

Acked-by: Alistair Francis 

Alistair

> ---
> v2:
> new patch
> ---
>  qemu-options.hx | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-options.hx
> index 7bdb414345..5ed82df11f 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -2705,7 +2705,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
>  "specify SMBIOS type 17 fields\n"
>  "-smbios 
> type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
>  "specify SMBIOS type 41 fields\n",
> -QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
> +QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH | QEMU_ARCH_RISCV)
>  SRST
>  ``-smbios file=binary``
>  Load SMBIOS entry from binary file.
> --
> 2.43.0
>
>



Re: [PATCH v2 4/4] qemu-options: enable -smbios option on RISC-V

2024-01-03 Thread Daniel Henrique Barboza




On 12/29/23 09:07, Heinrich Schuchardt wrote:

With SMBIOS support added for RISC-V we also should enable the command line
option.

Signed-off-by: Heinrich Schuchardt 
---
v2:
new patch
---


Reviewed-by: Daniel Henrique Barboza 


  qemu-options.hx | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 7bdb414345..5ed82df11f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2705,7 +2705,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
  "specify SMBIOS type 17 fields\n"
  "-smbios 
type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
  "specify SMBIOS type 41 fields\n",
-QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
+QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH | QEMU_ARCH_RISCV)
  SRST
  ``-smbios file=binary``
  Load SMBIOS entry from binary file.




[PATCH v2 4/4] qemu-options: enable -smbios option on RISC-V

2023-12-29 Thread Heinrich Schuchardt
With SMBIOS support added for RISC-V we also should enable the command line
option.

Signed-off-by: Heinrich Schuchardt 
---
v2:
new patch
---
 qemu-options.hx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-options.hx b/qemu-options.hx
index 7bdb414345..5ed82df11f 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -2705,7 +2705,7 @@ DEF("smbios", HAS_ARG, QEMU_OPTION_smbios,
 "specify SMBIOS type 17 fields\n"
 "-smbios type=41[,designation=str][,kind=str][,instance=%d][,pcidev=str]\n"
 "specify SMBIOS type 41 fields\n",
-QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH)
+QEMU_ARCH_I386 | QEMU_ARCH_ARM | QEMU_ARCH_LOONGARCH | QEMU_ARCH_RISCV)
 SRST
 ``-smbios file=binary``
 Load SMBIOS entry from binary file.
-- 
2.43.0