Re: [PATCH v3 0/8] GICv3 LPI and ITS feature implementation

2021-06-02 Thread Shashi Mallela
This is due to missing IORT acpi data,applicable with latest ITS changes.
Will be sharing a separate review with new files.

On May 18 2021, at 10:46 am, Peter Maydell  wrote:
> On Fri, 30 Apr 2021 at 00:42, Shashi Mallela  
> wrote:
> >
> > This patchset implements qemu device model for enabling physical
> > LPI support and ITS functionality in GIC as per GICv3 specification.
> > Both flat table and 2 level tables are implemented.The ITS commands
> > for adding/deleting ITS table entries,trigerring LPI interrupts are
> > implemented.Translated LPI interrupt ids are processed by redistributor
> > to determine priority and set pending state appropriately before
> > forwarding the same to cpu interface.
> > The ITS feature support has been added to sbsa-ref platform as well as
> > virt platform,wherein the emulated functionality co-exists with kvm
> > kernel functionality.
> >
> > Changes in v3:
> > - review comments addressed
> >
> > Shashi Mallela (8):
> > hw/intc: GICv3 ITS initial framework
> > hw/intc: GICv3 ITS register definitions added
> > hw/intc: GICv3 ITS command queue framework
> > hw/intc: GICv3 ITS Command processing
> > hw/intc: GICv3 ITS Feature enablement
> > hw/intc: GICv3 redistributor ITS processing
> > hw/arm/sbsa-ref: add ITS support in SBSA GIC
> > hw/arm/virt: add ITS support in virt GIC
>
> Something in here breaks "make check":
> MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
> QTEST_QEMU_IMG=./qemu-img
> G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-from-laptop/qemu/tests/dbus-vmstate-daemon.sh
> QTEST_QEMU_BINARY=./qemu-system-aarch64 tests/qtest/bios-tables-test
> --tap -k
>
> Looking for expected file 'tests/data/acpi/virt/FACP'
> Using expected file 'tests/data/acpi/virt/FACP'
> Looking for expected file 'tests/data/acpi/virt/APIC'
> Using expected file 'tests/data/acpi/virt/APIC'
> Looking for expected file 'tests/data/acpi/virt/GTDT'
> Using expected file 'tests/data/acpi/virt/GTDT'
> Looking for expected file 'tests/data/acpi/virt/MCFG'
> Using expected file 'tests/data/acpi/virt/MCFG'
> Looking for expected file 'tests/data/acpi/virt/SPCR'
> Using expected file 'tests/data/acpi/virt/SPCR'
> Looking for expected file 'tests/data/acpi/virt/IORT'
> **
> ERROR:../../tests/qtest/bios-tables-test.c:385:load_expected_aml:
> assertion failed: (exp_sdt.aml_file)
> ERROR qtest-aarch64/bios-tables-test - Bail out!
> ERROR:../../tests/qtest/bios-tables-test.c:385:load_expected_aml:
> assertion failed: (exp_sdt.aml_file)
>
> (and then it hangs)
> -- PMM

Re: [PATCH v3 0/8] GICv3 LPI and ITS feature implementation

2021-05-26 Thread shashi . mallela
Have identified the cause of slow down and redesigned the code to scan
LPI pending table and config table right after lpi pending state
changes(SET/RESET) through gicv3_redist_update_lpi() call to determine
the highest priority lpi among the active lpis and save the details.The
high priority interrupt determination logic in redistributor now uses
the saved high priority lpi details (alongside other interrupt types) 
instead of calling gicv3_redist_update_lpi() everytime(as in current
design).This significantly reduces the call overhead associated with
address_space_read of lpi config and pending tables.Testing with this
new design showed no boot delays.
Will share changes in next patch version v4.

Thanks
Shashi


On Tue, 2021-05-25 at 20:30 +0100, Alex Bennée wrote:
> Alex Bennée  writes:
> 
> > Shashi Mallela  writes:
> > 
> > > This patchset implements qemu device model for enabling physical
> > > LPI support and ITS functionality in GIC as per GICv3
> > > specification.
> > > Both flat table and 2 level tables are implemented.The ITS
> > > commands
> > > for adding/deleting ITS table entries,trigerring LPI interrupts
> > > are
> > > implemented.Translated LPI interrupt ids are processed by
> > > redistributor
> > > to determine priority and set pending state appropriately before
> > > forwarding the same to cpu interface.
> > > The ITS feature support has been added to sbsa-ref platform as
> > > well as
> > > virt platform,wherein the emulated functionality co-exists with
> > > kvm
> > > kernel functionality.
> > 
> > So I'm definitely seeing a slow down in one of my testcases but it
> > doesn't seem to be HW access related. Via:
> > 
> 
> > So I ran with the hotblocks plugin:
> > 
> >   ./qemu-system-aarch64 -cpu max,pauth-impdef=on -machine
> > type=virt,virtualization=on,gic-version=3 -display none -serial
> > mon:stdio -kernel
> > ~/lsrc/linux.git/builds/arm64.initramfs/arch/arm64/boot/Image
> > -append "console=ttyAMA0" -m 4096 -smp 1 -plugin
> > contrib/plugins/libhotblocks.so -d plugin -D hotblocks.log
> > 
> >   collected 130606 entries in the hash table
> >   pc, tcount, icount, ecount
> >   0xffc010627fd0, 4, 10, 3998721 - memcpy
> >   0xffc010628288, 2, 6, 3984790 - memset
> >   0xffc01062832c, 3, 4, 1812870 - memset
> >   0xffc0100a8df8, 4, 4, 1743432 - __my_cpu_offset
> >   0xffc01015c394, 2, 4, 1304617 - __my_cpu_offset
> >   0xffc010093348, 3, 3, 1228845 - decay_load
> >   0xffc010093354, 3, 3, 1228447 - decay_load
> >   0xffc01009338c, 3, 2, 1228447 - decay_load
> >   0xffc01009336c, 3, 7, 1180051 - decay_load
> >   0xffc010631300, 3, 4, 1114347 - __radix_tree_lookup
> >   0xffc0106312c8, 3, 12, 1114337 - __radix_tree_lookup
> >   0xffc0106312f8, 3, 2, 1114337 - 
> >   0xffc010132aec, 3, 4, 1080983
> >   0xffc010132afc, 3, 12, 1080983
> >   0xffc010132b30, 3, 2, 1080983
> >   0x4084b58c, 1, 1, 1052116
> >   0x4084b590, 1, 7, 1052116
> >   0x4084b57c, 1, 4, 1051127
> >   0xffc01001a118, 2, 6, 1049119
> >   0xffc01001a944, 2, 2, 1048689
> > 
> > So whatever is holding it up is because it's heavily spamming core
> > functions.
> 
> Well given I've seen it hit gic_handle_irq > 1000 times already while
> in
> the "PCI: CLS 0 bytes, default 64" phase of the kernel boot makes me
> think the IRQs are just re-asserting themselves and firing
> continuously.
> 
> Indeed -d trace:gicv3_redist_set_irq shows a lot of:
> 
>   gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level
> changed to 0
>   gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level
> changed to 1
>   gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level
> changed to 0
>   gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level
> changed to 1
>   gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level
> changed to 0
>   gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level
> changed to 1
> 




Re: [PATCH v3 0/8] GICv3 LPI and ITS feature implementation

2021-05-25 Thread Alex Bennée


Alex Bennée  writes:

> Shashi Mallela  writes:
>
>> This patchset implements qemu device model for enabling physical
>> LPI support and ITS functionality in GIC as per GICv3 specification.
>> Both flat table and 2 level tables are implemented.The ITS commands
>> for adding/deleting ITS table entries,trigerring LPI interrupts are
>> implemented.Translated LPI interrupt ids are processed by redistributor
>> to determine priority and set pending state appropriately before
>> forwarding the same to cpu interface.
>> The ITS feature support has been added to sbsa-ref platform as well as
>> virt platform,wherein the emulated functionality co-exists with kvm
>> kernel functionality.
>
> So I'm definitely seeing a slow down in one of my testcases but it
> doesn't seem to be HW access related. Via:
>

>
> So I ran with the hotblocks plugin:
>
>   ./qemu-system-aarch64 -cpu max,pauth-impdef=on -machine 
> type=virt,virtualization=on,gic-version=3 -display none -serial mon:stdio 
> -kernel ~/lsrc/linux.git/builds/arm64.initramfs/arch/arm64/boot/Image -append 
> "console=ttyAMA0" -m 4096 -smp 1 -plugin contrib/plugins/libhotblocks.so -d 
> plugin -D hotblocks.log
>
>   collected 130606 entries in the hash table
>   pc, tcount, icount, ecount
>   0xffc010627fd0, 4, 10, 3998721 - memcpy
>   0xffc010628288, 2, 6, 3984790 - memset
>   0xffc01062832c, 3, 4, 1812870 - memset
>   0xffc0100a8df8, 4, 4, 1743432 - __my_cpu_offset
>   0xffc01015c394, 2, 4, 1304617 - __my_cpu_offset
>   0xffc010093348, 3, 3, 1228845 - decay_load
>   0xffc010093354, 3, 3, 1228447 - decay_load
>   0xffc01009338c, 3, 2, 1228447 - decay_load
>   0xffc01009336c, 3, 7, 1180051 - decay_load
>   0xffc010631300, 3, 4, 1114347 - __radix_tree_lookup
>   0xffc0106312c8, 3, 12, 1114337 - __radix_tree_lookup
>   0xffc0106312f8, 3, 2, 1114337 - 
>   0xffc010132aec, 3, 4, 1080983
>   0xffc010132afc, 3, 12, 1080983
>   0xffc010132b30, 3, 2, 1080983
>   0x4084b58c, 1, 1, 1052116
>   0x4084b590, 1, 7, 1052116
>   0x4084b57c, 1, 4, 1051127
>   0xffc01001a118, 2, 6, 1049119
>   0xffc01001a944, 2, 2, 1048689
>
> So whatever is holding it up is because it's heavily spamming core
> functions.

Well given I've seen it hit gic_handle_irq > 1000 times already while in
the "PCI: CLS 0 bytes, default 64" phase of the kernel boot makes me
think the IRQs are just re-asserting themselves and firing continuously.

Indeed -d trace:gicv3_redist_set_irq shows a lot of:

  gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level changed to 0
  gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level changed to 1
  gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level changed to 0
  gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level changed to 1
  gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level changed to 0
  gicv3_redist_set_irq GICv3 redistributor 0x0 interrupt 26 level changed to 1

-- 
Alex Bennée



Re: [PATCH v3 0/8] GICv3 LPI and ITS feature implementation

2021-05-25 Thread Alex Bennée


Shashi Mallela  writes:

> This patchset implements qemu device model for enabling physical
> LPI support and ITS functionality in GIC as per GICv3 specification.
> Both flat table and 2 level tables are implemented.The ITS commands
> for adding/deleting ITS table entries,trigerring LPI interrupts are
> implemented.Translated LPI interrupt ids are processed by redistributor
> to determine priority and set pending state appropriately before
> forwarding the same to cpu interface.
> The ITS feature support has been added to sbsa-ref platform as well as
> virt platform,wherein the emulated functionality co-exists with kvm
> kernel functionality.

So I'm definitely seeing a slow down in one of my testcases but it
doesn't seem to be HW access related. Via:

  ./qemu-system-aarch64 -cpu max,pauth-impdef=on -machine 
type=virt,virtualization=on,gic-version=3 -display none -serial mon:stdio 
-kernel ~/lsrc/linux.git/builds/arm64.initramfs/arch/arm64/boot/Image -append 
"console=ttyAMA0" -m 4096 -smp 1 -plugin 
contrib/plugins/libhwprofile.so,arg=source -d plugin -D before.log

  pl011 @ 0xffc017043000
pc:ffc0103502cc, 1, 4, 0, 0
pc:ffc010350308, 1, 4, 0, 0
pc:ffc0103a3c14, 1, 11620, 0, 0
pc:ffc0103a3c4c, 0, 0, 1, 11688
  gicv3_dist @ 0xffc01803
pc:ffc01030c258, 1, 2, 0, 0
pc:ffc01030c31c, 0, 0, 1, 14
pc:ffc01030c348, 0, 0, 1, 56
pc:ffc01030c370, 0, 0, 1, 7
pc:ffc01030c37c, 0, 0, 1, 7
pc:ffc01030cba8, 1, 2, 0, 0
pc:ffc01030cc38, 0, 0, 1, 6
pc:ffc01030cf3c, 1, 1, 0, 0
pc:ffc01030d2b8, 1, 8, 0, 0
pc:ffc01030d6e4, 0, 0, 1, 2
pc:ffc01086b01c, 1, 1, 0, 0
pc:ffc01086b1e0, 1, 1, 0, 0
pc:ffc01086b1ec, 1, 1, 0, 0
pc:ffc01086b258, 1, 1, 0, 0
pc:ffc01086b39c, 0, 0, 1, 1
pc:ffc01086b3d4, 0, 0, 1, 7
pc:ffc01086b4d4, 0, 0, 1, 1
pc:ffc01086b51c, 0, 0, 1, 224
  pcie-mmcfg-mmio @ 0xffc03000
pc:ffc01031de00, 1, 65, 0, 0
pc:ffc01031de1c, 1, 105, 0, 0
pc:ffc01031de3c, 1, 77, 0, 0
pc:ffc01031de9c, 0, 0, 1, 2
pc:ffc01031deb0, 0, 0, 1, 8
pc:ffc01031debc, 0, 0, 1, 31
  virtio-pci-common-virtio-net @ 0xffc0202d5000
pc:ffc01035d348, 1, 9, 0, 0
pc:ffc01035d368, 1, 12, 0, 0
pc:ffc01035d388, 1, 2, 0, 0
pc:ffc01035d3bc, 0, 0, 1, 1
pc:ffc01035d3dc, 0, 0, 1, 1
pc:ffc01035d54c, 0, 0, 1, 1
pc:ffc01035d560, 0, 0, 1, 1
pc:ffc01035d574, 0, 0, 1, 1
pc:ffc01035d588, 0, 0, 1, 1
pc:ffc01035d5bc, 0, 0, 1, 4
pc:ffc01035d780, 0, 0, 1, 3
pc:ffc01035d790, 0, 0, 1, 3
pc:ffc01035d7d0, 0, 0, 1, 1
pc:ffc01035db18, 0, 0, 1, 3
pc:ffc01035dbc0, 0, 0, 1, 3
pc:ffc01035dbd4, 0, 0, 1, 3
pc:ffc01035dbe4, 0, 0, 1, 3
pc:ffc01035dbf8, 0, 0, 1, 3
pc:ffc01035dc08, 0, 0, 1, 3
pc:ffc01035dc1c, 0, 0, 1, 3
pc:ffc01035dc2c, 0, 0, 1, 3
  gicv3_redist_region[0] @ 0xffc018f6
pc:ffc01030c258, 1, 10, 0, 0
pc:ffc01030c3cc, 0, 0, 1, 1
pc:ffc01030c3d8, 0, 0, 1, 1
pc:ffc01030c410, 0, 0, 1, 8
pc:ffc01030c428, 0, 0, 1, 1
pc:ffc01030c8f4, 1, 4, 0, 0
pc:ffc01030cc38, 0, 0, 1, 5
pc:ffc01030d164, 1, 2, 0, 0
pc:ffc01030d2b8, 1, 6, 0, 0
pc:ffc01030d360, 1, 1, 0, 0
pc:ffc01030d374, 0, 0, 1, 1
pc:ffc01030d388, 1, 1, 0, 0
pc:ffc01030e0c8, 0, 0, 1, 1
  virtio-pci-notify-virtio-net @ 0xffc0202e2000
pc:ffc01035e554, 0, 0, 1, 29

But with your series applied the serial output is still the biggest hit:

  pl011 @ 0xffc017043000
pc:ffc0103502cc, 1, 4, 0, 0
pc:ffc010350308, 1, 4, 0, 0
pc:ffc0103a3c14, 1, 11899, 0, 0
pc:ffc0103a3c4c, 0, 0, 1, 11938
  gicv3_dist @ 0xffc01803
pc:ffc01030c258, 1, 1, 0, 0
pc:ffc01030c31c, 0, 0, 1, 14
pc:ffc01030c348, 0, 0, 1, 56
pc:ffc01030c370, 0, 0, 1, 7
pc:ffc01030c37c, 0, 0, 1, 7
pc:ffc01030cba8, 1, 1, 0, 0
pc:ffc01030cc38, 0, 0, 1, 3
pc:ffc01030cf3c, 1, 4, 0, 0
pc:ffc01030d2b8, 1, 5, 0, 0
pc:ffc01030d6e4, 0, 0, 1, 1
pc:ffc01086b01c, 1, 1, 0, 0
pc:ffc01086b1e0, 1, 1, 0, 0
pc:ffc01086b1ec, 1, 1, 0, 0
pc:ffc01086b258, 1, 1, 0, 0
pc:ffc01086b39c, 0, 0, 1, 1
pc:ffc01086b3d4, 0, 0, 1, 7
pc:ffc01086b4d4, 0, 0, 1, 1
pc:ffc01086b51c, 0, 0, 1, 224
  pcie-mmcfg-mmio @ 0xffc03000
pc:ffc01031de00, 1, 65, 0, 0
pc:ffc01031de1c, 1, 122, 0, 0
pc:ffc01031de3c, 1, 79, 0, 0
pc:ffc01031de9c, 0, 0, 1, 2
pc:ffc01031deb0, 0, 0, 1, 13
pc:ffc01031debc, 0, 0, 1, 32
  control @ 0xffc02005
pc:ffc01030e6c4, 1, 21, 0, 0
pc:ffc01030eb00, 0, 0, 1, 5
pc:ffc01030ec94, 1, 1, 0, 0
pc:ffc01030eec8, 1, 

Re: [PATCH v3 0/8] GICv3 LPI and ITS feature implementation

2021-05-18 Thread Peter Maydell
On Fri, 30 Apr 2021 at 00:42, Shashi Mallela  wrote:
>
> This patchset implements qemu device model for enabling physical
> LPI support and ITS functionality in GIC as per GICv3 specification.
> Both flat table and 2 level tables are implemented.The ITS commands
> for adding/deleting ITS table entries,trigerring LPI interrupts are
> implemented.Translated LPI interrupt ids are processed by redistributor
> to determine priority and set pending state appropriately before
> forwarding the same to cpu interface.
> The ITS feature support has been added to sbsa-ref platform as well as
> virt platform,wherein the emulated functionality co-exists with kvm
> kernel functionality.
>
> Changes in v3:
>  - review comments addressed
>
> Shashi Mallela (8):
>   hw/intc: GICv3 ITS initial framework
>   hw/intc: GICv3 ITS register definitions added
>   hw/intc: GICv3 ITS command queue framework
>   hw/intc: GICv3 ITS Command processing
>   hw/intc: GICv3 ITS Feature enablement
>   hw/intc: GICv3 redistributor ITS processing
>   hw/arm/sbsa-ref: add ITS support in SBSA GIC
>   hw/arm/virt: add ITS support in virt GIC

Something in here breaks "make check":

MALLOC_PERTURB_=${MALLOC_PERTURB_:-$(( ${RANDOM:-0} % 255 + 1))}
QTEST_QEMU_IMG=./qemu-img
G_TEST_DBUS_DAEMON=/home/petmay01/linaro/qemu-from-laptop/qemu/tests/dbus-vmstate-daemon.sh
QTEST_QEMU_BINARY=./qemu-system-aarch64 tests/qtest/bios-tables-test
--tap -k

Looking for expected file 'tests/data/acpi/virt/FACP'
Using expected file 'tests/data/acpi/virt/FACP'
Looking for expected file 'tests/data/acpi/virt/APIC'
Using expected file 'tests/data/acpi/virt/APIC'
Looking for expected file 'tests/data/acpi/virt/GTDT'
Using expected file 'tests/data/acpi/virt/GTDT'
Looking for expected file 'tests/data/acpi/virt/MCFG'
Using expected file 'tests/data/acpi/virt/MCFG'
Looking for expected file 'tests/data/acpi/virt/SPCR'
Using expected file 'tests/data/acpi/virt/SPCR'
Looking for expected file 'tests/data/acpi/virt/IORT'
**
ERROR:../../tests/qtest/bios-tables-test.c:385:load_expected_aml:
assertion failed: (exp_sdt.aml_file)
ERROR qtest-aarch64/bios-tables-test - Bail out!
ERROR:../../tests/qtest/bios-tables-test.c:385:load_expected_aml:
assertion failed: (exp_sdt.aml_file)

(and then it hangs)

-- PMM



Re: [PATCH v3 0/8] GICv3 LPI and ITS feature implementation

2021-05-18 Thread Peter Maydell
On Fri, 30 Apr 2021 at 00:42, Shashi Mallela  wrote:
>
> This patchset implements qemu device model for enabling physical
> LPI support and ITS functionality in GIC as per GICv3 specification.
> Both flat table and 2 level tables are implemented.The ITS commands
> for adding/deleting ITS table entries,trigerring LPI interrupts are
> implemented.Translated LPI interrupt ids are processed by redistributor
> to determine priority and set pending state appropriately before
> forwarding the same to cpu interface.
> The ITS feature support has been added to sbsa-ref platform as well as
> virt platform,wherein the emulated functionality co-exists with kvm
> kernel functionality.
>
> Changes in v3:
>  - review comments addressed
>
> Shashi Mallela (8):
>   hw/intc: GICv3 ITS initial framework
>   hw/intc: GICv3 ITS register definitions added
>   hw/intc: GICv3 ITS command queue framework
>   hw/intc: GICv3 ITS Command processing
>   hw/intc: GICv3 ITS Feature enablement
>   hw/intc: GICv3 redistributor ITS processing
>   hw/arm/sbsa-ref: add ITS support in SBSA GIC
>   hw/arm/virt: add ITS support in virt GIC

This fails to build with clang, which has spotted a
missing set of brackets in two places:

../../hw/intc/arm_gicv3_redist.c:568:10: error: logical not is only
applied to the left hand side of this bitwise operator
[-Werror,-Wlogical-not-parentheses]
if ((!cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser ||
 ^  ~
../../hw/intc/arm_gicv3_redist.c:568:10: note: add parentheses after
the '!' to evaluate the bitwise operator first
if ((!cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser ||
 ^
  ()
../../hw/intc/arm_gicv3_redist.c:568:10: note: add parentheses around
left hand side expression to silence this warning
if ((!cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser ||
 ^
 ( )
../../hw/intc/arm_gicv3_redist.c:657:10: error: logical not is only
applied to the left hand side of this bitwise operator
[-Werror,-Wlogical-not-parentheses]
if ((!cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser ||
 ^  ~
../../hw/intc/arm_gicv3_redist.c:657:10: note: add parentheses after
the '!' to evaluate the bitwise operator first
if ((!cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser ||
 ^
  ()
../../hw/intc/arm_gicv3_redist.c:657:10: note: add parentheses around
left hand side expression to silence this warning
if ((!cs->gicr_ctlr & GICR_CTLR_ENABLE_LPIS) || !cs->gicr_propbaser ||
 ^
 ( )

thanks
-- PMM



[PATCH v3 0/8] GICv3 LPI and ITS feature implementation

2021-04-29 Thread Shashi Mallela
This patchset implements qemu device model for enabling physical
LPI support and ITS functionality in GIC as per GICv3 specification.
Both flat table and 2 level tables are implemented.The ITS commands
for adding/deleting ITS table entries,trigerring LPI interrupts are
implemented.Translated LPI interrupt ids are processed by redistributor
to determine priority and set pending state appropriately before
forwarding the same to cpu interface.
The ITS feature support has been added to sbsa-ref platform as well as
virt platform,wherein the emulated functionality co-exists with kvm
kernel functionality.

Changes in v3:
 - review comments addressed

Shashi Mallela (8):
  hw/intc: GICv3 ITS initial framework
  hw/intc: GICv3 ITS register definitions added
  hw/intc: GICv3 ITS command queue framework
  hw/intc: GICv3 ITS Command processing
  hw/intc: GICv3 ITS Feature enablement
  hw/intc: GICv3 redistributor ITS processing
  hw/arm/sbsa-ref: add ITS support in SBSA GIC
  hw/arm/virt: add ITS support in virt GIC

 hw/arm/sbsa-ref.c  |   26 +-
 hw/arm/virt.c  |   27 +-
 hw/intc/arm_gicv3.c|6 +
 hw/intc/arm_gicv3_common.c |   13 +
 hw/intc/arm_gicv3_cpuif.c  |   20 +-
 hw/intc/arm_gicv3_dist.c   |   21 +-
 hw/intc/arm_gicv3_its.c| 1247 
 hw/intc/arm_gicv3_its_common.c |   11 +-
 hw/intc/arm_gicv3_its_kvm.c|2 +-
 hw/intc/arm_gicv3_redist.c |  163 +++-
 hw/intc/gicv3_internal.h   |  186 +++-
 hw/intc/meson.build|1 +
 include/hw/arm/virt.h  |2 +
 include/hw/intc/arm_gicv3_common.h |6 +
 include/hw/intc/arm_gicv3_its_common.h |   40 +-
 target/arm/kvm_arm.h   |4 +-
 16 files changed, 1738 insertions(+), 37 deletions(-)
 create mode 100644 hw/intc/arm_gicv3_its.c

--
2.27.0