Re: [PATCH v3 07/30] Hexagon HVX (target/hexagon) semantics generator

2021-09-20 Thread Richard Henderson

On 9/20/21 2:24 PM, Taylor Simpson wrote:

Add HVX support to the semantics generator

Signed-off-by: Taylor Simpson
---
  target/hexagon/gen_semantics.c | 33 +
  target/hexagon/hex_common.py   | 13 +
  2 files changed, 46 insertions(+)


Acked-by: Richard Henderson 

r~



[PATCH v3 07/30] Hexagon HVX (target/hexagon) semantics generator

2021-09-20 Thread Taylor Simpson
Add HVX support to the semantics generator

Signed-off-by: Taylor Simpson 
---
 target/hexagon/gen_semantics.c | 33 +
 target/hexagon/hex_common.py   | 13 +
 2 files changed, 46 insertions(+)

diff --git a/target/hexagon/gen_semantics.c b/target/hexagon/gen_semantics.c
index c5fccec..4a2bdd7 100644
--- a/target/hexagon/gen_semantics.c
+++ b/target/hexagon/gen_semantics.c
@@ -44,6 +44,11 @@ int main(int argc, char *argv[])
  * Q6INSN(A2_add,"Rd32=add(Rs32,Rt32)",ATTRIBS(),
  * "Add 32-bit registers",
  * { RdV=RsV+RtV;})
+ * HVX instructions have the following form
+ * EXTINSN(V6_vinsertwr, "Vx32.w=vinsert(Rt32)",
+ * ATTRIBS(A_EXTENSION,A_CVI,A_CVI_VX),
+ * "Insert Word Scalar into Vector",
+ * VxV.uw[0] = RtV;)
  */
 #define Q6INSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
 do { \
@@ -59,8 +64,23 @@ int main(int argc, char *argv[])
  ")\n", \
 #TAG, STRINGIZE(ATTRIBS)); \
 } while (0);
+#define EXTINSN(TAG, BEH, ATTRIBS, DESCR, SEM) \
+do { \
+fprintf(outfile, "SEMANTICS( \\\n" \
+ "\"%s\", \\\n" \
+ "%s, \\\n" \
+ "\"\"\"%s\"\"\" \\\n" \
+ ")\n", \
+#TAG, STRINGIZE(BEH), STRINGIZE(SEM)); \
+fprintf(outfile, "ATTRIBUTES( \\\n" \
+ "\"%s\", \\\n" \
+ "\"%s\" \\\n" \
+ ")\n", \
+#TAG, STRINGIZE(ATTRIBS)); \
+} while (0);
 #include "imported/allidefs.def"
 #undef Q6INSN
+#undef EXTINSN
 
 /*
  * Process the macro definitions
@@ -83,6 +103,19 @@ int main(int argc, char *argv[])
 #include "imported/macros.def"
 #undef DEF_MACRO
 
+/*
+ * Process the macros for HVX
+ */
+#define DEF_MACRO(MNAME, BEH, ATTRS) \
+fprintf(outfile, "MACROATTRIB( \\\n" \
+ "\"%s\", \\\n" \
+ "\"\"\"%s\"\"\", \\\n" \
+ "\"%s\" \\\n" \
+ ")\n", \
+#MNAME, STRINGIZE(BEH), STRINGIZE(ATTRS));
+#include "imported/allext_macros.def"
+#undef DEF_MACRO
+
 fclose(outfile);
 return 0;
 }
diff --git a/target/hexagon/hex_common.py b/target/hexagon/hex_common.py
index b3b5340..47fb628 100755
--- a/target/hexagon/hex_common.py
+++ b/target/hexagon/hex_common.py
@@ -143,6 +143,9 @@ def compute_tag_immediates(tag):
 ##  Ppredicate register
 ##  RGPR register
 ##  Mmodifier register
+##  QHVX predicate vector
+##  VHVX vector register
+##  OHVX new vector register
 ##  regid can be one of the following
 ##  d, e destination register
 ##  dd   destination register pair
@@ -178,6 +181,9 @@ def is_readwrite(regid):
 def is_scalar_reg(regtype):
 return regtype in "RPC"
 
+def is_hvx_reg(regtype):
+return regtype in "VQ"
+
 def is_old_val(regtype, regid, tag):
 return regtype+regid+'V' in semdict[tag]
 
@@ -201,6 +207,13 @@ def need_ea(tag):
 def skip_qemu_helper(tag):
 return tag in overrides.keys()
 
+def is_tmp_result(tag):
+return ('A_CVI_TMP' in attribdict[tag] or
+'A_CVI_TMP_DST' in attribdict[tag])
+
+def is_new_result(tag):
+return ('A_CVI_NEW' in attribdict[tag])
+
 def imm_name(immlett):
 return "%siV" % immlett
 
-- 
2.7.4