Re: [PATCH v3 2/3] i386: acpi: vmbus: Add _ADR definition
On 23/06/2020, Igor Mammedov wrote:
On Thu, 18 Jun 2020 06:00:26 +0300
Jon Doron wrote:
It seems like latest HyperV sets _ADR to 0 in the ACPI for the VMBS
that's a hardly a good reason to add this.
To me looks like a pointless addition,
_ADR mostly is used when device resides on a bus with standard ennumeration
algorithm (i.e. PCI, ...).
Value is also wrong for the bus it's placed currently,
and with the next patch it won't make a sense altogether.
Pls, drop this patch unless Windows refuses to work without it.
Windows seems to handle fine without this.
Signed-off-by: Jon Doron
---
hw/i386/acpi-build.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 91af0d2d0d..6d9df38e31 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1061,6 +1061,7 @@ static Aml *build_vmbus_device_aml(VMBusBridge
*vmbus_bridge)
dev = aml_device("VMBS");
aml_append(dev, aml_name_decl("STA", aml_int(0xF)));
+aml_append(dev, aml_name_decl("_ADR", aml_int(0x0)));
aml_append(dev, aml_name_decl("_HID", aml_string("VMBus")));
aml_append(dev, aml_name_decl("_UID", aml_int(0x0)));
aml_append(dev, aml_name_decl("_DDN", aml_string("VMBUS")));
Re: [PATCH v3 2/3] i386: acpi: vmbus: Add _ADR definition
On Thu, 18 Jun 2020 06:00:26 +0300
Jon Doron wrote:
> It seems like latest HyperV sets _ADR to 0 in the ACPI for the VMBS
that's a hardly a good reason to add this.
To me looks like a pointless addition,
_ADR mostly is used when device resides on a bus with standard ennumeration
algorithm (i.e. PCI, ...).
Value is also wrong for the bus it's placed currently,
and with the next patch it won't make a sense altogether.
Pls, drop this patch unless Windows refuses to work without it.
>
> Signed-off-by: Jon Doron
> ---
> hw/i386/acpi-build.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> index 91af0d2d0d..6d9df38e31 100644
> --- a/hw/i386/acpi-build.c
> +++ b/hw/i386/acpi-build.c
> @@ -1061,6 +1061,7 @@ static Aml *build_vmbus_device_aml(VMBusBridge
> *vmbus_bridge)
>
> dev = aml_device("VMBS");
> aml_append(dev, aml_name_decl("STA", aml_int(0xF)));
> +aml_append(dev, aml_name_decl("_ADR", aml_int(0x0)));
> aml_append(dev, aml_name_decl("_HID", aml_string("VMBus")));
> aml_append(dev, aml_name_decl("_UID", aml_int(0x0)));
> aml_append(dev, aml_name_decl("_DDN", aml_string("VMBUS")));
[PATCH v3 2/3] i386: acpi: vmbus: Add _ADR definition
It seems like latest HyperV sets _ADR to 0 in the ACPI for the VMBS
Signed-off-by: Jon Doron
---
hw/i386/acpi-build.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 91af0d2d0d..6d9df38e31 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1061,6 +1061,7 @@ static Aml *build_vmbus_device_aml(VMBusBridge
*vmbus_bridge)
dev = aml_device("VMBS");
aml_append(dev, aml_name_decl("STA", aml_int(0xF)));
+aml_append(dev, aml_name_decl("_ADR", aml_int(0x0)));
aml_append(dev, aml_name_decl("_HID", aml_string("VMBus")));
aml_append(dev, aml_name_decl("_UID", aml_int(0x0)));
aml_append(dev, aml_name_decl("_DDN", aml_string("VMBUS")));
--
2.24.1
