Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts
On 6/18/20 3:27 AM, Auger Eric wrote: I have to defer this series since there are some things that don't work on the Linux level with IRQ 13 (edge) while they do work fine on the old IRQ 5 (festeoi). I know which changes to make to Linux so that it works on IRQ 13 as well, but I am not sure whether those changes are acceptable. So now we could upstream this one here: [PATCH v4 4/8] tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ Stefan Hi Stefan, On 6/17/20 4:22 PM, Stefan Berger wrote: This series of patches enables the usage of the TPM TIS with interrupts. We use the unused IRQ 13, which is the only one accepted by Windows. Stefan v3->v4: - Changed TPM_IRQ_DISABLED from -1 to ~0 v2->v3: - Extended series to disable IRQ for TIS on sysbus v1->v2: - Added updated DSDT Stefan Berger (8): tpm_tis: Allow lowering of IRQ also when locality is not active tpm: Extend TPMIfClass with get_irqnum() function tests: Temporarily ignore DSDT table differences tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ acpi: Enable TPM IRQ tests: Add updated DSDT tpm: Guard irq related ops in case interrupts are disabled tpm: Disable interrupt support for TIS on sysbus hw/i386/acpi-build.c | 11 +-- hw/tpm/tpm_tis_common.c | 12 +--- hw/tpm/tpm_tis_isa.c | 17 ++--- hw/tpm/tpm_tis_sysbus.c | 12 +++- include/hw/acpi/tpm.h| 3 ++- include/sysemu/tpm.h | 12 tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes 7 files changed, 53 insertions(+), 14 deletions(-) I checked this series does not bring any regression on ARM TPM-TIS device. So if useful/relevant, feel free to add my T-b from the ARM pov. Tested-by: Eric Auger Thanks Eric
Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts
On 6/23/20 9:09 AM, Michael S. Tsirkin wrote: On Wed, Jun 17, 2020 at 10:22:57AM -0400, Stefan Berger wrote: This series of patches enables the usage of the TPM TIS with interrupts. We use the unused IRQ 13, which is the only one accepted by Windows. Stefan ACPI parts: Reviewed-by: Michael S. Tsirkin How do we want this merged? TPM tree or mine? Queued it here: https://github.com/stefanberger/qemu-tpm/commits/tpm-next Was going to send a PR later this week with this part. Will add your Rb-s. Stefan v3->v4: - Changed TPM_IRQ_DISABLED from -1 to ~0 v2->v3: - Extended series to disable IRQ for TIS on sysbus v1->v2: - Added updated DSDT Stefan Berger (8): tpm_tis: Allow lowering of IRQ also when locality is not active tpm: Extend TPMIfClass with get_irqnum() function tests: Temporarily ignore DSDT table differences tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ acpi: Enable TPM IRQ tests: Add updated DSDT tpm: Guard irq related ops in case interrupts are disabled tpm: Disable interrupt support for TIS on sysbus hw/i386/acpi-build.c | 11 +-- hw/tpm/tpm_tis_common.c | 12 +--- hw/tpm/tpm_tis_isa.c | 17 ++--- hw/tpm/tpm_tis_sysbus.c | 12 +++- include/hw/acpi/tpm.h| 3 ++- include/sysemu/tpm.h | 12 tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes 7 files changed, 53 insertions(+), 14 deletions(-) -- 2.24.1
Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts
On Wed, Jun 17, 2020 at 10:22:57AM -0400, Stefan Berger wrote: > This series of patches enables the usage of the TPM TIS with interrupts. > We use the unused IRQ 13, which is the only one accepted by Windows. > > Stefan ACPI parts: Reviewed-by: Michael S. Tsirkin How do we want this merged? TPM tree or mine? > v3->v4: > - Changed TPM_IRQ_DISABLED from -1 to ~0 > > v2->v3: > - Extended series to disable IRQ for TIS on sysbus > > v1->v2: > - Added updated DSDT > > Stefan Berger (8): > tpm_tis: Allow lowering of IRQ also when locality is not active > tpm: Extend TPMIfClass with get_irqnum() function > tests: Temporarily ignore DSDT table differences > tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ > acpi: Enable TPM IRQ > tests: Add updated DSDT > tpm: Guard irq related ops in case interrupts are disabled > tpm: Disable interrupt support for TIS on sysbus > > hw/i386/acpi-build.c | 11 +-- > hw/tpm/tpm_tis_common.c | 12 +--- > hw/tpm/tpm_tis_isa.c | 17 ++--- > hw/tpm/tpm_tis_sysbus.c | 12 +++- > include/hw/acpi/tpm.h| 3 ++- > include/sysemu/tpm.h | 12 > tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes > 7 files changed, 53 insertions(+), 14 deletions(-) > > -- > 2.24.1 > >
Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts
Hi Stefan, On 6/17/20 4:22 PM, Stefan Berger wrote: > This series of patches enables the usage of the TPM TIS with interrupts. > We use the unused IRQ 13, which is the only one accepted by Windows. > > Stefan > > v3->v4: > - Changed TPM_IRQ_DISABLED from -1 to ~0 > > v2->v3: > - Extended series to disable IRQ for TIS on sysbus > > v1->v2: > - Added updated DSDT > > Stefan Berger (8): > tpm_tis: Allow lowering of IRQ also when locality is not active > tpm: Extend TPMIfClass with get_irqnum() function > tests: Temporarily ignore DSDT table differences > tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ > acpi: Enable TPM IRQ > tests: Add updated DSDT > tpm: Guard irq related ops in case interrupts are disabled > tpm: Disable interrupt support for TIS on sysbus > > hw/i386/acpi-build.c | 11 +-- > hw/tpm/tpm_tis_common.c | 12 +--- > hw/tpm/tpm_tis_isa.c | 17 ++--- > hw/tpm/tpm_tis_sysbus.c | 12 +++- > include/hw/acpi/tpm.h| 3 ++- > include/sysemu/tpm.h | 12 > tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes > 7 files changed, 53 insertions(+), 14 deletions(-) > I checked this series does not bring any regression on ARM TPM-TIS device. So if useful/relevant, feel free to add my T-b from the ARM pov. Tested-by: Eric Auger Thanks Eric
Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts
Patchew URL: https://patchew.org/QEMU/20200617142305.1198672-1-stef...@linux.vnet.ibm.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === GEN docs/interop/qemu-qmp-ref.html GEN docs/interop/qemu-qmp-ref.txt GEN docs/interop/qemu-qmp-ref.7 /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC qga/commands.o CC qga/guest-agent-command-state.o CC qga/main.o --- AR libvhost-user.a GEN docs/interop/qemu-ga-ref.txt GEN docs/interop/qemu-ga-ref.7 /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-keymap /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-client LINKivshmem-server AS pc-bios/optionrom/multiboot.o AS pc-bios/optionrom/linuxboot.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC pc-bios/optionrom/linuxboot_dma.o AS pc-bios/optionrom/pvh.o AS pc-bios/optionrom/kvmvapic.o --- BUILD pc-bios/optionrom/linuxboot_dma.raw BUILD pc-bios/optionrom/kvmvapic.raw SIGNpc-bios/optionrom/multiboot.bin /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) SIGNpc-bios/optionrom/linuxboot.bin SIGNpc-bios/optionrom/linuxboot_dma.bin LINKqemu-storage-daemon --- BUILD pc-bios/optionrom/pvh.img BUILD pc-bios/optionrom/pvh.raw LINKqemu-img /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) SIGNpc-bios/optionrom/pvh.bin /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-io LINKqemu-edid /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKfsdev/virtfs-proxy-helper LINKscsi/qemu-pr-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-bridge-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from
Re: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts
Patchew URL: https://patchew.org/QEMU/20200617142305.1198672-1-stef...@linux.vnet.ibm.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts Type: series Message-id: 20200617142305.1198672-1-stef...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20200617142305.1198672-1-stef...@linux.vnet.ibm.com -> patchew/20200617142305.1198672-1-stef...@linux.vnet.ibm.com Switched to a new branch 'test' 527f6a6 tpm: Disable interrupt support for TIS on sysbus 2409660 tpm: Guard irq related ops in case interrupts are disabled 727db5a tests: Add updated DSDT 9ae0b0d acpi: Enable TPM IRQ 62a659a tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ 4e3994a tests: Temporarily ignore DSDT table differences 651ddf0 tpm: Extend TPMIfClass with get_irqnum() function 9fe25b1 tpm_tis: Allow lowering of IRQ also when locality is not active === OUTPUT BEGIN === 1/8 Checking commit 9fe25b11a231 (tpm_tis: Allow lowering of IRQ also when locality is not active) 2/8 Checking commit 651ddf03a413 (tpm: Extend TPMIfClass with get_irqnum() function) ERROR: Macros with complex values should be enclosed in parenthesis #77: FILE: include/sysemu/tpm.h:28: +#define TPM_IRQ_DISABLED ~0 total: 1 errors, 0 warnings, 70 lines checked Patch 2/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/8 Checking commit 4e3994ae9e45 (tests: Temporarily ignore DSDT table differences) 4/8 Checking commit 62a659ab5c12 (tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ) 5/8 Checking commit 9ae0b0d6f724 (acpi: Enable TPM IRQ) 6/8 Checking commit 727db5ac78ac (tests: Add updated DSDT) 7/8 Checking commit 240966001b86 (tpm: Guard irq related ops in case interrupts are disabled) 8/8 Checking commit 527f6a6fdb16 (tpm: Disable interrupt support for TIS on sysbus) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20200617142305.1198672-1-stef...@linux.vnet.ibm.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
[PATCH v4 0/8] tpm: Enable usage of TPM TIS with interrupts
This series of patches enables the usage of the TPM TIS with interrupts. We use the unused IRQ 13, which is the only one accepted by Windows. Stefan v3->v4: - Changed TPM_IRQ_DISABLED from -1 to ~0 v2->v3: - Extended series to disable IRQ for TIS on sysbus v1->v2: - Added updated DSDT Stefan Berger (8): tpm_tis: Allow lowering of IRQ also when locality is not active tpm: Extend TPMIfClass with get_irqnum() function tests: Temporarily ignore DSDT table differences tpm: Split TPM_TIS_IRQ into TPM_TIS_ISA_IRQ and TPM_TIS_SYSBUS_IRQ acpi: Enable TPM IRQ tests: Add updated DSDT tpm: Guard irq related ops in case interrupts are disabled tpm: Disable interrupt support for TIS on sysbus hw/i386/acpi-build.c | 11 +-- hw/tpm/tpm_tis_common.c | 12 +--- hw/tpm/tpm_tis_isa.c | 17 ++--- hw/tpm/tpm_tis_sysbus.c | 12 +++- include/hw/acpi/tpm.h| 3 ++- include/sysemu/tpm.h | 12 tests/data/acpi/q35/DSDT.tis | Bin 8357 -> 8360 bytes 7 files changed, 53 insertions(+), 14 deletions(-) -- 2.24.1
