Re: [PATCH v4 01/23] qapi/parser: fix typo - self.returns.info => self.errors.info
Philippe Mathieu-Daudé writes: > On 13/3/24 05:41, John Snow wrote: >> Small copy-pasto. The correct info field to use in this conditional >> block is self.errors.info. >> Fixes: 3a025d3d1ffa > > Reported-by: Markus Armbruster I did? Messed-up-by: me would be accurate, though! >> Signed-off-by: John Snow >> --- >> scripts/qapi/parser.py | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)
Re: [PATCH v4 01/23] qapi/parser: fix typo - self.returns.info => self.errors.info
On 13/3/24 05:41, John Snow wrote: Small copy-pasto. The correct info field to use in this conditional block is self.errors.info. Fixes: 3a025d3d1ffa Reported-by: Markus Armbruster Signed-off-by: John Snow --- scripts/qapi/parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH v4 01/23] qapi/parser: fix typo - self.returns.info => self.errors.info
Small copy-pasto. The correct info field to use in this conditional block is self.errors.info. Fixes: 3a025d3d1ffa Signed-off-by: John Snow --- scripts/qapi/parser.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py index d8f76060b8c..fed88e9074d 100644 --- a/scripts/qapi/parser.py +++ b/scripts/qapi/parser.py @@ -733,7 +733,7 @@ def check_expr(self, expr: QAPIExpression) -> None: "'Returns' section is only valid for commands") if self.errors: raise QAPISemError( -self.returns.info, +self.errors.info, "'Errors' section is only valid for commands") def check(self) -> None: -- 2.44.0