Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations
Rohit Shinde writes: > Hey Markus, > > Thanks for the clarification! No, I do not have patches for the same. I was > browsing through the bite sized tasks page and that did not mention these > details. I will keep this in mind however. For now, I will leave this task > and I might return to it at a later time. I corrected https://wiki.qemu.org/Contribute/BiteSizedTasks to ask for -Wimplicit-fallthrough=2. Thanks!
Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations
Hey Markus, Thanks for the clarification! No, I do not have patches for the same. I was browsing through the bite sized tasks page and that did not mention these details. I will keep this in mind however. For now, I will leave this task and I might return to it at a later time. Thanks, Rohit. On Wed, Aug 26, 2020 at 11:10 PM Markus Armbruster wrote: > Rohit Shinde writes: > > > I am just compiling with cflag set to -Wimplicit-fallthrough. I am using > > gcc. > > -Wimplicit-fallthrough is the same as -Wimplicit-fallthrough=3. Our > -code is not prepared for that. What should work is > --Wimplicit-fallthrough=2. > > If you have patches to make the entire tree compile with > -Wimplicit-fallthrough=3, we can talk. You'd have to test them on all > supported hosts, and with a sufficient range of configurations to ensure > they are not breaking builds. > >
Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations
Rohit Shinde writes: > I am just compiling with cflag set to -Wimplicit-fallthrough. I am using > gcc. -Wimplicit-fallthrough is the same as -Wimplicit-fallthrough=3. Our -code is not prepared for that. What should work is --Wimplicit-fallthrough=2. If you have patches to make the entire tree compile with -Wimplicit-fallthrough=3, we can talk. You'd have to test them on all supported hosts, and with a sufficient range of configurations to ensure they are not breaking builds.
Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations
I am just compiling with cflag set to -Wimplicit-fallthrough. I am using
gcc.
On Tue, Aug 25, 2020 at 2:03 AM Markus Armbruster wrote:
> Rohit Shinde writes:
>
> > Added fallthrough comment on line 270 to prevent the compiler from
> > throwing an error while compiling with the -Wimplicit-fallthrough flag
>
> None of the compilers I know warns there. Which one are you using?
>
> Commit message style tip: use the imperative mood
> https://chris.beams.io/posts/git-commit/#imperative
>
> > Signed-off-by: Rohit Shinde
> > ---
> > qapi/opts-visitor.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
> > index 7781c23a42..3422ff265e 100644
> > --- a/qapi/opts-visitor.c
> > +++ b/qapi/opts-visitor.c
> > @@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t
> size)
> > }
> > ov->list_mode = LM_IN_PROGRESS;
> > /* range has been completed, fall through in order to pop
> option */
> > +/* fallthrough */
> >
> > case LM_IN_PROGRESS: {
> > const QemuOpt *opt;
>
>
Re: [PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations
Rohit Shinde writes:
> Added fallthrough comment on line 270 to prevent the compiler from
> throwing an error while compiling with the -Wimplicit-fallthrough flag
None of the compilers I know warns there. Which one are you using?
Commit message style tip: use the imperative mood
https://chris.beams.io/posts/git-commit/#imperative
> Signed-off-by: Rohit Shinde
> ---
> qapi/opts-visitor.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
> index 7781c23a42..3422ff265e 100644
> --- a/qapi/opts-visitor.c
> +++ b/qapi/opts-visitor.c
> @@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t size)
> }
> ov->list_mode = LM_IN_PROGRESS;
> /* range has been completed, fall through in order to pop option */
> +/* fallthrough */
>
> case LM_IN_PROGRESS: {
> const QemuOpt *opt;
[PATCH v5] qapi/opts-visitor: Added missing fallthrough annotations
Added fallthrough comment on line 270 to prevent the compiler from
throwing an error while compiling with the -Wimplicit-fallthrough flag
Signed-off-by: Rohit Shinde
---
qapi/opts-visitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c
index 7781c23a42..3422ff265e 100644
--- a/qapi/opts-visitor.c
+++ b/qapi/opts-visitor.c
@@ -266,6 +266,7 @@ opts_next_list(Visitor *v, GenericList *tail, size_t size)
}
ov->list_mode = LM_IN_PROGRESS;
/* range has been completed, fall through in order to pop option */
+/* fallthrough */
case LM_IN_PROGRESS: {
const QemuOpt *opt;
--
2.25.1
