Re: [PATCH v5 02/18] exec/memop: Adding signed quad and octo defines

2021-11-23 Thread Philippe Mathieu-Daudé 
On 11/12/21 15:58, Frédéric Pétrot wrote:
> Adding defines to handle signed 64-bit and unsigned 128-bit quantities in
> memory accesses.
> 
> Signed-off-by: Frédéric Pétrot 
> ---
>  include/exec/memop.h | 7 +++
>  1 file changed, 7 insertions(+)

Reviewed-by: Philippe Mathieu-Daudé

Re: [PATCH v5 02/18] exec/memop: Adding signed quad and octo defines

2021-11-21 Thread Alistair Francis 
On Sat, Nov 13, 2021 at 1:13 AM Frédéric Pétrot
 wrote:
>
> Adding defines to handle signed 64-bit and unsigned 128-bit quantities in
> memory accesses.
>
> Signed-off-by: Frédéric Pétrot 

Reviewed-by: Alistair Francis 

Alistair

> ---
>  include/exec/memop.h | 7 +++
>  1 file changed, 7 insertions(+)
>
> diff --git a/include/exec/memop.h b/include/exec/memop.h
> index 72c2f0ff3d..2a885f3917 100644
> --- a/include/exec/memop.h
> +++ b/include/exec/memop.h
> @@ -86,28 +86,35 @@ typedef enum MemOp {
>  MO_UW= MO_16,
>  MO_UL= MO_32,
>  MO_UQ= MO_64,
> +MO_UO= MO_128,
>  MO_SB= MO_SIGN | MO_8,
>  MO_SW= MO_SIGN | MO_16,
>  MO_SL= MO_SIGN | MO_32,
> +MO_SQ= MO_SIGN | MO_64,
> +MO_SO= MO_SIGN | MO_128,
>
>  MO_LEUW  = MO_LE | MO_UW,
>  MO_LEUL  = MO_LE | MO_UL,
>  MO_LEUQ  = MO_LE | MO_UQ,
>  MO_LESW  = MO_LE | MO_SW,
>  MO_LESL  = MO_LE | MO_SL,
> +MO_LESQ  = MO_LE | MO_SQ,
>
>  MO_BEUW  = MO_BE | MO_UW,
>  MO_BEUL  = MO_BE | MO_UL,
>  MO_BEUQ  = MO_BE | MO_UQ,
>  MO_BESW  = MO_BE | MO_SW,
>  MO_BESL  = MO_BE | MO_SL,
> +MO_BESQ  = MO_BE | MO_SQ,
>
>  #ifdef NEED_CPU_H
>  MO_TEUW  = MO_TE | MO_UW,
>  MO_TEUL  = MO_TE | MO_UL,
>  MO_TEUQ  = MO_TE | MO_UQ,
> +MO_TEUO  = MO_TE | MO_UO,
>  MO_TESW  = MO_TE | MO_SW,
>  MO_TESL  = MO_TE | MO_SL,
> +MO_TESQ  = MO_TE | MO_SQ,
>  #endif
>
>  MO_SSIZE = MO_SIZE | MO_SIGN,
> --
> 2.33.1
>
>

Re: [PATCH v5 02/18] exec/memop: Adding signed quad and octo defines

2021-11-15 Thread Richard Henderson 

On 11/12/21 3:58 PM, Frédéric Pétrot wrote:

Adding defines to handle signed 64-bit and unsigned 128-bit quantities in
memory accesses.

Signed-off-by: Frédéric Pétrot
---
  include/exec/memop.h | 7 +++
  1 file changed, 7 insertions(+)


Reviewed-by: Richard Henderson 

r~

[PATCH v5 02/18] exec/memop: Adding signed quad and octo defines

2021-11-12 Thread Frédéric Pétrot 
Adding defines to handle signed 64-bit and unsigned 128-bit quantities in
memory accesses.

Signed-off-by: Frédéric Pétrot 
---
 include/exec/memop.h | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/include/exec/memop.h b/include/exec/memop.h
index 72c2f0ff3d..2a885f3917 100644
--- a/include/exec/memop.h
+++ b/include/exec/memop.h
@@ -86,28 +86,35 @@ typedef enum MemOp {
 MO_UW= MO_16,
 MO_UL= MO_32,
 MO_UQ= MO_64,
+MO_UO= MO_128,
 MO_SB= MO_SIGN | MO_8,
 MO_SW= MO_SIGN | MO_16,
 MO_SL= MO_SIGN | MO_32,
+MO_SQ= MO_SIGN | MO_64,
+MO_SO= MO_SIGN | MO_128,
 
 MO_LEUW  = MO_LE | MO_UW,
 MO_LEUL  = MO_LE | MO_UL,
 MO_LEUQ  = MO_LE | MO_UQ,
 MO_LESW  = MO_LE | MO_SW,
 MO_LESL  = MO_LE | MO_SL,
+MO_LESQ  = MO_LE | MO_SQ,
 
 MO_BEUW  = MO_BE | MO_UW,
 MO_BEUL  = MO_BE | MO_UL,
 MO_BEUQ  = MO_BE | MO_UQ,
 MO_BESW  = MO_BE | MO_SW,
 MO_BESL  = MO_BE | MO_SL,
+MO_BESQ  = MO_BE | MO_SQ,
 
 #ifdef NEED_CPU_H
 MO_TEUW  = MO_TE | MO_UW,
 MO_TEUL  = MO_TE | MO_UL,
 MO_TEUQ  = MO_TE | MO_UQ,
+MO_TEUO  = MO_TE | MO_UO,
 MO_TESW  = MO_TE | MO_SW,
 MO_TESL  = MO_TE | MO_SL,
+MO_TESQ  = MO_TE | MO_SQ,
 #endif
 
 MO_SSIZE = MO_SIZE | MO_SIGN,
-- 
2.33.1