Re: [PATCH v8 10/12] vhost_net: add NetClientState->load() callback

[Jason Wang]

On Wed, Aug 10, 2022 at 1:40 AM Eugenio Pérez  wrote:
>
> It allows per-net client operations right after device's successful
> start. In particular, to load the device status.
>
> Vhost-vdpa net will use it to add the CVQ buffers to restore the device
> status.
>
> Signed-off-by: Eugenio Pérez 

Acked-by: Jason Wang 

> ---
> v5: Rename start / load, naming it more specifically.
> ---
>  include/net/net.h  | 2 ++
>  hw/net/vhost_net.c | 7 +++
>  2 files changed, 9 insertions(+)
>
> diff --git a/include/net/net.h b/include/net/net.h
> index 476ad45b9a..81d0b21def 100644
> --- a/include/net/net.h
> +++ b/include/net/net.h
> @@ -45,6 +45,7 @@ typedef struct NICConf {
>  typedef void (NetPoll)(NetClientState *, bool enable);
>  typedef bool (NetCanReceive)(NetClientState *);
>  typedef int (NetStart)(NetClientState *);
> +typedef int (NetLoad)(NetClientState *);
>  typedef void (NetStop)(NetClientState *);
>  typedef ssize_t (NetReceive)(NetClientState *, const uint8_t *, size_t);
>  typedef ssize_t (NetReceiveIOV)(NetClientState *, const struct iovec *, int);
> @@ -74,6 +75,7 @@ typedef struct NetClientInfo {
>  NetReceiveIOV *receive_iov;
>  NetCanReceive *can_receive;
>  NetStart *start;
> +NetLoad *load;
>  NetStop *stop;
>  NetCleanup *cleanup;
>  LinkStatusChanged *link_status_changed;
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index 9d4b334453..d28f8b974b 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -281,6 +281,13 @@ static int vhost_net_start_one(struct vhost_net *net,
>  }
>  }
>  }
> +
> +if (net->nc->info->load) {
> +r = net->nc->info->load(net->nc);
> +if (r < 0) {
> +goto fail;
> +}
> +}
>  return 0;
>  fail:
>  file.fd = -1;
> --
> 2.31.1
>

[PATCH v8 10/12] vhost_net: add NetClientState->load() callback

[Eugenio Pérez]

It allows per-net client operations right after device's successful
start. In particular, to load the device status.

Vhost-vdpa net will use it to add the CVQ buffers to restore the device
status.

Signed-off-by: Eugenio Pérez 
---
v5: Rename start / load, naming it more specifically.
---
 include/net/net.h  | 2 ++
 hw/net/vhost_net.c | 7 +++
 2 files changed, 9 insertions(+)

diff --git a/include/net/net.h b/include/net/net.h
index 476ad45b9a..81d0b21def 100644
--- a/include/net/net.h
+++ b/include/net/net.h
@@ -45,6 +45,7 @@ typedef struct NICConf {
 typedef void (NetPoll)(NetClientState *, bool enable);
 typedef bool (NetCanReceive)(NetClientState *);
 typedef int (NetStart)(NetClientState *);
+typedef int (NetLoad)(NetClientState *);
 typedef void (NetStop)(NetClientState *);
 typedef ssize_t (NetReceive)(NetClientState *, const uint8_t *, size_t);
 typedef ssize_t (NetReceiveIOV)(NetClientState *, const struct iovec *, int);
@@ -74,6 +75,7 @@ typedef struct NetClientInfo {
 NetReceiveIOV *receive_iov;
 NetCanReceive *can_receive;
 NetStart *start;
+NetLoad *load;
 NetStop *stop;
 NetCleanup *cleanup;
 LinkStatusChanged *link_status_changed;
diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
index 9d4b334453..d28f8b974b 100644
--- a/hw/net/vhost_net.c
+++ b/hw/net/vhost_net.c
@@ -281,6 +281,13 @@ static int vhost_net_start_one(struct vhost_net *net,
 }
 }
 }
+
+if (net->nc->info->load) {
+r = net->nc->info->load(net->nc);
+if (r < 0) {
+goto fail;
+}
+}
 return 0;
 fail:
 file.fd = -1;
-- 
2.31.1