Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig
On 6/25/20 12:20 PM, Paolo Bonzini wrote: > On 25/06/20 09:49, Philippe Mathieu-Daudé wrote: >> Hi Paolo, >> >> Claudio raised an issue with patch #4, so at this point >> I have to admit again having the KVM-only build merged >> for the next release won't be possible :( >> >> Only patch #9 depends on patch #4. Are you OK to take >> the rest of the series, patches 1-3, 5-8, 10 (all but >> 4 and 9). Patches are fully reviewed. If it is easier >> for you I can respin without 4/9. > > Yes, sounds good. Patch 4 isn't great and with Meson we can indeed do > better because all config-target.mak files are parsed in a single > non-recursive build. OK, thanks!
Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig
On 25/06/20 09:49, Philippe Mathieu-Daudé wrote: > Hi Paolo, > > Claudio raised an issue with patch #4, so at this point > I have to admit again having the KVM-only build merged > for the next release won't be possible :( > > Only patch #9 depends on patch #4. Are you OK to take > the rest of the series, patches 1-3, 5-8, 10 (all but > 4 and 9). Patches are fully reviewed. If it is easier > for you I can respin without 4/9. Yes, sounds good. Patch 4 isn't great and with Meson we can indeed do better because all config-target.mak files are parsed in a single non-recursive build. Paolo
Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig
Hi Paolo, Claudio raised an issue with patch #4, so at this point I have to admit again having the KVM-only build merged for the next release won't be possible :( Only patch #9 depends on patch #4. Are you OK to take the rest of the series, patches 1-3, 5-8, 10 (all but 4 and 9). Patches are fully reviewed. If it is easier for you I can respin without 4/9. Thanks, Phil. On 6/22/20 6:47 PM, Philippe Mathieu-Daudé wrote: > On 6/18/20 2:33 PM, Philippe Mathieu-Daudé wrote: >> Missing review: >> - 03/10 MAINTAINERS: Cover the HAX accelerator stub > > I forgot again to include the HAXM team... > >> - 04/10 configure: Generate rule to calculate base arch of target >> >> This series include generic patches I took of the KVM/ARM >> specific series which will follow. >> >> - Update accelerators in MAINTAINERS >> - Add accel/Kconfig >> - Allow targets to use their how Kconfig >> [...] >> >> Previous RFC for semihosting posted earlier: >> https://www.mail-archive.com/qemu-devel@nongnu.org/msg631218.html >> >> Alex Bennée (1): >> configure: Generate rule to calculate the base architecture of a >> target >> >> Philippe Mathieu-Daudé (9): >> MAINTAINERS: Fix KVM path expansion glob >> MAINTAINERS: Add an 'overall' entry for accelerators >> MAINTAINERS: Cover the HAX accelerator stub >> Makefile: Remove dangerous EOL trailing backslash >> Makefile: Write MINIKCONF variables as one entry per line >> accel/Kconfig: Extract accel selectors into their own config >> accel/Kconfig: Add the TCG selector >> Makefile: Allow target-specific optional Kconfig >> accel/tcg: Add stub for probe_access() >> >> configure | 19 +++ >> Makefile | 15 +++ >> accel/stubs/tcg-stub.c | 7 +++ >> Kconfig.host | 7 --- >> MAINTAINERS| 14 +- >> accel/Kconfig | 9 + >> 6 files changed, 59 insertions(+), 12 deletions(-) >> create mode 100644 accel/Kconfig >> >
Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig
On 6/18/20 2:33 PM, Philippe Mathieu-Daudé wrote: > Missing review: > - 03/10 MAINTAINERS: Cover the HAX accelerator stub I forgot again to include the HAXM team... > - 04/10 configure: Generate rule to calculate base arch of target > > This series include generic patches I took of the KVM/ARM > specific series which will follow. > > - Update accelerators in MAINTAINERS > - Add accel/Kconfig > - Allow targets to use their how Kconfig > > Since v8: > - Fixed typo in patch 10 (Stefan) > > Since v7: > - Generate base-arch() (Alex) > - Do not deprecate HAXM > > Since v6: > - Fixed typo 'startwith' -> 'startswith' (armbru) > > Since v5: > - Fixed typo in patch #4 subject > - Added David R-b tag > - Stripped --- comments > > Since v4: > - Addressed rth review comments in rules.mak > > Since v3: > - Fixed base-arch() rule (rth) > - Dropped 'semihosting: Make the feature depend of TCG' > > Since v2: > - Addressed Thomas review comments > - Fixed problem when including TARGET instead of BASE_TARGET > > Since v1: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg689024.html > - Drop HVF MAINTAINERS patch (merged elsewhere) > - Kconfig-select SEMIHOSTING (bonzini) > - Drop user-mode selection patches > - consider m68k/nios2/xtensa/riscv (pm215) > - reword Kconfig SEMIHOSTING description (pm215) > - reset some of rth R-b tags > > Previous RFC for semihosting posted earlier: > https://www.mail-archive.com/qemu-devel@nongnu.org/msg631218.html > > Alex Bennée (1): > configure: Generate rule to calculate the base architecture of a > target > > Philippe Mathieu-Daudé (9): > MAINTAINERS: Fix KVM path expansion glob > MAINTAINERS: Add an 'overall' entry for accelerators > MAINTAINERS: Cover the HAX accelerator stub > Makefile: Remove dangerous EOL trailing backslash > Makefile: Write MINIKCONF variables as one entry per line > accel/Kconfig: Extract accel selectors into their own config > accel/Kconfig: Add the TCG selector > Makefile: Allow target-specific optional Kconfig > accel/tcg: Add stub for probe_access() > > configure | 19 +++ > Makefile | 15 +++ > accel/stubs/tcg-stub.c | 7 +++ > Kconfig.host | 7 --- > MAINTAINERS| 14 +- > accel/Kconfig | 9 + > 6 files changed, 59 insertions(+), 12 deletions(-) > create mode 100644 accel/Kconfig >
Re: [PATCH v9 00/10] accel: Allow targets to use Kconfig
Patchew URL: https://patchew.org/QEMU/20200618123342.10693-1-phi...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === CC qga/main.o CC qga/commands-posix.o CC qga/channel-posix.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC qga/qapi-generated/qga-qapi-types.o CC qga/qapi-generated/qga-qapi-visit.o CC qga/qapi-generated/qga-qapi-commands.o --- AR libvhost-user.a GEN docs/interop/qemu-ga-ref.html GEN docs/interop/qemu-ga-ref.txt /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) GEN docs/interop/qemu-ga-ref.7 LINKqemu-ga LINKqemu-keymap LINKivshmem-client /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-server /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-nbd /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-storage-daemon AS pc-bios/optionrom/multiboot.o AS pc-bios/optionrom/linuxboot.o CC pc-bios/optionrom/linuxboot_dma.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-img AS pc-bios/optionrom/kvmvapic.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-io /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) AS pc-bios/optionrom/pvh.o LINKqemu-edid BUILD pc-bios/optionrom/multiboot.img --- BUILD pc-bios/optionrom/kvmvapic.img BUILD pc-bios/optionrom/multiboot.raw BUILD pc-bios/optionrom/linuxboot.raw /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) BUILD pc-bios/optionrom/linuxboot_dma.raw BUILD pc-bios/optionrom/kvmvapic.raw SIGNpc-bios/optionrom/multiboot.bin --- BUILD pc-bios/optionrom/pvh.raw SIGNpc-bios/optionrom/pvh.bin LINKscsi/qemu-pr-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-bridge-helper LINKvirtiofsd /usr/bin/ld:
[PATCH v9 00/10] accel: Allow targets to use Kconfig
Missing review: - 03/10 MAINTAINERS: Cover the HAX accelerator stub - 04/10 configure: Generate rule to calculate base arch of target This series include generic patches I took of the KVM/ARM specific series which will follow. - Update accelerators in MAINTAINERS - Add accel/Kconfig - Allow targets to use their how Kconfig Since v8: - Fixed typo in patch 10 (Stefan) Since v7: - Generate base-arch() (Alex) - Do not deprecate HAXM Since v6: - Fixed typo 'startwith' -> 'startswith' (armbru) Since v5: - Fixed typo in patch #4 subject - Added David R-b tag - Stripped --- comments Since v4: - Addressed rth review comments in rules.mak Since v3: - Fixed base-arch() rule (rth) - Dropped 'semihosting: Make the feature depend of TCG' Since v2: - Addressed Thomas review comments - Fixed problem when including TARGET instead of BASE_TARGET Since v1: https://www.mail-archive.com/qemu-devel@nongnu.org/msg689024.html - Drop HVF MAINTAINERS patch (merged elsewhere) - Kconfig-select SEMIHOSTING (bonzini) - Drop user-mode selection patches - consider m68k/nios2/xtensa/riscv (pm215) - reword Kconfig SEMIHOSTING description (pm215) - reset some of rth R-b tags Previous RFC for semihosting posted earlier: https://www.mail-archive.com/qemu-devel@nongnu.org/msg631218.html Alex Bennée (1): configure: Generate rule to calculate the base architecture of a target Philippe Mathieu-Daudé (9): MAINTAINERS: Fix KVM path expansion glob MAINTAINERS: Add an 'overall' entry for accelerators MAINTAINERS: Cover the HAX accelerator stub Makefile: Remove dangerous EOL trailing backslash Makefile: Write MINIKCONF variables as one entry per line accel/Kconfig: Extract accel selectors into their own config accel/Kconfig: Add the TCG selector Makefile: Allow target-specific optional Kconfig accel/tcg: Add stub for probe_access() configure | 19 +++ Makefile | 15 +++ accel/stubs/tcg-stub.c | 7 +++ Kconfig.host | 7 --- MAINTAINERS| 14 +- accel/Kconfig | 9 + 6 files changed, 59 insertions(+), 12 deletions(-) create mode 100644 accel/Kconfig -- 2.21.3
