Re: [PATCH v9 01/58] include: import Xen public headers to include/standard-headers/
On Mon, 2023-01-30 at 09:41 +0100, Thomas Huth wrote: > > The files in include/standard-headers are created automatically by the > scripts/update-linux-headers.sh script, so I was a little bit surprised that > you don't provide an update to that script first ... if you copy new headers > there manually, that might cause troubles later for the next person who > runs the update-linux-headers.sh script. So I suggest to either adapt the > script for your needs, or put the xen headers in a different location. Thanks; I hadn't clocked that include/standard-headers was in fact just *Linux* headers. I'd previously added the new headers here, done a bunch of header untangling and moving code to use them, and then removed the old ones. It turns out that through some combination of the header cleanups which have already happened in the master branch, various cleanup iterations of this series, and a few more tweaks within the series, I can drop the updated headers directly over the top of the old ones in include/hw/xen/interface. Updated in https://git.infradead.org/users/dwmw2/qemu.git/shortlog/refs/heads/xenfv smime.p7s Description: S/MIME cryptographic signature
Re: [PATCH v9 01/58] include: import Xen public headers to include/standard-headers/
On 28/01/2023 09.10, David Woodhouse wrote: From: Joao Martins There are already some partial headers in include/hw/xen/interface/ which will be removed once we migrate users to the new location. To start with, define __XEN_TOOLS__ in hw/xen/xen.h to ensure that any internal definitions needed by Xen toolstack libraries are present regardless of the order in which the headers are included. A reckoning will come later, once we make the PV backends work in emulation and untangle the headers for Xen-native vs. generic parts. Signed-off-by: Joao Martins [dwmw2: Update to Xen public headers from 4.16.2 release, add some in io/, define __XEN_TOOLS__ in hw/xen/xen.h] Signed-off-by: David Woodhouse Reviewed-by: Paul Durrant --- include/hw/xen/xen.h | 16 +- include/standard-headers/xen/arch-x86/cpuid.h | 118 ++ .../xen/arch-x86/xen-x86_32.h | 194 +++ .../xen/arch-x86/xen-x86_64.h | 241 include/standard-headers/xen/arch-x86/xen.h | 398 ++ include/standard-headers/xen/event_channel.h | 388 ++ include/standard-headers/xen/features.h | 143 +++ include/standard-headers/xen/grant_table.h| 686 ++ include/standard-headers/xen/hvm/hvm_op.h | 395 ++ include/standard-headers/xen/hvm/params.h | 318 + include/standard-headers/xen/io/blkif.h | 722 +++ include/standard-headers/xen/io/console.h | 56 + include/standard-headers/xen/io/fbif.h| 176 +++ include/standard-headers/xen/io/kbdif.h | 576 + include/standard-headers/xen/io/netif.h | 1102 + include/standard-headers/xen/io/protocols.h | 42 + include/standard-headers/xen/io/ring.h| 495 include/standard-headers/xen/io/usbif.h | 425 +++ include/standard-headers/xen/io/xenbus.h | 80 ++ include/standard-headers/xen/io/xs_wire.h | 153 +++ include/standard-headers/xen/memory.h | 754 +++ include/standard-headers/xen/physdev.h| 383 ++ include/standard-headers/xen/sched.h | 202 +++ include/standard-headers/xen/trace.h | 341 + include/standard-headers/xen/vcpu.h | 248 include/standard-headers/xen/version.h| 113 ++ include/standard-headers/xen/xen-compat.h | 46 + include/standard-headers/xen/xen.h| 1049 The files in include/standard-headers are created automatically by the scripts/update-linux-headers.sh script, so I was a little bit surprised that you don't provide an update to that script first ... if you copy new headers there manually, that might cause troubles later for the next person who runs the update-linux-headers.sh script. So I suggest to either adapt the script for your needs, or put the xen headers in a different location. Thomas
