Re: [PULL 0/5] Linux user for 6.0 patches
On Sat, 13 Mar 2021 at 09:50, Laurent Vivier wrote: > > The following changes since commit 3f8d1885e48e4d72eab0688f604de62e0aea7a38: > > Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210311-pull-request'= > into staging (2021-03-12 13:53:44 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request > > for you to fetch changes up to 0266e8e3b3981b492e82be20bb97e8ed9792ed00: > > linux-user/elfload: fix address calculation in fallback scenario (2021-03-1= > 3 10:45:11 +0100) > > > linux-user pull request 20210313 > > - fix elfload > - fix executable page of /proc/self/maps > - add preserve-arg[0] support for binfmt_misc > > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM
Re: [PULL 0/5] Linux user for 6.0 patches
Patchew URL: https://patchew.org/QEMU/20210313094747.2966948-1-laur...@vivier.eu/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20210313094747.2966948-1-laur...@vivier.eu Subject: [PULL 0/5] Linux user for 6.0 patches === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/20210311172459.990281-1-pbonz...@redhat.com -> patchew/20210311172459.990281-1-pbonz...@redhat.com - [tag update] patchew/20210312131921.421023-1-kw...@redhat.com -> patchew/20210312131921.421023-1-kw...@redhat.com * [new tag] patchew/20210313094747.2966948-1-laur...@vivier.eu -> patchew/20210313094747.2966948-1-laur...@vivier.eu Switched to a new branch 'test' 3e3034f linux-user/elfload: fix address calculation in fallback scenario 4a57dfc linux-user/elfload: do not assume MAP_FIXED_NOREPLACE kernel support f1f59a2 linux-user/elfload: munmap proper address in pgd_find_hole_fallback e042e77 linux-user: manage binfmt-misc preserve-arg[0] flag 8a622c5 linux-user: Fix executable page of /proc/self/maps === OUTPUT BEGIN === 1/5 Checking commit 8a622c57ba0b (linux-user: Fix executable page of /proc/self/maps) 2/5 Checking commit e042e77f79f4 (linux-user: manage binfmt-misc preserve-arg[0] flag) ERROR: line over 90 characters #196: FILE: scripts/qemu-binfmt-conf.sh:341: +options=$(getopt -o ds:Q:S:e:hc:p:g: -l debian,systemd:,qemu-path:,qemu-suffix:,exportdir:,help,credential:,persistent:,preserve-argv0: -- "$@") total: 1 errors, 0 warnings, 127 lines checked Patch 2/5 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/5 Checking commit f1f59a2da0c6 (linux-user/elfload: munmap proper address in pgd_find_hole_fallback) 4/5 Checking commit 4a57dfc9849e (linux-user/elfload: do not assume MAP_FIXED_NOREPLACE kernel support) 5/5 Checking commit 3e3034ff2101 (linux-user/elfload: fix address calculation in fallback scenario) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20210313094747.2966948-1-laur...@vivier.eu/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
[PULL 0/5] Linux user for 6.0 patches
The following changes since commit 3f8d1885e48e4d72eab0688f604de62e0aea7a38: Merge remote-tracking branch 'remotes/kraxel/tags/ui-20210311-pull-request'= into staging (2021-03-12 13:53:44 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request for you to fetch changes up to 0266e8e3b3981b492e82be20bb97e8ed9792ed00: linux-user/elfload: fix address calculation in fallback scenario (2021-03-1= 3 10:45:11 +0100) linux-user pull request 20210313 - fix elfload - fix executable page of /proc/self/maps - add preserve-arg[0] support for binfmt_misc Laurent Vivier (1): linux-user: manage binfmt-misc preserve-arg[0] flag Nicolas Surbayrole (1): linux-user: Fix executable page of /proc/self/maps Vincent Fazio (3): linux-user/elfload: munmap proper address in pgd_find_hole_fallback linux-user/elfload: do not assume MAP_FIXED_NOREPLACE kernel support linux-user/elfload: fix address calculation in fallback scenario linux-user/elfload.c| 8 +++ linux-user/main.c | 24 linux-user/syscall.c| 6 ++--- scripts/qemu-binfmt-conf.sh | 44 +++-- 4 files changed, 58 insertions(+), 24 deletions(-) --=20 2.29.2
Re: [PULL 0/5] Linux user for 6.0 patches
On Thu, 21 Jan 2021 at 12:43, Laurent Vivier wrote: > > The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2021011= > 9-1' into staging (2021-01-19 15:47:23 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request > > for you to fetch changes up to b1d2e476e94cb215d9e19fef1049d413b414ffc2: > > linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-21 13:= > 27:34 +0100) > > > linux-user pull request 20210119-v3 > > Remove obsolete F_SHLCK and F_EXLCK translation > Update sockopt > Add F_ADD_SEALS and F_GET_SEALS Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.0 for any user-visible changes. -- PMM
[PULL 0/5] Linux user for 6.0 patches
The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2021011= 9-1' into staging (2021-01-19 15:47:23 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request for you to fetch changes up to b1d2e476e94cb215d9e19fef1049d413b414ffc2: linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-21 13:= 27:34 +0100) linux-user pull request 20210119-v3 Remove obsolete F_SHLCK and F_EXLCK translation Update sockopt Add F_ADD_SEALS and F_GET_SEALS Michael Forney (1): linux-user: Remove obsolete F_SHLCK and F_EXLCK translation Shu-Chun Weng (4): linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls linux-user: add missing UDP get/setsockopt option linux-user: add missing IPv6 get/setsockopt option linux-user: Add IPv6 options to do_print_sockopt() linux-user/alpha/target_fcntl.h | 2 - linux-user/generic/fcntl.h | 5 -- linux-user/strace.c | 154 ++-- linux-user/syscall.c| 23 - linux-user/syscall_defs.h | 14 +-- 5 files changed, 174 insertions(+), 24 deletions(-) --=20 2.29.2
Re: [PULL 0/5] Linux user for 6.0 patches
On 1/21/21 12:38 PM, Philippe Mathieu-Daudé wrote: > On 1/21/21 12:07 PM, Laurent Vivier wrote: >> Le 21/01/2021 à 11:44, Peter Maydell a écrit : >>> On Wed, 20 Jan 2021 at 19:56, Laurent Vivier wrote: The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2021011= 9-1' into staging (2021-01-19 15:47:23 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request for you to fetch changes up to 8a7e49050b8d5477a567b0ec5d764a564481abdb: linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-20 18:= 26:46 +0100) linux-user pull request 20210119-v2 Remove obsolete F_SHLCK and F_EXLCK translation Update sockopt Add F_ADD_SEALS and F_GET_SEALS >>> Now fails with: >>> >>> ../../linux-user/strace.c: In function ‘do_print_sockopt’: >>> ../../linux-user/strace.c:2831:14: error: ‘IPV6_ADDR_PREFERENCES’ >>> undeclared (first use in this function) >>> case IPV6_ADDR_PREFERENCES: I could reproduce building qemu-ppc64 (--target-list=ppc64-linux-user). > I checked on CentOS7 and this part isn't compiled because > TARGET_NR_socketcall is not defined, but I only build the > x86_64-linux-user target there. > >> >> Probably the same cause, in a different file. >> >> This should fix the problem. >> >> diff --git a/linux-user/strace.c b/linux-user/strace.c >> index bc3bb6b2f949..7b43668b9b0e 100644 >> --- a/linux-user/strace.c >> +++ b/linux-user/strace.c >> @@ -11,6 +11,7 @@ >> #include >> #include >> #include >> +#include This build with your fix: Tested-by: Philippe Mathieu-Daudé >> #include >> #include "qemu.h" > > Sounds good. > >> >> I will try to reproduce it before re-sending the PR. >> >> Thanks, >> Laurent >> > >
Re: [PULL 0/5] Linux user for 6.0 patches
On 1/21/21 12:07 PM, Laurent Vivier wrote: > Le 21/01/2021 à 11:44, Peter Maydell a écrit : >> On Wed, 20 Jan 2021 at 19:56, Laurent Vivier wrote: >>> >>> The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: >>> >>> Merge remote-tracking branch >>> 'remotes/pmaydell/tags/pull-target-arm-2021011= >>> 9-1' into staging (2021-01-19 15:47:23 +) >>> >>> are available in the Git repository at: >>> >>> git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request >>> >>> for you to fetch changes up to 8a7e49050b8d5477a567b0ec5d764a564481abdb: >>> >>> linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-20 >>> 18:= >>> 26:46 +0100) >>> >>> >>> linux-user pull request 20210119-v2 >>> >>> Remove obsolete F_SHLCK and F_EXLCK translation >>> Update sockopt >>> Add F_ADD_SEALS and F_GET_SEALS >>> >> Now fails with: >> >> ../../linux-user/strace.c: In function ‘do_print_sockopt’: >> ../../linux-user/strace.c:2831:14: error: ‘IPV6_ADDR_PREFERENCES’ >> undeclared (first use in this function) >> case IPV6_ADDR_PREFERENCES: I checked on CentOS7 and this part isn't compiled because TARGET_NR_socketcall is not defined, but I only build the x86_64-linux-user target there. > > Probably the same cause, in a different file. > > This should fix the problem. > > diff --git a/linux-user/strace.c b/linux-user/strace.c > index bc3bb6b2f949..7b43668b9b0e 100644 > --- a/linux-user/strace.c > +++ b/linux-user/strace.c > @@ -11,6 +11,7 @@ > #include > #include > #include > +#include > #include > #include "qemu.h" Sounds good. > > I will try to reproduce it before re-sending the PR. > > Thanks, > Laurent >
Re: [PULL 0/5] Linux user for 6.0 patches
Le 21/01/2021 à 11:44, Peter Maydell a écrit : > On Wed, 20 Jan 2021 at 19:56, Laurent Vivier wrote: >> >> The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: >> >> Merge remote-tracking branch >> 'remotes/pmaydell/tags/pull-target-arm-2021011= >> 9-1' into staging (2021-01-19 15:47:23 +) >> >> are available in the Git repository at: >> >> git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request >> >> for you to fetch changes up to 8a7e49050b8d5477a567b0ec5d764a564481abdb: >> >> linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-20 >> 18:= >> 26:46 +0100) >> >> >> linux-user pull request 20210119-v2 >> >> Remove obsolete F_SHLCK and F_EXLCK translation >> Update sockopt >> Add F_ADD_SEALS and F_GET_SEALS >> > Now fails with: > > ../../linux-user/strace.c: In function ‘do_print_sockopt’: > ../../linux-user/strace.c:2831:14: error: ‘IPV6_ADDR_PREFERENCES’ > undeclared (first use in this function) > case IPV6_ADDR_PREFERENCES: Probably the same cause, in a different file. This should fix the problem. diff --git a/linux-user/strace.c b/linux-user/strace.c index bc3bb6b2f949..7b43668b9b0e 100644 --- a/linux-user/strace.c +++ b/linux-user/strace.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include "qemu.h" I will try to reproduce it before re-sending the PR. Thanks, Laurent
Re: [PULL 0/5] Linux user for 6.0 patches
On Wed, 20 Jan 2021 at 19:56, Laurent Vivier wrote: > > The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2021011= > 9-1' into staging (2021-01-19 15:47:23 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request > > for you to fetch changes up to 8a7e49050b8d5477a567b0ec5d764a564481abdb: > > linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-20 18:= > 26:46 +0100) > > > linux-user pull request 20210119-v2 > > Remove obsolete F_SHLCK and F_EXLCK translation > Update sockopt > Add F_ADD_SEALS and F_GET_SEALS > Now fails with: ../../linux-user/strace.c: In function ‘do_print_sockopt’: ../../linux-user/strace.c:2831:14: error: ‘IPV6_ADDR_PREFERENCES’ undeclared (first use in this function) case IPV6_ADDR_PREFERENCES: ^ thanks -- PMM
[PULL 0/5] Linux user for 6.0 patches
The following changes since commit 48202c712412c803ddb56365c7bca322aa4e7506: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-2021011= 9-1' into staging (2021-01-19 15:47:23 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request for you to fetch changes up to 8a7e49050b8d5477a567b0ec5d764a564481abdb: linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-20 18:= 26:46 +0100) linux-user pull request 20210119-v2 Remove obsolete F_SHLCK and F_EXLCK translation Update sockopt Add F_ADD_SEALS and F_GET_SEALS Michael Forney (1): linux-user: Remove obsolete F_SHLCK and F_EXLCK translation Shu-Chun Weng (4): linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls linux-user: add missing UDP get/setsockopt option linux-user: add missing IPv6 get/setsockopt option linux-user: Add IPv6 options to do_print_sockopt() linux-user/alpha/target_fcntl.h | 2 - linux-user/generic/fcntl.h | 5 -- linux-user/strace.c | 153 ++-- linux-user/syscall.c| 23 - linux-user/syscall_defs.h | 14 +-- 5 files changed, 173 insertions(+), 24 deletions(-) --=20 2.29.2
Re: [PULL 0/5] Linux user for 6.0 patches
On Tue, 19 Jan 2021 at 18:27, Laurent Vivier wrote: > > The following changes since commit e43d564fa3a0d1e133935c8180ad4f4ccf699f33: > > Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-p= > ull-request' into staging (2021-01-18 15:19:06 +) > > are available in the Git repository at: > > git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request > > for you to fetch changes up to 07e6a3d4e5160955203b82d7ed0d8f523b6b8963: > > linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-19 18:= > 53:58 +0100) > > > linux-user pull request 20210119 > > Remove obsolete F_SHLCK and F_EXLCK translation > Update sockopt > Add F_ADD_SEALS and F_GET_SEALS Hi; this fails to compile on the ppc64 box; looks like the usual "its system includes happen to be a bit elderly" reason: ../../linux-user/syscall.c: In function ‘do_setsockopt’: ../../linux-user/syscall.c:2276:14: error: ‘IPV6_ADDR_PREFERENCES’ undeclared (first use in this function) case IPV6_ADDR_PREFERENCES: ^ ../../linux-user/syscall.c:2276:14: note: each undeclared identifier is reported only once for each function it appears in ../../linux-user/syscall.c: In function ‘do_getsockopt’: ../../linux-user/syscall.c:2931:14: error: ‘IPV6_ADDR_PREFERENCES’ undeclared (first use in this function) case IPV6_ADDR_PREFERENCES: ^ (Maybe we should think about some mechanism for getting constant values from a local copy of the kernel headers by extending the linux-headers scheme? It would let us cut down on the ifdeffery...) thanks -- PMM
[PULL 0/5] Linux user for 6.0 patches
The following changes since commit e43d564fa3a0d1e133935c8180ad4f4ccf699f33: Merge remote-tracking branch 'remotes/vivier2/tags/trivial-branch-for-6.0-p= ull-request' into staging (2021-01-18 15:19:06 +) are available in the Git repository at: git://github.com/vivier/qemu.git tags/linux-user-for-6.0-pull-request for you to fetch changes up to 07e6a3d4e5160955203b82d7ed0d8f523b6b8963: linux-user: Remove obsolete F_SHLCK and F_EXLCK translation (2021-01-19 18:= 53:58 +0100) linux-user pull request 20210119 Remove obsolete F_SHLCK and F_EXLCK translation Update sockopt Add F_ADD_SEALS and F_GET_SEALS Michael Forney (1): linux-user: Remove obsolete F_SHLCK and F_EXLCK translation Shu-Chun Weng (4): linux-user: Support F_ADD_SEALS and F_GET_SEALS fcntls linux-user: add missing UDP get/setsockopt option linux-user: add missing IPv6 get/setsockopt option linux-user: Add IPv6 options to do_print_sockopt() linux-user/alpha/target_fcntl.h | 2 - linux-user/generic/fcntl.h | 5 -- linux-user/strace.c | 153 ++-- linux-user/syscall.c| 22 - linux-user/syscall_defs.h | 14 +-- 5 files changed, 172 insertions(+), 24 deletions(-) --=20 2.29.2
