Re: [PULL 0/6] Linux user for 5.0 patches

2020-03-26 Thread Peter Maydell
On Thu, 26 Mar 2020 at 16:43, Laurent Vivier  wrote:
>
> Le 26/03/2020 à 16:42, Peter Maydell a écrit :
> > On Thu, 26 Mar 2020 at 07:24, Laurent Vivier  wrote:
> >>
> >> The following changes since commit 
> >> 736cf607e40674776d752acc201f565723e86045:
> >>
> >>   Update version for v5.0.0-rc0 release (2020-03-24 17:50:00 +)
> >>
> >> are available in the Git repository at:
> >>
> >>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
> >>
> >> for you to fetch changes up to a52f5f87bece827a338d6eb3332e3def86fb9c33:
> >>
> >>   linux-user: Flush out implementation of gettimeofday (2020-03-26 
> >> 08:08:54 +0100)
> >>
> >> 
> >> Emulate x86_64 vsyscalls
> >> Fix syscall_nr.h cleanup
> >>
> >> 
> >
> > Still fails :-(
>
> I would say it was expected...
>
> I think your build dir is corrupted by a previous build.
>
> You should have old .o file without .d file, and thus the .o file is not
> refreshed (check the date of cpu_loop.o). We cannot cleanup that before
> starting the build. The purpose of the cleanup in configure was to avoid
> this kind of problem but I did it badly.
>
> If you want to check incremental build, cleanup your build dir, checkout
> v4.20 or master, build it, and then build the PR branch. it will work:
> it's tested.

Seems like it. I blew away and recreated the build tree, did a build
with master, and then applied this pullreq with my usual process
(so incremental build from there), and it was fine.

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.0
for any user-visible changes.

-- PMM



Re: [PULL 0/6] Linux user for 5.0 patches

2020-03-26 Thread Laurent Vivier
Le 26/03/2020 à 16:42, Peter Maydell a écrit :
> On Thu, 26 Mar 2020 at 07:24, Laurent Vivier  wrote:
>>
>> The following changes since commit 736cf607e40674776d752acc201f565723e86045:
>>
>>   Update version for v5.0.0-rc0 release (2020-03-24 17:50:00 +)
>>
>> are available in the Git repository at:
>>
>>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>>
>> for you to fetch changes up to a52f5f87bece827a338d6eb3332e3def86fb9c33:
>>
>>   linux-user: Flush out implementation of gettimeofday (2020-03-26 08:08:54 
>> +0100)
>>
>> 
>> Emulate x86_64 vsyscalls
>> Fix syscall_nr.h cleanup
>>
>> 
> 
> Still fails :-(

I would say it was expected...

I think your build dir is corrupted by a previous build.

You should have old .o file without .d file, and thus the .o file is not
refreshed (check the date of cpu_loop.o). We cannot cleanup that before
starting the build. The purpose of the cleanup in configure was to avoid
this kind of problem but I did it badly.

If you want to check incremental build, cleanup your build dir, checkout
v4.20 or master, build it, and then build the PR branch. it will work:
it's tested.

If you build 4.2.0, then master and then PR, the build dir will be
corrupted by the build of master that removes the .d files without
removing the .o files. So when you build the PR, cpu_loop.o  file
remains and is not rebuild with the new values in cpu.h.

We can't do anything to avoid that now, except removing all .o files
under *-linux-user...

Sorry for the mess...

Thanks,
Laurent





Re: [PULL 0/6] Linux user for 5.0 patches

2020-03-26 Thread Peter Maydell
On Thu, 26 Mar 2020 at 07:24, Laurent Vivier  wrote:
>
> The following changes since commit 736cf607e40674776d752acc201f565723e86045:
>
>   Update version for v5.0.0-rc0 release (2020-03-24 17:50:00 +)
>
> are available in the Git repository at:
>
>   git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request
>
> for you to fetch changes up to a52f5f87bece827a338d6eb3332e3def86fb9c33:
>
>   linux-user: Flush out implementation of gettimeofday (2020-03-26 08:08:54 
> +0100)
>
> 
> Emulate x86_64 vsyscalls
> Fix syscall_nr.h cleanup
>
> 

Still fails :-(

/home/petmay01/linaro/qemu-for-merges/build/all-linux-static/x86_64-linux-user/qemu-x86_64
-L ./gnemul/qemu-x86_64 x86_64/ls -l dummyfile
qemu: 0x40008117e9: unhandled CPU exception 0x101 - aborting
RAX=003f RBX=6e34 RCX=004000800b18
RDX=004000813180
RSI=0064 RDI=004000800670 RBP=6f40
RSP=004000800668
R8 = R9 =004000800b44 R10=004000801a18
R11=004000801260
R12=0040008008c0 R13=0008 R14=00400040
R15=0040008032d0
RIP=0040008117e9 RFL=0246 [---Z-P-] CPL=3 II=0 A20=1 SMM=0 HLT=0
ES =   
CS =0033   00effb00 DPL=3 CS64 [-RA]
SS =002b   00cff300 DPL=3 DS   [-WA]
DS =   
FS =   
GS =   
LDT=   8200 DPL=0 LDT
TR =   8b00 DPL=0 TSS64-busy
GDT= 00400091a000 007f
IDT= 004000919000 01ff
CR0=80010001 CR2= CR3= CR4=0220
DR0= DR1= DR2=
DR3=
DR6=0ff0 DR7=0400
EFER=0500
Makefile:6: recipe for target 'test' failed

thanks
-- PMM



[PULL 0/6] Linux user for 5.0 patches

2020-03-26 Thread Laurent Vivier
The following changes since commit 736cf607e40674776d752acc201f565723e86045:

  Update version for v5.0.0-rc0 release (2020-03-24 17:50:00 +)

are available in the Git repository at:

  git://github.com/vivier/qemu.git tags/linux-user-for-5.0-pull-request

for you to fetch changes up to a52f5f87bece827a338d6eb3332e3def86fb9c33:

  linux-user: Flush out implementation of gettimeofday (2020-03-26 08:08:54 
+0100)


Emulate x86_64 vsyscalls
Fix syscall_nr.h cleanup



Laurent Vivier (1):
  linux-user, configure: fix (again) syscall_nr.h dependencies cleanup

Richard Henderson (5):
  target/i386: Renumber EXCP_SYSCALL
  linux-user/i386: Split out gen_signal
  linux-user/i386: Emulate x86_64 vsyscalls
  linux-user: Add x86_64 vsyscall page to /proc/self/maps
  linux-user: Flush out implementation of gettimeofday

 configure  |   8 +-
 linux-user/i386/cpu_loop.c | 201 ++---
 linux-user/syscall.c   |  39 ++-
 target/i386/cpu.h  |  12 ++-
 target/i386/translate.c|  14 ++-
 5 files changed, 205 insertions(+), 69 deletions(-)

-- 
2.25.1