Re: [PULL 0/7] Audio 20200619 patches
On Fri, 19 Jun 2020 at 14:19, Gerd Hoffmann wrote: > > The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: > > Merge remote-tracking branch > 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging > (2020-06-16 14:57:15 +0100) > > are available in the Git repository at: > > git://git.kraxel.org/qemu tags/audio-20200619-pull-request > > for you to fetch changes up to 586803455b3fa44d949ecd42cd9c87e5a6287aef: > > hw/audio/gus: Fix registers 32-bit access (2020-06-19 11:20:09 +0200) > > > audio: bugfixes for jack backend and gus emulation. Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
Re: [PULL 0/7] Audio 20200619 patches
Patchew URL: https://patchew.org/QEMU/20200619131741.10857-1-kra...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === AR libqemuutil.a LINKelf2dmp CC qemu-img.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) AR libvhost-user.a /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) GEN docs/interop/qemu-ga-ref.html GEN docs/interop/qemu-ga-ref.7 GEN docs/interop/qemu-ga-ref.txt --- SIGNpc-bios/optionrom/multiboot.bin LINKqemu-ga LINKqemu-keymap /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-client /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-server /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-nbd /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-storage-daemon /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-img LINKqemu-io /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-edid /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKfsdev/virtfs-proxy-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKscsi/qemu-pr-helper LINKqemu-bridge-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKvirtiofsd /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKvhost-user-input /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from
Re: [PULL 0/7] Audio 20200619 patches
Patchew URL: https://patchew.org/QEMU/20200619131741.10857-1-kra...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 0/7] Audio 20200619 patches
Type: series
Message-id: 20200619131741.10857-1-kra...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20200619123331.17387-1-filip.boz...@syrmia.com ->
patchew/20200619123331.17387-1-filip.boz...@syrmia.com
Switched to a new branch 'test'
426e843 hw/audio/gus: Fix registers 32-bit access
ffad943 audio/jack: simplify the re-init code path
8ec48ef audio/jack: honour the enable state of the audio device
f4073f5 audio/jack: do not remove ports when finishing
fc314a6 audio/jack: remove invalid set of input support bool
69c5f3f audio/jack: remove unused stopped state
f6586ef audio/jack: fix invalid minimum buffer size check
=== OUTPUT BEGIN ===
1/7 Checking commit f6586ef90b7e (audio/jack: fix invalid minimum buffer size
check)
2/7 Checking commit 69c5f3fe0a17 (audio/jack: remove unused stopped state)
3/7 Checking commit fc314a6b8aa3 (audio/jack: remove invalid set of input
support bool)
4/7 Checking commit f4073f5cb054 (audio/jack: do not remove ports when
finishing)
5/7 Checking commit 8ec48efb1b21 (audio/jack: honour the enable state of the
audio device)
ERROR: space required before the open parenthesis '('
#44: FILE: audio/jackaudio.c:277:
+for(int i = 0; i < c->nchannels; ++i) {
total: 1 errors, 0 warnings, 91 lines checked
Patch 5/7 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/7 Checking commit ffad943bccbc (audio/jack: simplify the re-init code path)
7/7 Checking commit 426e843e768c (hw/audio/gus: Fix registers 32-bit access)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20200619131741.10857-1-kra...@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
[PULL 0/7] Audio 20200619 patches
The following changes since commit 5c24bce3056ff209a1ecc50ff4b7e65b85ad8e74: Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-and-plugin-160620-2' into staging (2020-06-16 14:57:15 +0100) are available in the Git repository at: git://git.kraxel.org/qemu tags/audio-20200619-pull-request for you to fetch changes up to 586803455b3fa44d949ecd42cd9c87e5a6287aef: hw/audio/gus: Fix registers 32-bit access (2020-06-19 11:20:09 +0200) audio: bugfixes for jack backend and gus emulation. Allan Peramaki (1): hw/audio/gus: Fix registers 32-bit access Geoffrey McRae (6): audio/jack: fix invalid minimum buffer size check audio/jack: remove unused stopped state audio/jack: remove invalid set of input support bool audio/jack: do not remove ports when finishing audio/jack: honour the enable state of the audio device audio/jack: simplify the re-init code path audio/jackaudio.c | 73 + hw/audio/gusemu_hal.c | 2 +- hw/audio/gusemu_mixer.c | 2 +- 3 files changed, 40 insertions(+), 37 deletions(-) -- 2.18.4
