Re: [PULL V2 00/33] Net patches
On Fri, 19 Jun 2020 at 04:19, Jason Wang wrote: > > > On 2020/6/18 下午10:05, no-re...@patchew.org wrote: > > /tmp/qemu-test/src/tests/qht-bench.c:287:29: error: implicit conversion > > from 'unsigned long' to 'double' changes value from 18446744073709551615 to > > 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] > > *threshold = rate * UINT64_MAX; > >~ ^~ > > /usr/include/stdint.h:130:23: note: expanded from macro 'UINT64_MAX' > > --- > > 18446744073709551615UL > > ^~ > > > Cc Emilio. > > This looks an issue not related to this pull request. Yes; it's caused by an upgrade of the compiler version on the system/container that runs this asan test build for patchew. This proposed patch would silence the complaint: https://patchew.org/QEMU/20200617201309.1640952-1-richard.hender...@linaro.org/20200617201309.1640952-7-richard.hender...@linaro.org/ but it is waiting for review and/or discussion of what the right actual fix to the code would be. thanks -- PMM
Re: [PULL V2 00/33] Net patches
On Thu, 18 Jun 2020 at 14:21, Jason Wang wrote: > > The following changes since commit 3f429a3400822141651486193d6af625eeab05a5: > > Merge remote-tracking branch > 'remotes/kraxel/tags/microvm-20200617-pull-request' into staging (2020-06-18 > 11:23:15 +0100) > > are available in the git repository at: > > https://github.com/jasowang/qemu.git tags/net-pull-request > > for you to fetch changes up to 71830d8430e65dd20aec4765d87e60336148e1a6: > > net: Drop the NetLegacy structure, always use Netdev instead (2020-06-18 > 21:05:52 +0800) > > > > Changes from V1: > - Fix build failure for virtio-net Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1 for any user-visible changes. -- PMM
Re: [PULL V2 00/33] Net patches
On 2020/6/18 下午10:05, no-re...@patchew.org wrote: /tmp/qemu-test/src/tests/qht-bench.c:287:29: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709551615 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] *threshold = rate * UINT64_MAX; ~ ^~ /usr/include/stdint.h:130:23: note: expanded from macro 'UINT64_MAX' --- 18446744073709551615UL ^~ Cc Emilio. This looks an issue not related to this pull request. Thanks
Re: [PULL V2 00/33] Net patches
Patchew URL: https://patchew.org/QEMU/1592486508-6135-1-git-send-email-jasow...@redhat.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash export ARCH=x86_64 make docker-image-fedora V=1 NETWORK=1 time make docker-test-debug@fedora TARGET_LIST=x86_64-softmmu J=14 NETWORK=1 === TEST SCRIPT END === GEN docs/interop/qemu-qmp-ref.7 CC qga/commands.o CC qga/guest-agent-command-state.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC qga/main.o CC qga/commands-posix.o CC qga/channel-posix.o --- AR libvhost-user.a GEN docs/interop/qemu-ga-ref.html GEN docs/interop/qemu-ga-ref.txt /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) GEN docs/interop/qemu-ga-ref.7 LINKqemu-keymap /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKivshmem-client LINKivshmem-server AS pc-bios/optionrom/multiboot.o AS pc-bios/optionrom/linuxboot.o /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) CC pc-bios/optionrom/linuxboot_dma.o AS pc-bios/optionrom/kvmvapic.o LINKqemu-nbd AS pc-bios/optionrom/pvh.o CC pc-bios/optionrom/pvh_main.o BUILD pc-bios/optionrom/multiboot.img /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) BUILD pc-bios/optionrom/linuxboot.img BUILD pc-bios/optionrom/linuxboot_dma.img LINKqemu-storage-daemon --- BUILD pc-bios/optionrom/kvmvapic.raw SIGNpc-bios/optionrom/multiboot.bin SIGNpc-bios/optionrom/linuxboot.bin /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) SIGNpc-bios/optionrom/linuxboot_dma.bin SIGNpc-bios/optionrom/kvmvapic.bin LINKqemu-img --- BUILD pc-bios/optionrom/pvh.raw SIGNpc-bios/optionrom/pvh.bin LINKqemu-io /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKqemu-edid /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKfsdev/virtfs-proxy-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKscsi/qemu-pr-helper LINKqemu-bridge-helper /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) /usr/bin/ld: /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors_vfork.S.o): warning: common of `__interception::real_vfork' overridden by definition from /usr/lib64/clang/10.0.0/lib/linux/libclang_rt.asan-x86_64.a(asan_interceptors.cpp.o) LINKvirtiofsd /usr/bin/ld:
[PULL V2 00/33] Net patches
The following changes since commit 3f429a3400822141651486193d6af625eeab05a5: Merge remote-tracking branch 'remotes/kraxel/tags/microvm-20200617-pull-request' into staging (2020-06-18 11:23:15 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to fetch changes up to 71830d8430e65dd20aec4765d87e60336148e1a6: net: Drop the NetLegacy structure, always use Netdev instead (2020-06-18 21:05:52 +0800) Changes from V1: - Fix build failure for virtio-net Derek Su (1): colo-compare: Fix memory leak in packet_enqueue() Helge Deller (1): Fix tulip breakage Jason Wang (1): net: use peer when purging queue in qemu_flush_or_purge_queue_packets() Lukas Straub (6): net/colo-compare.c: Create event_bh with the right AioContext chardev/char.c: Use qemu_co_sleep_ns if in coroutine net/colo-compare.c: Fix deadlock in compare_chr_send net/colo-compare.c: Only hexdump packets if tracing is enabled net/colo-compare.c: Check that colo-compare is active net/colo-compare.c: Correct ordering in complete and finalize Philippe Mathieu-Daudé (3): hw/net/tulip: Fix 'Descriptor Error' definition hw/net/tulip: Log descriptor overflows hw/net/e1000e: Do not abort() on invalid PSRCTL register value Sai Pavan Boddu (11): net: cadence_gem: Fix debug statements net: cadence_gem: Fix the queue address update during wrap around net: cadence_gem: Fix irq update w.r.t queue net: cadence_gem: Define access permission for interrupt registers net: cadence_gem: Set ISR according to queue in use net: cadence_gem: Move tx/rx packet buffert to CadenceGEMState net: cadence_gem: Fix up code style net: cadence_gem: Add support for jumbo frames net: cadnece_gem: Update irq_read_clear field of designcfg_debug1 reg net: cadence_gem: Update the reset value for interrupt mask register net: cadence_gem: TX_LAST bit should be set by guest Thomas Huth (2): net: Drop the legacy "name" parameter from the -net option net: Drop the NetLegacy structure, always use Netdev instead Tong Ho (1): net: cadence_gem: Fix RX address filtering Yuri Benditovich (7): virtio-net: implement RSS configuration command virtio-net: implement RX RSS processing tap: allow extended virtio header with hash info virtio-net: reference implementation of hash report vmstate.h: provide VMSTATE_VARRAY_UINT16_ALLOC macro virtio-net: add migration support for RSS and hash report virtio-net: align RSC fields with updated virtio-net header chardev/char.c | 7 +- docs/system/deprecated.rst | 15 +- hw/net/Makefile.objs | 1 + hw/net/cadence_gem.c | 458 +++-- hw/net/e1000e_core.c | 10 +- hw/net/trace-events| 3 + hw/net/tulip.c | 12 +- hw/net/tulip.h | 2 +- hw/net/virtio-net.c| 387 ++ include/hw/net/cadence_gem.h | 6 + include/hw/virtio/virtio-net.h | 16 ++ include/migration/vmstate.h| 10 + net/colo-compare.c | 277 ++--- net/colo.c | 7 + net/colo.h | 1 + net/net.c | 89 ++-- net/tap.c | 3 +- net/trace-events | 1 + qapi/net.json | 49 - 19 files changed, 905 insertions(+), 449 deletions(-)
