Re: [PULL v2 00/11] Misc patches for 2023-02-08
On 09/02/2023 16.17, Peter Maydell wrote:
On Thu, 9 Feb 2023 at 09:36, Paolo Bonzini wrote:
The following changes since commit ae2b5d8381a73b27f35f19c988d45c78bb4d5768:
Merge tag 'pull-include-2023-02-06-v2' of https://repo.or.cz/qemu/armbru
into staging (2023-02-08 10:40:06 +)
are available in the Git repository at:
https://gitlab.com/bonzini/qemu.git tags/for-upstream
for you to fetch changes up to 92f5d4606bedf0e2af0169a32aff9443084c5d0a:
target/i386: fix ADOX followed by ADCX (2023-02-09 10:17:34 +0100)
* block/iscsi: fix double-free on BUSY or similar statuses
* catch [accel] entry without accelerator
* target/i386: various fixes for BMI and ADX instructions
* make the contents of meson-buildoptions.sh stable
This seems to consistently fail on the BSD jobs:
https://gitlab.com/qemu-project/qemu/-/jobs/3742560167
https://gitlab.com/qemu-project/qemu/-/jobs/3742560168
https://gitlab.com/qemu-project/qemu/-/jobs/3743330014
https://gitlab.com/qemu-project/qemu/-/jobs/3743330018
https://gitlab.com/qemu-project/qemu/-/jobs/3743909430
Unfortunately the logs don't seem very informative :-(
Out of curiosity, I added some debug printfs and ran the test a couple of
more times in the CI. It's pretty weird... There are two problems in
qtest_wait_qemu() :
1) In these FreeBSD runners, that "do { waitpid(..., WNOHANG) } while" loop
does not finish in time, so the code sends a SIGKILL signal to the QEMU
process. This then causes qtest_check_status() to abort() later since QEMU
finished with a bad status. Should we handle this more gracefully so that
the code does not abort() after the SIGKILL?
2) By increasing WAITPID_TIMEOUT to more than 75 seconds, I can make the
test succeed. It's really weird, but it seems like the do-while loop always
takes 75 seconds to succeed in case of the "invalid-accel" test - but I've
got no clue where that delay could come from... Any ideas?
Thomas
Re: [PULL v2 00/11] Misc patches for 2023-02-08
On Thu, 9 Feb 2023 at 09:36, Paolo Bonzini wrote: > > The following changes since commit ae2b5d8381a73b27f35f19c988d45c78bb4d5768: > > Merge tag 'pull-include-2023-02-06-v2' of https://repo.or.cz/qemu/armbru > into staging (2023-02-08 10:40:06 +) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 92f5d4606bedf0e2af0169a32aff9443084c5d0a: > > target/i386: fix ADOX followed by ADCX (2023-02-09 10:17:34 +0100) > > > * block/iscsi: fix double-free on BUSY or similar statuses > * catch [accel] entry without accelerator > * target/i386: various fixes for BMI and ADX instructions > * make the contents of meson-buildoptions.sh stable > > This seems to consistently fail on the BSD jobs: https://gitlab.com/qemu-project/qemu/-/jobs/3742560167 https://gitlab.com/qemu-project/qemu/-/jobs/3742560168 https://gitlab.com/qemu-project/qemu/-/jobs/3743330014 https://gitlab.com/qemu-project/qemu/-/jobs/3743330018 https://gitlab.com/qemu-project/qemu/-/jobs/3743909430 Unfortunately the logs don't seem very informative :-( -- PMM
[PULL v2 00/11] Misc patches for 2023-02-08
The following changes since commit ae2b5d8381a73b27f35f19c988d45c78bb4d5768: Merge tag 'pull-include-2023-02-06-v2' of https://repo.or.cz/qemu/armbru into staging (2023-02-08 10:40:06 +) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 92f5d4606bedf0e2af0169a32aff9443084c5d0a: target/i386: fix ADOX followed by ADCX (2023-02-09 10:17:34 +0100) * block/iscsi: fix double-free on BUSY or similar statuses * catch [accel] entry without accelerator * target/i386: various fixes for BMI and ADX instructions * make the contents of meson-buildoptions.sh stable * Include review comments from Thomas and Philippe * Fix year in subject :) Paolo Bonzini (8): build: make meson-buildoptions.sh stable remove unnecessary extern "C" blocks block/iscsi: fix double-free on BUSY or similar statuses vl: catch [accel] entry without accelerator libqtest: split qtest_spawn_qemu function libqtest: ensure waitpid() is only called once readconfig-test: add test for accelerator configuration target/i386: fix ADOX followed by ADCX Richard Henderson (3): tests/tcg/i386: Introduce and use reg_t consistently target/i386: Fix BEXTR instruction target/i386: Fix C flag for BLSI, BLSMSK, BLSR block/iscsi.c| 1 + include/disas/dis-asm.h | 8 -- include/qemu/bswap.h | 8 -- include/qemu/envlist.h | 8 -- include/qemu/rcu.h | 8 -- include/qemu/rcu_queue.h | 8 -- include/qemu/uri.h | 7 -- scripts/meson-buildoptions.py| 7 +- scripts/meson-buildoptions.sh| 2 +- softmmu/vl.c | 15 ++- target/i386/tcg/emit.c.inc | 45 + tests/qtest/libqtest.c | 186 ++--- tests/qtest/libqtest.h | 12 +++ tests/qtest/readconfig-test.c| 45 +++-- tests/tcg/i386/Makefile.target | 6 +- tests/tcg/i386/test-i386-adcox.c | 75 +++ tests/tcg/i386/test-i386-bmi2.c | 194 +-- 17 files changed, 386 insertions(+), 249 deletions(-) create mode 100644 tests/tcg/i386/test-i386-adcox.c -- 2.39.1
Re: [PULL v2 00/11] Misc patches
On 5/9/22 02:29, Thomas Huth wrote: The following changes since commit 554623226f800acf48a2ed568900c1c968ec9a8b: Merge tag 'qemu-sparc-20220508' of https://github.com/mcayland/qemu into staging (2022-05-08 17:03:26 -0500) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-05-09 for you to fetch changes up to ddc5a6cc70398ed7ec76220d59c123d8cb14b0ad: docs/devel/writing-monitor-commands: Replace obsolete STEXI/ETEXI tags (2022-05-09 08:21:14 +0200) * Remove redundant/obsolete x86, arm and ppc disassemblers (Capstone is better) * Limit some Xen-related code to builds where Xen is really available * Remove hxtool-conv.pl and remove STEXI/ETEXI references from the docs * Update MinGW and OpenBSD to a more recent version in the CI * Warn user if the -vga flag is passed but no vga device is created Applied, thanks. Please update https://wiki.qemu.org/ChangeLog/7.1 as appropriate. r~ v2: - Fixed the -vga warning patch to not warn in case of "-device" - Added the ppc disassembler patch - Added the STEXI/ETEXI doc patch Brad Smith (1): tests/vm: update openbsd to release 7.1 Gautam Agrawal (1): Warn user if the vga flag is passed but no vga device is created Thomas Huth (6): disas: Remove old libopcode arm disassembler disas: Remove old libopcode i386 disassembler disas: Remove old libopcode ppc disassembler softmmu/vl: Fence 'xenfb' if Xen support is not compiled in qemu-options: Limit the -xen options to x86 and arm docs/devel/writing-monitor-commands: Replace obsolete STEXI/ETEXI tags Yonggang Luo (3): doc: remove hxtool-conv.pl cirrus/win32: upgrade mingw base packages gitlab-ci: Upgrade mingw base package. docs/devel/writing-monitor-commands.rst | 11 +- include/disas/dis-asm.h |3 - include/sysemu/sysemu.h |1 + disas.c |5 - disas/arm.c | 4012 -- disas/i386.c| 6771 --- disas/ppc.c | 5435 - hw/hppa/machine.c |1 + hw/isa/isa-bus.c|1 + hw/mips/fuloong2e.c |1 + hw/pci/pci.c|1 + hw/ppc/spapr.c |1 + hw/sparc/sun4m.c|2 + hw/sparc64/sun4u.c |1 + hw/xenpv/xen_machine_pv.c |1 + softmmu/globals.c |1 + softmmu/vl.c|9 + target/arm/cpu.c|8 - target/i386/cpu.c |1 - target/ppc/cpu_init.c |2 - .cirrus.yml |2 +- .gitlab-ci.d/windows.yml|2 +- MAINTAINERS |6 - disas/meson.build |3 - qemu-options.hx |7 +- scripts/hxtool-conv.pl | 137 - tests/vm/openbsd|4 +- 27 files changed, 32 insertions(+), 16397 deletions(-) delete mode 100644 disas/arm.c delete mode 100644 disas/i386.c delete mode 100644 disas/ppc.c delete mode 100755 scripts/hxtool-conv.pl
[PULL v2 00/11] Misc patches
The following changes since commit 554623226f800acf48a2ed568900c1c968ec9a8b: Merge tag 'qemu-sparc-20220508' of https://github.com/mcayland/qemu into staging (2022-05-08 17:03:26 -0500) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2022-05-09 for you to fetch changes up to ddc5a6cc70398ed7ec76220d59c123d8cb14b0ad: docs/devel/writing-monitor-commands: Replace obsolete STEXI/ETEXI tags (2022-05-09 08:21:14 +0200) * Remove redundant/obsolete x86, arm and ppc disassemblers (Capstone is better) * Limit some Xen-related code to builds where Xen is really available * Remove hxtool-conv.pl and remove STEXI/ETEXI references from the docs * Update MinGW and OpenBSD to a more recent version in the CI * Warn user if the -vga flag is passed but no vga device is created v2: - Fixed the -vga warning patch to not warn in case of "-device" - Added the ppc disassembler patch - Added the STEXI/ETEXI doc patch Brad Smith (1): tests/vm: update openbsd to release 7.1 Gautam Agrawal (1): Warn user if the vga flag is passed but no vga device is created Thomas Huth (6): disas: Remove old libopcode arm disassembler disas: Remove old libopcode i386 disassembler disas: Remove old libopcode ppc disassembler softmmu/vl: Fence 'xenfb' if Xen support is not compiled in qemu-options: Limit the -xen options to x86 and arm docs/devel/writing-monitor-commands: Replace obsolete STEXI/ETEXI tags Yonggang Luo (3): doc: remove hxtool-conv.pl cirrus/win32: upgrade mingw base packages gitlab-ci: Upgrade mingw base package. docs/devel/writing-monitor-commands.rst | 11 +- include/disas/dis-asm.h |3 - include/sysemu/sysemu.h |1 + disas.c |5 - disas/arm.c | 4012 -- disas/i386.c| 6771 --- disas/ppc.c | 5435 - hw/hppa/machine.c |1 + hw/isa/isa-bus.c|1 + hw/mips/fuloong2e.c |1 + hw/pci/pci.c|1 + hw/ppc/spapr.c |1 + hw/sparc/sun4m.c|2 + hw/sparc64/sun4u.c |1 + hw/xenpv/xen_machine_pv.c |1 + softmmu/globals.c |1 + softmmu/vl.c|9 + target/arm/cpu.c|8 - target/i386/cpu.c |1 - target/ppc/cpu_init.c |2 - .cirrus.yml |2 +- .gitlab-ci.d/windows.yml|2 +- MAINTAINERS |6 - disas/meson.build |3 - qemu-options.hx |7 +- scripts/hxtool-conv.pl | 137 - tests/vm/openbsd|4 +- 27 files changed, 32 insertions(+), 16397 deletions(-) delete mode 100644 disas/arm.c delete mode 100644 disas/i386.c delete mode 100644 disas/ppc.c delete mode 100755 scripts/hxtool-conv.pl
Re: [PULL v2 00/11] Misc patches for 2021-04-30 (incl. NVMM accelerator)
On Tue, 4 May 2021 at 14:33, Paolo Bonzini wrote: > > The following changes since commit e93d8bcf9dbd5b8dd3b9ddbb1ece6a37e608f300: > > Merge remote-tracking branch 'remotes/philmd/tags/mips-20210502' into > staging (2021-05-03 12:05:12 +0100) > > are available in the Git repository at: > > https://gitlab.com/bonzini/qemu.git tags/for-upstream > > for you to fetch changes up to 9ba5db49aea924175b8f23edd388fa2452206d20: > > glib-compat: accept G_TEST_SLOW environment variable (2021-05-04 14:15:35 > +0200) > > v1->v2: check for new-enough NetBSD, add another 0.57 preparation patch > > > * NetBSD NVMM support > * RateLimit mutex > * Prepare for Meson 0.57 upgrade > Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/6.1 for any user-visible changes. -- PMM
[PULL v2 00/11] Misc patches for 2021-04-30 (incl. NVMM accelerator)
The following changes since commit e93d8bcf9dbd5b8dd3b9ddbb1ece6a37e608f300: Merge remote-tracking branch 'remotes/philmd/tags/mips-20210502' into staging (2021-05-03 12:05:12 +0100) are available in the Git repository at: https://gitlab.com/bonzini/qemu.git tags/for-upstream for you to fetch changes up to 9ba5db49aea924175b8f23edd388fa2452206d20: glib-compat: accept G_TEST_SLOW environment variable (2021-05-04 14:15:35 +0200) v1->v2: check for new-enough NetBSD, add another 0.57 preparation patch * NetBSD NVMM support * RateLimit mutex * Prepare for Meson 0.57 upgrade Joelle van Dyne (1): slirp: add configure option to disable smbd Paolo Bonzini (6): oslib-win32: do not rely on macro to get redefined function name ratelimit: protect with a mutex configure: reindent meson invocation configure: handle meson options that have changed type gitlab-ci: use --meson=internal for CFI jobs glib-compat: accept G_TEST_SLOW environment variable Reinoud Zandijk (4): Add NVMM accelerator: configure and build logic Add NVMM accelerator: x86 CPU support Add NVMM accelerator: acceleration enlightenments Add NVMM Accelerator: add maintainers for NetBSD/NVMM .gitlab-ci.yml| 10 +- MAINTAINERS | 11 + accel/Kconfig |3 + block/block-copy.c|2 + blockjob.c|3 + configure | 119 ++-- include/glib-compat.h | 17 + include/qemu/ratelimit.h | 14 + include/sysemu/hw_accel.h |1 + include/sysemu/nvmm.h | 26 + meson.build | 16 +- meson_options.txt |2 + net/slirp.c | 16 +- qemu-options.hx |8 +- target/i386/helper.c |2 +- target/i386/meson.build |1 + target/i386/nvmm/meson.build |8 + target/i386/nvmm/nvmm-accel-ops.c | 111 target/i386/nvmm/nvmm-accel-ops.h | 24 + target/i386/nvmm/nvmm-all.c | 1226 + util/oslib-win32.c|2 +- 21 files changed, 1562 insertions(+), 60 deletions(-) create mode 100644 include/sysemu/nvmm.h create mode 100644 target/i386/nvmm/meson.build create mode 100644 target/i386/nvmm/nvmm-accel-ops.c create mode 100644 target/i386/nvmm/nvmm-accel-ops.h create mode 100644 target/i386/nvmm/nvmm-all.c -- 2.31.1
