[Qemu-devel] [Bug 1798780] Re: hw/usb/dev-mtp.c:1616: bad test ?

[Thomas Huth]

** Changed in: qemu
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1798780

Title:
  hw/usb/dev-mtp.c:1616: bad test ?

Status in QEMU:
  Fix Released

Bug description:
  hw/usb/dev-mtp.c:1616:52: warning: logical ‘or’ of collectively
  exhaustive tests is always true [-Wlogical-op]

  Source code is

  if ((ret == -1) && (errno != EINTR || errno != EAGAIN ||
  errno != EWOULDBLOCK)) {

  Maybe better code

  if ((ret == -1) && (errno != EINTR && errno != EAGAIN &&
  errno != EWOULDBLOCK)) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1798780/+subscriptions

[Qemu-devel] [Bug 1798780] Re: hw/usb/dev-mtp.c:1616: bad test ?

[Peter Maydell]

Fixed by commit 49f9e8d660d4 which will be in QEMU 4.0.


** Changed in: qemu
   Status: New => Fix Committed

-- 
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1798780

Title:
  hw/usb/dev-mtp.c:1616: bad test ?

Status in QEMU:
  Fix Committed

Bug description:
  hw/usb/dev-mtp.c:1616:52: warning: logical ‘or’ of collectively
  exhaustive tests is always true [-Wlogical-op]

  Source code is

  if ((ret == -1) && (errno != EINTR || errno != EAGAIN ||
  errno != EWOULDBLOCK)) {

  Maybe better code

  if ((ret == -1) && (errno != EINTR && errno != EAGAIN &&
  errno != EWOULDBLOCK)) {

To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/1798780/+subscriptions