Re: [Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

[Marcel Apfelbaum]

On 10/25/18 9:17 AM, Yuval Shaia wrote:

Return value of 0 means ok, we want to free the memory only in case of
error.

Signed-off-by: Yuval Shaia 
---
  hw/rdma/vmw/pvrdma_cmd.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 4faeb21631..57d6f41ae6 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req 
*req,
   cmd->start, cmd->length, host_virt,
   cmd->access_flags, >mr_handle,
   >lkey, >rkey);
-if (host_virt && !resp->hdr.err) {
+if (resp->hdr.err && host_virt) {
  munmap(host_virt, cmd->length);
  }
  


Reviewed-by: Marcel Apfelbaum

Thanks,
Marcel

[Qemu-devel] [PATCH] hw/pvrdma: Check the correct return value

[Yuval Shaia]

Return value of 0 means ok, we want to free the memory only in case of
error.

Signed-off-by: Yuval Shaia 
---
 hw/rdma/vmw/pvrdma_cmd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 4faeb21631..57d6f41ae6 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -232,7 +232,7 @@ static int create_mr(PVRDMADev *dev, union pvrdma_cmd_req 
*req,
  cmd->start, cmd->length, host_virt,
  cmd->access_flags, >mr_handle,
  >lkey, >rkey);
-if (host_virt && !resp->hdr.err) {
+if (resp->hdr.err && host_virt) {
 munmap(host_virt, cmd->length);
 }
 
-- 
2.17.2