Re: [Qemu-devel] [PATCH] hw/pvrdma: remove not needed include

2018-08-12 Thread Yuval Shaia
On Sat, Aug 11, 2018 at 08:15:34PM +0300, Marcel Apfelbaum wrote:
> No need to include linux/types.h, is empty anyway.
> 
> Suggested-by: Thomas Huth 
> Signed-off-by: Marcel Apfelbaum 
> ---
>  hw/rdma/vmw/pvrdma_cmd.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
> index 14255d609f..3f697c8db7 100644
> --- a/hw/rdma/vmw/pvrdma_cmd.c
> +++ b/hw/rdma/vmw/pvrdma_cmd.c
> @@ -16,7 +16,6 @@
>  #include "qemu/osdep.h"
>  #include "qemu/error-report.h"
>  #include "cpu.h"
> -#include 
>  #include "hw/hw.h"
>  #include "hw/pci/pci.h"
>  #include "hw/pci/pci_ids.h"

Reviewed-by: Yuval Shaia 

> -- 
> 2.17.1
> 



[Qemu-devel] [PATCH] hw/pvrdma: remove not needed include

2018-08-11 Thread Marcel Apfelbaum
No need to include linux/types.h, is empty anyway.

Suggested-by: Thomas Huth 
Signed-off-by: Marcel Apfelbaum 
---
 hw/rdma/vmw/pvrdma_cmd.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/rdma/vmw/pvrdma_cmd.c b/hw/rdma/vmw/pvrdma_cmd.c
index 14255d609f..3f697c8db7 100644
--- a/hw/rdma/vmw/pvrdma_cmd.c
+++ b/hw/rdma/vmw/pvrdma_cmd.c
@@ -16,7 +16,6 @@
 #include "qemu/osdep.h"
 #include "qemu/error-report.h"
 #include "cpu.h"
-#include 
 #include "hw/hw.h"
 #include "hw/pci/pci.h"
 #include "hw/pci/pci_ids.h"
-- 
2.17.1