Re: [Qemu-devel] [PATCH] ppc: kvm: fix signedness warning

[Edgar E. Iglesias]

On Wed, Dec 08, 2010 at 12:01:43PM +0100, Alexander Graf wrote:
> ping?

I've applied this, thanks.


> On 25.11.2010, at 08:20, Alexander Graf wrote:
> 
> > I get a warning on a signed comparison with an unsigned variable, so
> > let's make the variable signed and be happy.
> > 
> > Signed-off-by: Alexander Graf 
> > ---
> > target-ppc/kvm.c |2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
> > index 5cacef7..5caa07c 100644
> > --- a/target-ppc/kvm.c
> > +++ b/target-ppc/kvm.c
> > @@ -132,7 +132,7 @@ int kvm_arch_get_registers(CPUState *env)
> > {
> > struct kvm_regs regs;
> > struct kvm_sregs sregs;
> > -uint32_t i, ret;
> > +int i, ret;
> > 
> > ret = kvm_vcpu_ioctl(env, KVM_GET_REGS, ®s);
> > if (ret < 0)
> > -- 
> > 1.6.0.2
> > 
> > 
> 
> 

Re: [Qemu-devel] [PATCH] ppc: kvm: fix signedness warning

[Alexander Graf]

ping?

On 25.11.2010, at 08:20, Alexander Graf wrote:

> I get a warning on a signed comparison with an unsigned variable, so
> let's make the variable signed and be happy.
> 
> Signed-off-by: Alexander Graf 
> ---
> target-ppc/kvm.c |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
> index 5cacef7..5caa07c 100644
> --- a/target-ppc/kvm.c
> +++ b/target-ppc/kvm.c
> @@ -132,7 +132,7 @@ int kvm_arch_get_registers(CPUState *env)
> {
> struct kvm_regs regs;
> struct kvm_sregs sregs;
> -uint32_t i, ret;
> +int i, ret;
> 
> ret = kvm_vcpu_ioctl(env, KVM_GET_REGS, ®s);
> if (ret < 0)
> -- 
> 1.6.0.2
> 
> 

[Qemu-devel] [PATCH] ppc: kvm: fix signedness warning

[Alexander Graf]

I get a warning on a signed comparison with an unsigned variable, so
let's make the variable signed and be happy.

Signed-off-by: Alexander Graf 
---
 target-ppc/kvm.c |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
index 5cacef7..5caa07c 100644
--- a/target-ppc/kvm.c
+++ b/target-ppc/kvm.c
@@ -132,7 +132,7 @@ int kvm_arch_get_registers(CPUState *env)
 {
 struct kvm_regs regs;
 struct kvm_sregs sregs;
-uint32_t i, ret;
+int i, ret;
 
 ret = kvm_vcpu_ioctl(env, KVM_GET_REGS, ®s);
 if (ret < 0)
-- 
1.6.0.2