[Qemu-devel] [PATCH] qdev: Fix memory leak in function set_pci_devfn

[Stefan Weil]

Valgrind reported this memory leak which occured very often.

Test scenario:

qemu-system-i386 (no arguments), only BIOS started, terminate with
monitor command (quit).

v2:
Use error_free instead of g_free (hint from Andreas Färber, thanks).

Signed-off-by: Stefan Weil s...@weilnetz.de
---
 hw/qdev-properties.c |1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 98dd06a..c5545dc 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -834,6 +834,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, void 
*opaque,
 
 visit_type_str(v, str, name, local_err);
 if (local_err) {
+error_free(local_err);
 return set_int32(obj, v, opaque, name, errp);
 }
 
-- 
1.7.9

Re: [Qemu-devel] [PATCH] qdev: Fix memory leak in function set_pci_devfn

[Andreas Färber]

Am 28.04.2012 14:32, schrieb Stefan Weil:
 Valgrind reported this memory leak which occured very often.
 
 Test scenario:
 
 qemu-system-i386 (no arguments), only BIOS started, terminate with
 monitor command (quit).
 
 v2:
 Use error_free instead of g_free (hint from Andreas Färber, thanks).
 
 Signed-off-by: Stefan Weil s...@weilnetz.de

Acked-by: Andreas Färber afaer...@suse.de

/-F

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg