Re: [Qemu-devel] [PATCH] target-mips: Allow DSP access to be disabled once enabled.

2013-01-08 Thread Aurelien Jarno 
On Mon, Jan 07, 2013 at 10:26:44PM -0800, Eric Johnson wrote:
 Clear the DSP hflags at the start of compute_hflags.  Otherwise access
 is not properly disabled once enabled.
 
 Signed-off-by: Eric Johnson er...@mips.com
 ---
  target-mips/cpu.h |2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
 
 diff --git a/target-mips/cpu.h b/target-mips/cpu.h
 index 31602ac..5963d62 100644
 --- a/target-mips/cpu.h
 +++ b/target-mips/cpu.h
 @@ -751,7 +751,7 @@ static inline void compute_hflags(CPUMIPSState *env)
  {
  env-hflags = ~(MIPS_HFLAG_COP1X | MIPS_HFLAG_64 | MIPS_HFLAG_CP0 |
   MIPS_HFLAG_F64 | MIPS_HFLAG_FPU | MIPS_HFLAG_KSU |
 - MIPS_HFLAG_UX);
 + MIPS_HFLAG_UX | MIPS_HFLAG_DSP | MIPS_HFLAG_DSPR2);
  if (!(env-CP0_Status  (1  CP0St_EXL)) 
  !(env-CP0_Status  (1  CP0St_ERL)) 
  !(env-hflags  MIPS_HFLAG_DM)) {
 

Thanks, applied.

-- 
Aurelien Jarno  GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net

[Qemu-devel] [PATCH] target-mips: Allow DSP access to be disabled once enabled.

2013-01-07 Thread Eric Johnson 
Clear the DSP hflags at the start of compute_hflags.  Otherwise access
is not properly disabled once enabled.

Signed-off-by: Eric Johnson er...@mips.com
---
 target-mips/cpu.h |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-mips/cpu.h b/target-mips/cpu.h
index 31602ac..5963d62 100644
--- a/target-mips/cpu.h
+++ b/target-mips/cpu.h
@@ -751,7 +751,7 @@ static inline void compute_hflags(CPUMIPSState *env)
 {
 env-hflags = ~(MIPS_HFLAG_COP1X | MIPS_HFLAG_64 | MIPS_HFLAG_CP0 |
  MIPS_HFLAG_F64 | MIPS_HFLAG_FPU | MIPS_HFLAG_KSU |
- MIPS_HFLAG_UX);
+ MIPS_HFLAG_UX | MIPS_HFLAG_DSP | MIPS_HFLAG_DSPR2);
 if (!(env-CP0_Status  (1  CP0St_EXL)) 
 !(env-CP0_Status  (1  CP0St_ERL)) 
 !(env-hflags  MIPS_HFLAG_DM)) {
-- 
1.7.4.4