Re: [Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl
Am 24.06.2012 17:14, schrieb Alexander Graf: On 24.06.2012, at 16:18, Stefan Weil s...@weilnetz.de wrote: This fixes a compiler error when QEMU was configured with --enable-debug. Signed-off-by: Stefan Weil s...@weilnetz.de --- Alex, please review. It fixes the compiler error, but I did the change simply by comparision with other functions, so I have no idea whether it is really correct. Looks good at a first glance, but will verify tonight. Thanks a lot for catching it! I guess we should add an --enable-debug build to buildbot. Blue/Stefan, could you set up a feature page on the Wiki for the AREG0 refactoring? Then we could document what maintainers/testers need to verify for the next series there. Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl
This fixes a compiler error when QEMU was configured with --enable-debug. Signed-off-by: Stefan Weil s...@weilnetz.de --- Alex, please review. It fixes the compiler error, but I did the change simply by comparision with other functions, so I have no idea whether it is really correct. Regards, Stefan target-ppc/translate_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c index e6580ff..5742229 100644 --- a/target-ppc/translate_init.c +++ b/target-ppc/translate_init.c @@ -4475,7 +4475,7 @@ static void spr_write_mas73(void *opaque, int sprn, int gprn) TCGv val = tcg_temp_new(); tcg_gen_ext32u_tl(val, cpu_gpr[gprn]); gen_store_spr(SPR_BOOKE_MAS3, val); -tcg_gen_shri_tl(val, gprn, 32); +tcg_gen_shri_tl(val, cpu_gpr[gprn], 32); gen_store_spr(SPR_BOOKE_MAS7, val); tcg_temp_free(val); } -- 1.7.10
Re: [Qemu-devel] [PATCH] target-ppc: Fix 2nd parameter for tcg_gen_shri_tl
On 24.06.2012, at 16:18, Stefan Weil s...@weilnetz.de wrote: This fixes a compiler error when QEMU was configured with --enable-debug. Signed-off-by: Stefan Weil s...@weilnetz.de --- Alex, please review. It fixes the compiler error, but I did the change simply by comparision with other functions, so I have no idea whether it is really correct. Looks good at a first glance, but will verify tonight. Thanks a lot for catching it! I guess we should add an --enable-debug build to buildbot. Alex
