Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
Applied to -trivial, thanks! /mjt
Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
On 18/05/2017 12:36, Juan Quintela wrote: > All the file is surounded already by #ifndef CONFIG_USER_ONLY. > > Signed-off-by: Juan Quintela> --- > include/exec/memory.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 99e0f54..6b5b953 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -17,9 +17,7 @@ > #ifndef CONFIG_USER_ONLY > > #include "exec/cpu-common.h" > -#ifndef CONFIG_USER_ONLY > #include "exec/hwaddr.h" > -#endif > #include "exec/memattrs.h" > #include "exec/ramlist.h" > #include "qemu/queue.h" > Reviewed-by: Laurent Vivier
Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
* Juan Quintela (quint...@redhat.com) wrote: > All the file is surounded already by #ifndef CONFIG_USER_ONLY. > > Signed-off-by: Juan QuintelaAh yes, the patch that added the inner ifndef added it to every use of exec/hwaddr.h. Reviewed-by: Dr. David Alan Gilbert > --- > include/exec/memory.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 99e0f54..6b5b953 100644 > --- a/include/exec/memory.h > +++ b/include/exec/memory.h > @@ -17,9 +17,7 @@ > #ifndef CONFIG_USER_ONLY > > #include "exec/cpu-common.h" > -#ifndef CONFIG_USER_ONLY > #include "exec/hwaddr.h" > -#endif > #include "exec/memattrs.h" > #include "exec/ramlist.h" > #include "qemu/queue.h" > -- > 2.9.3 > -- Dr. David Alan Gilbert / dgilb...@redhat.com / Manchester, UK
[Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h
All the file is surounded already by #ifndef CONFIG_USER_ONLY. Signed-off-by: Juan Quintela--- include/exec/memory.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/exec/memory.h b/include/exec/memory.h index 99e0f54..6b5b953 100644 --- a/include/exec/memory.h +++ b/include/exec/memory.h @@ -17,9 +17,7 @@ #ifndef CONFIG_USER_ONLY #include "exec/cpu-common.h" -#ifndef CONFIG_USER_ONLY #include "exec/hwaddr.h" -#endif #include "exec/memattrs.h" #include "exec/ramlist.h" #include "qemu/queue.h" -- 2.9.3