Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-11-03 Thread Markus Armbruster 
Eduardo Habkost  writes:

> A few fixes on check-qom-proplist that will ensure we test both
> class properties and object properties, and catch errors when
> registering properties in test code.

Series
Reviewed-by: Markus Armbruster 

Excessively long delay considering how simple these patches are.  My
apologies.

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-10-25 Thread Eduardo Habkost 
Pinging again.

On Mon, Oct 17, 2016 at 07:02:37PM -0200, Eduardo Habkost wrote:
> Ping?
> 
> Markus, do you want to merge this through your tree?
> 
> On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
> > A few fixes on check-qom-proplist that will ensure we test both
> > class properties and object properties, and catch errors when
> > registering properties in test code.
> > 
> > Eduardo Habkost (2):
> >   tests: check-qom-proplist: Remove "bv" class property from class
> >   tests: check-qom-proplist: Use _abort to catch errors
> > 
> >  tests/check-qom-proplist.c | 10 +++---
> >  1 file changed, 3 insertions(+), 7 deletions(-)
> > 
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Eduardo
> 

-- 
Eduardo

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-10-18 Thread Eduardo Habkost 
On Tue, Oct 18, 2016 at 12:07:30AM +0200, Andreas Färber wrote:
> Am 17.10.2016 um 23:02 schrieb Eduardo Habkost:
> > Ping?
> > 
> > Markus, do you want to merge this through your tree?
> > 
> > On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
> >> A few fixes on check-qom-proplist that will ensure we test both
> >> class properties and object properties, and catch errors when
> >> registering properties in test code.
> >>
> >> Eduardo Habkost (2):
> >>   tests: check-qom-proplist: Remove "bv" class property from class
> 
> This part I didn't quite understand from looking at the patch, but...

The "bv" property was being registered twice (as class property
and as instance property). The instance property registration was
always failing because of that.

One of them has to go away. I decided to remove the class
property because this allows the test code to cover both instance
properties ("bv") and class properties ("sv").

> 
> >>   tests: check-qom-proplist: Use _abort to catch errors
> 
> For this one:
> 
> Reviewed-by: Andreas Färber 

Thanks!

-- 
Eduardo

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-10-17 Thread Andreas Färber 
Am 17.10.2016 um 23:02 schrieb Eduardo Habkost:
> Ping?
> 
> Markus, do you want to merge this through your tree?
> 
> On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
>> A few fixes on check-qom-proplist that will ensure we test both
>> class properties and object properties, and catch errors when
>> registering properties in test code.
>>
>> Eduardo Habkost (2):
>>   tests: check-qom-proplist: Remove "bv" class property from class

This part I didn't quite understand from looking at the patch, but...

>>   tests: check-qom-proplist: Use _abort to catch errors

For this one:

Reviewed-by: Andreas Färber 

Regards,
Andreas

>>  tests/check-qom-proplist.c | 10 +++---
>>  1 file changed, 3 insertions(+), 7 deletions(-)

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

Re: [Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-10-17 Thread Eduardo Habkost 
Ping?

Markus, do you want to merge this through your tree?

On Tue, Oct 11, 2016 at 09:37:45AM -0300, Eduardo Habkost wrote:
> A few fixes on check-qom-proplist that will ensure we test both
> class properties and object properties, and catch errors when
> registering properties in test code.
> 
> Eduardo Habkost (2):
>   tests: check-qom-proplist: Remove "bv" class property from class
>   tests: check-qom-proplist: Use _abort to catch errors
> 
>  tests/check-qom-proplist.c | 10 +++---
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 
> -- 
> 2.7.4
> 

-- 
Eduardo

[Qemu-devel] [PATCH 0/2] tests: A few check-qom-proplist fixes

2016-10-11 Thread Eduardo Habkost 
A few fixes on check-qom-proplist that will ensure we test both
class properties and object properties, and catch errors when
registering properties in test code.

Eduardo Habkost (2):
  tests: check-qom-proplist: Remove "bv" class property from class
  tests: check-qom-proplist: Use _abort to catch errors

 tests/check-qom-proplist.c | 10 +++---
 1 file changed, 3 insertions(+), 7 deletions(-)

-- 
2.7.4