Re: [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support
On 12.10.2016 22:49, Max Reitz wrote: > As reported by Hao QingFeng, iotest 162 is currently executed even if > qemu does not have any SSH support (which makes it fail, naturally). > > Fixing that is not so trivial, because qemu-img currently does not > report modules, and SSH can be compiled as a module, so that needs to be > fixed first. While doing so, I noticed that bdrv_iterate_format() tries > to sort the list of formats, which is a bit contrary to my experience. > Turns out that needs to be fixed, too. > > > This series can either be applied on top of my series "iotests: Fix test > 162" or just directly on master, both works (i.e. the patches in this > series do not interfere with those from that one). I still thought I'd > mention that series, if nothing else then only to get you to review that > other one. ;-) > > > Max Reitz (3): > block: Fix bdrv_iterate_format() sorting > block: Emit modules in bdrv_iterate_format() > iotests: Skip test 162 if there is no SSH support > > block.c| 20 +++- > tests/qemu-iotests/162 | 3 +++ > 2 files changed, 22 insertions(+), 1 deletion(-) Applied to my block tree. Max signature.asc Description: OpenPGP digital signature
Re: [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support
Hi, Your series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20161012204907.25941-1-mre...@redhat.com Subject: [Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support Type: series === TEST SCRIPT BEGIN === #!/bin/bash set -e git submodule update --init dtc # Let docker tests dump environment info export SHOW_ENV=1 export J=16 make docker-test-quick@centos6 make docker-test-mingw@fedora === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20161012204907.25941-1-mre...@redhat.com -> patchew/20161012204907.25941-1-mre...@redhat.com Switched to a new branch 'test' edffc08 iotests: Skip test 162 if there is no SSH support de2a49f block: Emit modules in bdrv_iterate_format() 63e6b44 block: Fix bdrv_iterate_format() sorting === OUTPUT BEGIN === Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc' Cloning into 'dtc'... Submodule path 'dtc': checked out '65cc4d2748a2c2e6f27f1cf39e07a5dbabd80ebf' BUILD centos6 === OUTPUT END === Abort: command timeout (>3600 seconds) --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@freelists.org
[Qemu-devel] [PATCH 0/3] iotests: Skip 162 if there is no SSH support
As reported by Hao QingFeng, iotest 162 is currently executed even if qemu does not have any SSH support (which makes it fail, naturally). Fixing that is not so trivial, because qemu-img currently does not report modules, and SSH can be compiled as a module, so that needs to be fixed first. While doing so, I noticed that bdrv_iterate_format() tries to sort the list of formats, which is a bit contrary to my experience. Turns out that needs to be fixed, too. This series can either be applied on top of my series "iotests: Fix test 162" or just directly on master, both works (i.e. the patches in this series do not interfere with those from that one). I still thought I'd mention that series, if nothing else then only to get you to review that other one. ;-) Max Reitz (3): block: Fix bdrv_iterate_format() sorting block: Emit modules in bdrv_iterate_format() iotests: Skip test 162 if there is no SSH support block.c| 20 +++- tests/qemu-iotests/162 | 3 +++ 2 files changed, 22 insertions(+), 1 deletion(-) -- 2.10.0
