Re: [Qemu-devel] [PATCH 0/5] ARM: fix VQSHL (register)

2010-12-27 Thread Aurelien Jarno
On Tue, Dec 07, 2010 at 02:13:40PM +, Peter Maydell wrote:
 This patchset fixes bugs in the decode and implementation
 of the ARM Neon VQSHL (register) instruction form. It is
 a split out version of those parts of the maemo-qemu tree
 commit 03a2445a which deal with this instruction form;
 the remainder which address VQSHL (immediate) I'll send
 in a separate patchset.
 
 The 'Fix VQSHL of signed 64 bit values by shift counts = 64'
 patch is a bug fix which does not appear in the maemo-qemu
 patch. 'Correct result in saturating cases for VQSHL of s8/16/32'
 does appear, but I refactored it a little to be clearer;
 these two therefore have me as the author.
 
 These patches have been tested by running random instruction
 sequences and comparing against A8 hardware.
 

Thanks, applied.

-- 
Aurelien Jarno  GPG: 1024D/F1BCDB73
aurel...@aurel32.net http://www.aurel32.net



[Qemu-devel] [PATCH 0/5] ARM: fix VQSHL (register)

2010-12-07 Thread Peter Maydell
This patchset fixes bugs in the decode and implementation
of the ARM Neon VQSHL (register) instruction form. It is
a split out version of those parts of the maemo-qemu tree
commit 03a2445a which deal with this instruction form;
the remainder which address VQSHL (immediate) I'll send
in a separate patchset.

The 'Fix VQSHL of signed 64 bit values by shift counts = 64'
patch is a bug fix which does not appear in the maemo-qemu
patch. 'Correct result in saturating cases for VQSHL of s8/16/32'
does appear, but I refactored it a little to be clearer;
these two therefore have me as the author.

These patches have been tested by running random instruction
sequences and comparing against A8 hardware.


Juha Riihimäki (3):
  ARM: Fix arguments passed to VQSHL helpers
  ARM: Fix VQSHL of signed 64 bit values
  ARM: remove pointless else clause in VQSHL of u64

Peter Maydell (2):
  ARM: Fix VQSHL of signed 64 bit values by shift counts = 64
  ARM: Correct result in saturating cases for VQSHL of s8/16/32

 target-arm/neon_helper.c |   21 ++---
 target-arm/translate.c   |4 ++--
 2 files changed, 16 insertions(+), 9 deletions(-)