Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures
On 2019/8/19 上午5:38, Philippe Mathieu-Daudé wrote: > Hi Jason, > > On 8/8/19 4:34 PM, Philippe Mathieu-Daudé wrote: >> This is a preparatory cleanup series. >> >> Commit 75020a70215 introduced 4 very equivalent structures: >> - tcp_header and tcp_hdr, >> - udp_header and udp_hdr. >> >> Choose the most widely use in the codebase, which happens to >> provide convenient bitfields manipulation macros and is not >> endian-specific. >> >> Philippe Mathieu-Daudé (6): >> hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros >> net/colo-compare: Use the tcp_header structure >> net/filter-rewriter: Use the tcp_header structure >> hw/net/vmxnet3: Use the tcp_header structure >> net/eth: Remove the unused tcp_hdr structure >> net/eth: Remove the single use of udp_hdr structure > Are you OK to take this series? > > It got reviewed by Dmitry Fleytman. > > Thanks, > > Phil. Yes. Applied. Thanks
Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures
Hi Jason, On 8/8/19 4:34 PM, Philippe Mathieu-Daudé wrote: > This is a preparatory cleanup series. > > Commit 75020a70215 introduced 4 very equivalent structures: > - tcp_header and tcp_hdr, > - udp_header and udp_hdr. > > Choose the most widely use in the codebase, which happens to > provide convenient bitfields manipulation macros and is not > endian-specific. > > Philippe Mathieu-Daudé (6): > hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros > net/colo-compare: Use the tcp_header structure > net/filter-rewriter: Use the tcp_header structure > hw/net/vmxnet3: Use the tcp_header structure > net/eth: Remove the unused tcp_hdr structure > net/eth: Remove the single use of udp_hdr structure Are you OK to take this series? It got reviewed by Dmitry Fleytman. Thanks, Phil.
Re: [Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures
Reviewed-by: Dmitry Fleytman > On 8 Aug 2019, at 17:34, Philippe Mathieu-Daudé wrote: > > This is a preparatory cleanup series. > > Commit 75020a70215 introduced 4 very equivalent structures: > - tcp_header and tcp_hdr, > - udp_header and udp_hdr. > > Choose the most widely use in the codebase, which happens to > provide convenient bitfields manipulation macros and is not > endian-specific. > > Philippe Mathieu-Daudé (6): > hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros > net/colo-compare: Use the tcp_header structure > net/filter-rewriter: Use the tcp_header structure > hw/net/vmxnet3: Use the tcp_header structure > net/eth: Remove the unused tcp_hdr structure > net/eth: Remove the single use of udp_hdr structure > > hw/net/net_rx_pkt.c | 2 +- > hw/net/net_tx_pkt.c | 9 + > hw/net/virtio-net.c | 9 ++--- > include/net/eth.h | 47 --- > net/colo-compare.c| 14 ++--- > net/filter-rewriter.c | 37 +++--- > 6 files changed, 44 insertions(+), 74 deletions(-) > > -- > 2.20.1 >
[Qemu-devel] [PATCH 0/6] net/eth: Remove duplicated tcp/udp_hdr structures
This is a preparatory cleanup series. Commit 75020a70215 introduced 4 very equivalent structures: - tcp_header and tcp_hdr, - udp_header and udp_hdr. Choose the most widely use in the codebase, which happens to provide convenient bitfields manipulation macros and is not endian-specific. Philippe Mathieu-Daudé (6): hw/net/virtio-net: Use TCP_HEADER_FLAGS/TCP_HEADER_DATA_OFFSET macros net/colo-compare: Use the tcp_header structure net/filter-rewriter: Use the tcp_header structure hw/net/vmxnet3: Use the tcp_header structure net/eth: Remove the unused tcp_hdr structure net/eth: Remove the single use of udp_hdr structure hw/net/net_rx_pkt.c | 2 +- hw/net/net_tx_pkt.c | 9 + hw/net/virtio-net.c | 9 ++--- include/net/eth.h | 47 --- net/colo-compare.c| 14 ++--- net/filter-rewriter.c | 37 +++--- 6 files changed, 44 insertions(+), 74 deletions(-) -- 2.20.1
