Re: [Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty

[Orit Wasserman]

On 11/06/2013 03:04 PM, Juan Quintela wrote:

Signed-off-by: Juan Quintela 
---
  exec.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/exec.c b/exec.c
index 79610ce..7cf5634 100644
--- a/exec.c
+++ b/exec.c
@@ -1397,7 +1397,7 @@ static void notdirty_mem_write(void *opaque, hwaddr 
ram_addr,
  cpu_physical_memory_set_dirty_flags(ram_addr, dirty_flags);
  /* we remove the notdirty callback only if the code has been
 flushed */
-if (dirty_flags == 0xff) {
+if (cpu_physical_memory_is_dirty(ram_addr)) {
  CPUArchState *env = current_cpu->env_ptr;
  tlb_set_dirty(env, env->mem_io_vaddr);
  }



Reviewed-by: Orit Wasserman 

[Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty

[Juan Quintela]

Signed-off-by: Juan Quintela 
---
 exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/exec.c b/exec.c
index 79610ce..7cf5634 100644
--- a/exec.c
+++ b/exec.c
@@ -1397,7 +1397,7 @@ static void notdirty_mem_write(void *opaque, hwaddr 
ram_addr,
 cpu_physical_memory_set_dirty_flags(ram_addr, dirty_flags);
 /* we remove the notdirty callback only if the code has been
flushed */
-if (dirty_flags == 0xff) {
+if (cpu_physical_memory_is_dirty(ram_addr)) {
 CPUArchState *env = current_cpu->env_ptr;
 tlb_set_dirty(env, env->mem_io_vaddr);
 }
-- 
1.8.3.1