Re: [Qemu-devel] [PATCH 09/12] qemu-iotests: do not search for binaries in the current directory

[Markus Armbruster]

Paolo Bonzini  writes:

> Looking in the build root is enough.
>
> Signed-off-by: Paolo Bonzini 

It's actually *better*.  I hate it when tests pick up random garbage I
have lying around.

[Qemu-devel] [PATCH 09/12] qemu-iotests: do not search for binaries in the current directory

[Paolo Bonzini]

Looking in the build root is enough.

Signed-off-by: Paolo Bonzini 
---
 tests/qemu-iotests/check | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 5b9c0c8ade..e5d1ae3d92 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -86,17 +86,17 @@ then
 fi
 fi
 
-if [[ -z $QEMU_IMG_PROG && -x "$build_root/qemu-img" && ! -x './qemu-img' ]]
+if [[ -z $QEMU_IMG_PROG && -x "$build_root/qemu-img" ]]
 then
 export QEMU_IMG_PROG="$build_root/qemu-img"
 fi
 
-if [[ -z $QEMU_IO_PROG && -x "$build_root/qemu-io" && ! -x './qemu-io' ]]
+if [[ -z $QEMU_IO_PROG && -x "$build_root/qemu-io" ]]
 then
 export QEMU_IO_PROG="$build_root/qemu-io"
 fi
 
-if [[ -z $QEMU_NBD_PROG && -x "$build_root/qemu-nbd" && ! -x './qemu-nbd' ]]
+if [[ -z $QEMU_NBD_PROG && -x "$build_root/qemu-nbd" ]]
 then
 export QEMU_NBD_PROG="$build_root/qemu-nbd"
 fi
-- 
2.13.3