Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

[Markus Armbruster]

Sascha Silbe  writes:

> Sort the alias table by typename so it's easier to see which aliases
> exist.
>
> Signed-off-by: Sascha Silbe 
> ---
>  qdev-monitor.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/qdev-monitor.c b/qdev-monitor.c
> index 81e3ff3..0145deb 100644
> --- a/qdev-monitor.c
> +++ b/qdev-monitor.c
> @@ -40,18 +40,18 @@ typedef struct QDevAlias
>  } QDevAlias;
>  
>  static const QDevAlias qdev_alias_table[] = {

Suggest to add

   /* Please keep this table sorted */

> -{ "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X 
> },
> +{ "e1000", "e1000-82540em" },
> +{ "ich9-ahci", "ahci" },
> +{ "kvm-pci-assign", "pci-assign" },
> +{ "lsi53c895a", "lsi" },
>  { "virtio-balloon-pci", "virtio-balloon",
>  QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>  { "virtio-blk-ccw", "virtio-blk", QEMU_ARCH_S390X },
> +{ "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>  { "virtio-net-ccw", "virtio-net", QEMU_ARCH_S390X },
> +{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>  { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X },
> -{ "lsi53c895a", "lsi" },
> -{ "ich9-ahci", "ahci" },
> -{ "kvm-pci-assign", "pci-assign" },
> -{ "e1000", "e1000-82540em" },
> +{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X 
> },
>  { }
>  };

Reviewed-by: Markus Armbruster 

Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

[Sascha Silbe]

Dear Markus,

Markus Armbruster  writes:

> Sascha Silbe  writes:
>
>> Sort the alias table by typename so it's easier to see which aliases
>> exist.
[...]
[qdev-monitor.c]
>
> Suggest to add
>
>/* Please keep this table sorted */

Good idea. I've amended the following locally:

/* Please keep this table sorted by typename. */


Holding onto this patch for a few more days to give virtio devs a chance
to decide on whether to add the full set right away.


> Reviewed-by: Markus Armbruster 

Thanks for the reviews!

Sascha
-- 
Softwareentwicklung Sascha Silbe, Niederhofenstraße 5/1, 71229 Leonberg
https://se-silbe.de/
USt-IdNr. DE281696641

Re: [Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

[Halil Pasic]

On 02/09/2016 02:15 PM, Sascha Silbe wrote:
> Sort the alias table by typename so it's easier to see which aliases
> exist.
> 
> Signed-off-by: Sascha Silbe 
> ---
>  qdev-monitor.c | 14 +++---
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/qdev-monitor.c b/qdev-monitor.c
> index 81e3ff3..0145deb 100644
> --- a/qdev-monitor.c
> +++ b/qdev-monitor.c
> @@ -40,18 +40,18 @@ typedef struct QDevAlias
>  } QDevAlias;
> 
>  static const QDevAlias qdev_alias_table[] = {
> -{ "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
> -{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X 
> },
> +{ "e1000", "e1000-82540em" },
> +{ "ich9-ahci", "ahci" },
> +{ "kvm-pci-assign", "pci-assign" },
> +{ "lsi53c895a", "lsi" },
>  { "virtio-balloon-pci", "virtio-balloon",
>  QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>  { "virtio-blk-ccw", "virtio-blk", QEMU_ARCH_S390X },
> +{ "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>  { "virtio-net-ccw", "virtio-net", QEMU_ARCH_S390X },
> +{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
>  { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X },
> -{ "lsi53c895a", "lsi" },
> -{ "ich9-ahci", "ahci" },
> -{ "kvm-pci-assign", "pci-assign" },
> -{ "e1000", "e1000-82540em" },
> +{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X 
> },
>  { }
>  };
> 
Reviewed-by: Halil Pasic 

[Qemu-devel] [PATCH 1/3] qdev-monitor: sort alias table by typename

[Sascha Silbe]

Sort the alias table by typename so it's easier to see which aliases
exist.

Signed-off-by: Sascha Silbe 
---
 qdev-monitor.c | 14 +++---
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/qdev-monitor.c b/qdev-monitor.c
index 81e3ff3..0145deb 100644
--- a/qdev-monitor.c
+++ b/qdev-monitor.c
@@ -40,18 +40,18 @@ typedef struct QDevAlias
 } QDevAlias;
 
 static const QDevAlias qdev_alias_table[] = {
-{ "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
-{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
-{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
+{ "e1000", "e1000-82540em" },
+{ "ich9-ahci", "ahci" },
+{ "kvm-pci-assign", "pci-assign" },
+{ "lsi53c895a", "lsi" },
 { "virtio-balloon-pci", "virtio-balloon",
 QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
 { "virtio-blk-ccw", "virtio-blk", QEMU_ARCH_S390X },
+{ "virtio-blk-pci", "virtio-blk", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
 { "virtio-net-ccw", "virtio-net", QEMU_ARCH_S390X },
+{ "virtio-net-pci", "virtio-net", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
 { "virtio-serial-ccw", "virtio-serial", QEMU_ARCH_S390X },
-{ "lsi53c895a", "lsi" },
-{ "ich9-ahci", "ahci" },
-{ "kvm-pci-assign", "pci-assign" },
-{ "e1000", "e1000-82540em" },
+{ "virtio-serial-pci", "virtio-serial", QEMU_ARCH_ALL & ~QEMU_ARCH_S390X },
 { }
 };
 
-- 
2.1.4