Re: [Qemu-devel] [PATCH 2/2] pc-bios: Added u-boot-sam460 firmware binary

[BALATON Zoltan]

On Tue, 20 Feb 2018, Daniel P. Berrangé wrote:

On Tue, Feb 20, 2018 at 06:57:43PM +0100, BALATON Zoltan wrote:

Signed-off-by: BALATON Zoltan 
---
 Makefile   |   2 +-
 pc-bios/u-boot-sam460-20100605.bin | Bin 0 -> 524288 bytes
 2 files changed, 1 insertion(+), 1 deletion(-)
 create mode 100755 pc-bios/u-boot-sam460-20100605.bin

diff --git a/Makefile b/Makefile
index 6434d6c..b0c16b3 100644
--- a/Makefile
+++ b/Makefile
@@ -661,7 +661,7 @@ multiboot.bin linuxboot.bin linuxboot_dma.bin kvmvapic.bin \
 s390-ccw.img s390-netboot.img \
 spapr-rtas.bin slof.bin skiboot.lid \
 palcode-clipper \
-u-boot.e500 \
+u-boot.e500 u-boot-sam460-20100605.bin \
 qemu_vga.ndrv \
 hppa-firmware.img
 else
diff --git a/pc-bios/u-boot-sam460-20100605.bin 
b/pc-bios/u-boot-sam460-20100605.bin
new file mode 100755


IIUC, you also need to provide glue in roms/Makefile to build the
u-boot-sam460-20100605.bin from the submodule content. Presumably
you can largely copy what's done for u-boot.e500 there.


Yes, it seems we can do the same (except stripping the result) and build 
the Sam460ex_config from the appropriate source that should generate the 
binary (but I'm not sure about the cross compiler setup in that Makefile, 
my cross compiler is called powerpc-elf-gcc and after briefly looking at 
it I'm not sure it will be found by that make magic).


Once the patch to add the sources is cleared I can send a v2 of this with 
the roms/Makefile changes to also add a new target for this binary.


Regards,
BALATON Zoltan

Re: [Qemu-devel] [PATCH 2/2] pc-bios: Added u-boot-sam460 firmware binary

[Daniel P . Berrangé]

On Tue, Feb 20, 2018 at 06:57:43PM +0100, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan 
> ---
>  Makefile   |   2 +-
>  pc-bios/u-boot-sam460-20100605.bin | Bin 0 -> 524288 bytes
>  2 files changed, 1 insertion(+), 1 deletion(-)
>  create mode 100755 pc-bios/u-boot-sam460-20100605.bin
> 
> diff --git a/Makefile b/Makefile
> index 6434d6c..b0c16b3 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -661,7 +661,7 @@ multiboot.bin linuxboot.bin linuxboot_dma.bin 
> kvmvapic.bin \
>  s390-ccw.img s390-netboot.img \
>  spapr-rtas.bin slof.bin skiboot.lid \
>  palcode-clipper \
> -u-boot.e500 \
> +u-boot.e500 u-boot-sam460-20100605.bin \
>  qemu_vga.ndrv \
>  hppa-firmware.img
>  else
> diff --git a/pc-bios/u-boot-sam460-20100605.bin 
> b/pc-bios/u-boot-sam460-20100605.bin
> new file mode 100755

IIUC, you also need to provide glue in roms/Makefile to build the
u-boot-sam460-20100605.bin from the submodule content. Presumably
you can largely copy what's done for u-boot.e500 there.

Regards,
Daniel
-- 
|: https://berrange.com  -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-https://fstop138.berrange.com :|
|: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|