[Qemu-devel] [PATCH 2/2] test-aio: Fix event notifier cleanup
One test case closed an event notifier (event_notifier_cleanup()) without first disabling it (set_event_notifier(..., NULL)). This resulted in a leftover handle 0 that was added to each subsequent WaitForMultipleObjects() call, causing the function to fail (invalid handle). Signed-off-by: Kevin Wolf--- tests/test-aio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/test-aio.c b/tests/test-aio.c index 1623803..e188d8c 100644 --- a/tests/test-aio.c +++ b/tests/test-aio.c @@ -393,6 +393,7 @@ static void test_aio_external_client(void) aio_enable_external(ctx); } assert(aio_poll(ctx, false)); +set_event_notifier(ctx, , NULL); event_notifier_cleanup(); } } -- 1.8.3.1
Re: [Qemu-devel] [PATCH 2/2] test-aio: Fix event notifier cleanup
On 23/11/2015 13:39, Kevin Wolf wrote: > One test case closed an event notifier (event_notifier_cleanup()) > without first disabling it (set_event_notifier(..., NULL)). This > resulted in a leftover handle 0 that was added to each subsequent > WaitForMultipleObjects() call, causing the function to fail (invalid > handle). > > Signed-off-by: Kevin Wolf> --- > tests/test-aio.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/test-aio.c b/tests/test-aio.c > index 1623803..e188d8c 100644 > --- a/tests/test-aio.c > +++ b/tests/test-aio.c > @@ -393,6 +393,7 @@ static void test_aio_external_client(void) > aio_enable_external(ctx); > } > assert(aio_poll(ctx, false)); > +set_event_notifier(ctx, , NULL); > event_notifier_cleanup(); > } > } > Reviewed-by: Paolo Bonzini