Re: [Qemu-devel] [PATCH 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

[Thomas Huth]

On 30/04/2019 07.49, Philippe Mathieu-Daudé wrote:
> On 4/29/19 2:33 AM, driver1998 wrote:
>> Windows ARM64 uses LLP64 model, which breaks current assumptions.
>>
>> Signed-off-by: driver1998 
>> ---
>>  util/cacheinfo.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/util/cacheinfo.c b/util/cacheinfo.c
>> index 3cd080b83d..a815cb0722 100644
>> --- a/util/cacheinfo.c
>> +++ b/util/cacheinfo.c
>> @@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize)
>>  static void arch_cache_info(int *isize, int *dsize)
>>  {
>>  if (*isize == 0 || *dsize == 0) {
>> -unsigned long ctr;
>> +uintptr_t ctr;
>>  
>>  /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1,
>> but (at least under Linux) these are marked protected by the
>> @@ -120,6 +120,8 @@ static void arch_cache_info(int *isize, int *dsize)
>>  if (*dsize == 0) {
>>  *dsize = 4 << ((ctr >> 16) & 0xf);
>>  }
>> +
>> +printf("%d %d\n", *isize, *dsize);
> 
> The patch looks correct (except your real name), but here you forgot to
> remove this debugging code.

Right. With the "Signed-off-by" line you have to state that you've read
and followed the "Developer's Certificate of Origin". For this, no
pseudonym contributions are possible, sorry.
See this URLs for details:

 
https://wiki.qemu.org/Contribute/SubmitAPatch#Patch_emails_must_include_a_Signed-off-by:_line

  Thomas

Re: [Qemu-devel] [PATCH 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

[Philippe Mathieu-Daudé]

On 4/29/19 2:33 AM, driver1998 wrote:
> Windows ARM64 uses LLP64 model, which breaks current assumptions.
> 
> Signed-off-by: driver1998 
> ---
>  util/cacheinfo.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/util/cacheinfo.c b/util/cacheinfo.c
> index 3cd080b83d..a815cb0722 100644
> --- a/util/cacheinfo.c
> +++ b/util/cacheinfo.c
> @@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize)
>  static void arch_cache_info(int *isize, int *dsize)
>  {
>  if (*isize == 0 || *dsize == 0) {
> -unsigned long ctr;
> +uintptr_t ctr;
>  
>  /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1,
> but (at least under Linux) these are marked protected by the
> @@ -120,6 +120,8 @@ static void arch_cache_info(int *isize, int *dsize)
>  if (*dsize == 0) {
>  *dsize = 4 << ((ctr >> 16) & 0xf);
>  }
> +
> +printf("%d %d\n", *isize, *dsize);

The patch looks correct (except your real name), but here you forgot to
remove this debugging code.

>  }
>  }
>  
> 

[Qemu-devel] [PATCH 3/4] util/cacheinfo.c: Use uintptr_t instead of unsigned long in AArch64 arch_cache_info()

[driver1998]

Windows ARM64 uses LLP64 model, which breaks current assumptions.

Signed-off-by: driver1998 
---
 util/cacheinfo.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/util/cacheinfo.c b/util/cacheinfo.c
index 3cd080b83d..a815cb0722 100644
--- a/util/cacheinfo.c
+++ b/util/cacheinfo.c
@@ -107,7 +107,7 @@ static void sys_cache_info(int *isize, int *dsize)
 static void arch_cache_info(int *isize, int *dsize)
 {
 if (*isize == 0 || *dsize == 0) {
-unsigned long ctr;
+uintptr_t ctr;
 
 /* The real cache geometry is in CCSIDR_EL1/CLIDR_EL1/CSSELR_EL1,
but (at least under Linux) these are marked protected by the
@@ -120,6 +120,8 @@ static void arch_cache_info(int *isize, int *dsize)
 if (*dsize == 0) {
 *dsize = 4 << ((ctr >> 16) & 0xf);
 }
+
+printf("%d %d\n", *isize, *dsize);
 }
 }
 
-- 
2.17.1