Re: [Qemu-devel] [PATCH 4/4] sdl2: move SDL_* includes to sdl2.h

2015-01-15 Thread Max Reitz

On 2015-01-12 at 07:35, Gerd Hoffmann wrote:

Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
  include/ui/sdl2.h | 7 +++
  ui/sdl2-2d.c  | 6 --
  ui/sdl2-gl.c  | 7 ---
  ui/sdl2-input.c   | 6 --
  ui/sdl2.c | 6 --
  5 files changed, 7 insertions(+), 25 deletions(-)


Reviewed-by: Max Reitz mre...@redhat.com



[Qemu-devel] [PATCH 4/4] sdl2: move SDL_* includes to sdl2.h

2015-01-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
 include/ui/sdl2.h | 7 +++
 ui/sdl2-2d.c  | 6 --
 ui/sdl2-gl.c  | 7 ---
 ui/sdl2-input.c   | 6 --
 ui/sdl2.c | 6 --
 5 files changed, 7 insertions(+), 25 deletions(-)

diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
index 5c962da..a80b3a1 100644
--- a/include/ui/sdl2.h
+++ b/include/ui/sdl2.h
@@ -1,6 +1,13 @@
 #ifndef SDL2_H
 #define SDL2_H
 
+/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
+#undef WIN32_LEAN_AND_MEAN
+
+#include SDL.h
+#include SDL_syswm.h
+#include SDL_opengl.h
+
 struct sdl2_console {
 DisplayChangeListener dcl;
 DisplaySurface *surface;
diff --git a/ui/sdl2-2d.c b/ui/sdl2-2d.c
index 85f1be4..f6cb438 100644
--- a/ui/sdl2-2d.c
+++ b/ui/sdl2-2d.c
@@ -23,12 +23,6 @@
  */
 /* Ported SDL 1.2 code to 2.0 by Dave Airlie. */
 
-/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
-#undef WIN32_LEAN_AND_MEAN
-
-#include SDL.h
-#include SDL_syswm.h
-
 #include qemu-common.h
 #include ui/console.h
 #include ui/input.h
diff --git a/ui/sdl2-gl.c b/ui/sdl2-gl.c
index b8620ca..6de01ad 100644
--- a/ui/sdl2-gl.c
+++ b/ui/sdl2-gl.c
@@ -23,13 +23,6 @@
  */
 /* Ported SDL 1.2 code to 2.0 by Dave Airlie. */
 
-/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
-#undef WIN32_LEAN_AND_MEAN
-
-#include SDL.h
-#include SDL_syswm.h
-#include SDL_opengl.h
-
 #include qemu-common.h
 #include ui/console.h
 #include ui/input.h
diff --git a/ui/sdl2-input.c b/ui/sdl2-input.c
index a1973fc..ac5dc94 100644
--- a/ui/sdl2-input.c
+++ b/ui/sdl2-input.c
@@ -23,12 +23,6 @@
  */
 /* Ported SDL 1.2 code to 2.0 by Dave Airlie. */
 
-/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
-#undef WIN32_LEAN_AND_MEAN
-
-#include SDL.h
-#include SDL_syswm.h
-
 #include qemu-common.h
 #include ui/console.h
 #include ui/input.h
diff --git a/ui/sdl2.c b/ui/sdl2.c
index 7dd8a87..3be9de7 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -23,12 +23,6 @@
  */
 /* Ported SDL 1.2 code to 2.0 by Dave Airlie. */
 
-/* Avoid compiler warning because macro is redefined in SDL_syswm.h. */
-#undef WIN32_LEAN_AND_MEAN
-
-#include SDL.h
-#include SDL_syswm.h
-
 #include qemu-common.h
 #include ui/console.h
 #include ui/input.h
-- 
1.8.3.1