Re: [Qemu-devel] [PATCH 6/6] target-ppc: Implement correct NaN propagation rules

2011-01-05 Thread Nathan Froyd
On Mon, Jan 03, 2011 at 03:34:33PM +0100, Aurelien Jarno wrote:
 Implement the correct NaN propagation rules for ARM targets by
 providing an appropriate pickNaN function.
 
 Also fix the #ifdef tests for default NaN definition, the correct name
 is TARGET_PPC instead of TARGET_POWERPC.

Reviewed-by: Nathan Froyd froy...@codesourcery.com

 + * A signaling NaN is always quietened before returning it.

I think silenced is more natural here, but I can understand preferring
quiet in keeping with NaN terminology.

-Nathan



[Qemu-devel] [PATCH 6/6] target-ppc: Implement correct NaN propagation rules

2011-01-03 Thread Aurelien Jarno
Implement the correct NaN propagation rules for ARM targets by
providing an appropriate pickNaN function.

Also fix the #ifdef tests for default NaN definition, the correct name
is TARGET_PPC instead of TARGET_POWERPC.

Cc: Alexander Graf ag...@suse.de
Signed-off-by: Aurelien Jarno aurel...@aurel32.net
---
 fpu/softfloat-specialize.h |   19 +--
 1 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/fpu/softfloat-specialize.h b/fpu/softfloat-specialize.h
index 150500b..0f6dbd0 100644
--- a/fpu/softfloat-specialize.h
+++ b/fpu/softfloat-specialize.h
@@ -61,7 +61,7 @@ typedef struct {
 **/
 #if defined(TARGET_SPARC)
 #define float32_default_nan make_float32(0x7FFF)
-#elif defined(TARGET_POWERPC) || defined(TARGET_ARM) || defined(TARGET_ALPHA)
+#elif defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_ALPHA)
 #define float32_default_nan make_float32(0x7FC0)
 #elif SNAN_BIT_IS_ONE
 #define float32_default_nan make_float32(0x7FBF)
@@ -214,6 +214,21 @@ static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag 
bIsQNaN, flag bIsSNaN,
 return 1;
 }
 }
+#elif defined(TARGET_PPC)
+static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag bIsQNaN, flag bIsSNaN,
+   flag aIsLargerSignificand)
+{
+/* PowerPC propagation rules:
+ *  1. A if it sNaN or qNaN
+ *  2. B if it sNaN or qNaN
+ * A signaling NaN is always quietened before returning it.
+ */
+if (aIsSNaN || aIsQNaN) {
+return 0;
+} else {
+return 1;
+}
+}
 #else
 static int pickNaN(flag aIsQNaN, flag aIsSNaN, flag bIsQNaN, flag bIsSNaN,
 flag aIsLargerSignificand)
@@ -292,7 +307,7 @@ static float32 propagateFloat32NaN( float32 a, float32 b 
STATUS_PARAM)
 **/
 #if defined(TARGET_SPARC)
 #define float64_default_nan make_float64(LIT64( 0x7FFF ))
-#elif defined(TARGET_POWERPC) || defined(TARGET_ARM) || defined(TARGET_ALPHA)
+#elif defined(TARGET_PPC) || defined(TARGET_ARM) || defined(TARGET_ALPHA)
 #define float64_default_nan make_float64(LIT64( 0x7FF8 ))
 #elif SNAN_BIT_IS_ONE
 #define float64_default_nan make_float64(LIT64( 0x7FF7 ))
-- 
1.7.2.3