Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message

2018-11-29 Thread Pankaj Gupta 


> 
> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
> 
> Signed-off-by: Zhang Yi 
> ---
>  numa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/numa.c b/numa.c
> index 50ec016..3875e1e 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion
> *mr, Object *owner,
>  error_report("memory backend %s is used multiple times. Each "
>   "-numa option must use a different memdev value.",
>   path);
> +g_free(path);
>  exit(1);
>  }
>  
> --

Reviewed-by: Pankaj gupta 

> 2.7.4

Re: [Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message

2018-11-26 Thread Igor Mammedov 
On Tue, 20 Nov 2018 15:48:06 +0800
Zhang Yi  wrote:

> object_get_canonical_path_component() returns a string which
> must be freed using g_free().
> 
> Signed-off-by: Zhang Yi 

Reviewed-by: Igor Mammedov 

> ---
>  numa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/numa.c b/numa.c
> index 50ec016..3875e1e 100644
> --- a/numa.c
> +++ b/numa.c
> @@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion 
> *mr, Object *owner,
>  error_report("memory backend %s is used multiple times. Each "
>   "-numa option must use a different memdev value.",
>   path);
> +g_free(path);
>  exit(1);
>  }
>

[Qemu-devel] [PATCH V5_resend 1/7] numa: Fixed the memory leak of numa error message

2018-11-19 Thread Zhang Yi 
object_get_canonical_path_component() returns a string which
must be freed using g_free().

Signed-off-by: Zhang Yi 
---
 numa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/numa.c b/numa.c
index 50ec016..3875e1e 100644
--- a/numa.c
+++ b/numa.c
@@ -533,6 +533,7 @@ void memory_region_allocate_system_memory(MemoryRegion *mr, 
Object *owner,
 error_report("memory backend %s is used multiple times. Each "
  "-numa option must use a different memdev value.",
  path);
+g_free(path);
 exit(1);
 }
 
-- 
2.7.4