Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none
Am 26.11.2013 um 19:02 hat Anthony Liguori geschrieben: Max Reitz mre...@redhat.com writes: This series fixes the drive-mirror blockjob in case of none sync mode to always use the old (current) image file as the backing file of the newly created mirrored file (in case of absolute-paths mode). It is rather important to get this into 1.7, as we will introduce an at least pretty strange API in case the original file is unbacked otherwise. Kevin/Stefan? Do we need this for 1.7? Yes, it would be good to pick it up in order to avoid changing the API in 1.8 (I guess we would do it anyway because the current behaviour doesn't make any sense and we'd call it bug fix, but libvirt would have to deal with it and better to do it right in the first release.) Do you want to pick it up yourself or should I send a pull request? Reviewed-by: Kevin Wolf kw...@redhat.com Kevin
Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none
Kevin Wolf kw...@redhat.com writes: Am 26.11.2013 um 19:02 hat Anthony Liguori geschrieben: Max Reitz mre...@redhat.com writes: This series fixes the drive-mirror blockjob in case of none sync mode to always use the old (current) image file as the backing file of the newly created mirrored file (in case of absolute-paths mode). It is rather important to get this into 1.7, as we will introduce an at least pretty strange API in case the original file is unbacked otherwise. Kevin/Stefan? Do we need this for 1.7? Yes, it would be good to pick it up in order to avoid changing the API in 1.8 (I guess we would do it anyway because the current behaviour doesn't make any sense and we'd call it bug fix, but libvirt would have to deal with it and better to do it right in the first release.) Do you want to pick it up yourself or should I send a pull request? I'll pick it up. Regards, Anthony Liguori Reviewed-by: Kevin Wolf kw...@redhat.com Kevin
Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none
Il 25/11/2013 20:28, Max Reitz ha scritto: This series fixes the drive-mirror blockjob in case of none sync mode to always use the old (current) image file as the backing file of the newly created mirrored file (in case of absolute-paths mode). It is rather important to get this into 1.7, as we will introduce an at least pretty strange API in case the original file is unbacked otherwise. Max Reitz (2): block/drive-mirror: Reuse backing HD for sync=none qemu-iotests: Fix test 041 Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Re: [Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none
Max Reitz mre...@redhat.com writes: This series fixes the drive-mirror blockjob in case of none sync mode to always use the old (current) image file as the backing file of the newly created mirrored file (in case of absolute-paths mode). It is rather important to get this into 1.7, as we will introduce an at least pretty strange API in case the original file is unbacked otherwise. Kevin/Stefan? Do we need this for 1.7? Regards, Anthony Liguori Max Reitz (2): block/drive-mirror: Reuse backing HD for sync=none qemu-iotests: Fix test 041 blockdev.c | 3 +++ tests/qemu-iotests/041 | 32 tests/qemu-iotests/041.out | 4 ++-- 3 files changed, 29 insertions(+), 10 deletions(-) -- 1.8.4.2
[Qemu-devel] [PATCH for-1.7 0/2] block/drive-mirror: Reuse backing HD for sync=none
This series fixes the drive-mirror blockjob in case of none sync mode to always use the old (current) image file as the backing file of the newly created mirrored file (in case of absolute-paths mode). It is rather important to get this into 1.7, as we will introduce an at least pretty strange API in case the original file is unbacked otherwise. Max Reitz (2): block/drive-mirror: Reuse backing HD for sync=none qemu-iotests: Fix test 041 blockdev.c | 3 +++ tests/qemu-iotests/041 | 32 tests/qemu-iotests/041.out | 4 ++-- 3 files changed, 29 insertions(+), 10 deletions(-) -- 1.8.4.2
