Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings
On Wed, 19 Dec 2018 at 23:13, Philippe Mathieu-Daudé wrote: > I'm trying to reduce OSX warnings, as of current QEMU master I count > 80 warnings using Xcode 10, which result in me not looking at them (or > worst, at new ones...). A lot of them are the address-of-packed-member warnings, which I've been gradually looking at -- I think we're now down to just the slirp ones, which I've been leaving until the big refactor that's pending has landed. Other than that there are a bunch of deprecated-declaration warnings about SASL, which I never figured out an approach for and so just suppress in my "grep logs for warnings" script. I don't think there's too many other than that? thanks -- PMM
Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings
On Wed, Dec 19, 2018 at 11:42 PM Peter Maydell wrote: > On Wed, 19 Dec 2018 at 21:34, Philippe Mathieu-Daudé wrote: > > > > Hey Alex, Peter, what do you think about this patch? > > > > On Wed, Aug 9, 2017 at 10:27 PM Philippe Mathieu-Daudé > > wrote: > > > > > > $ make info > > > GEN qemu-doc.html > > > qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. > > > GEN qemu-doc.txt > > > qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. > > > > > > Signed-off-by: Philippe Mathieu-Daudé > > > --- > > > .travis.yml | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/.travis.yml b/.travis.yml > > > index 4bf69b0116..24f62fb7cf 100644 > > > --- a/.travis.yml > > > +++ b/.travis.yml > > > @@ -74,9 +74,11 @@ git: > > ># we want to do this ourselves > > >submodules: false > > > before_install: > > > + # silent texinfo warnings > > > (https://github.com/xiaohanyu/oh-my-emacs/blob/c664894e2f1c1cb0f95a9f2da88d41b00f190856/core/ome-basic.org#homebrew) > > >- if [ "$TRAVIS_OS_NAME" == "osx" ]; then > > > brew update ; > > > -brew install libffi gettext glib pixman ; > > > +brew install libffi gettext glib pixman texinfo ; > > > +brew link texinfo --force ; > > > fi > > The commit message is a bit lacking in detail about how it's > fixing things. IIRC this message is caused because the stock > OSX texinfo is too old, so installing a newer version via > brew makes sense. But what does the "brew link" command do? This was more than 1 year ago, now I try/force myself to write more verbose commit message... I don't remember exactly why I added the 'link' and will have to check again (another thing I learned, write commit message for your self, else you won't remember in 1 year ahead...). I'm trying to reduce OSX warnings, as of current QEMU master I count 80 warnings using Xcode 10, which result in me not looking at them (or worst, at new ones...). I'll include this patch reworded in an OSX cleanup series. Thanks, Phil.
Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings
On Wed, 19 Dec 2018 at 21:34, Philippe Mathieu-Daudé wrote: > > Hey Alex, Peter, what do you think about this patch? > > On Wed, Aug 9, 2017 at 10:27 PM Philippe Mathieu-Daudé > wrote: > > > > $ make info > > GEN qemu-doc.html > > qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. > > GEN qemu-doc.txt > > qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. > > > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > .travis.yml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/.travis.yml b/.travis.yml > > index 4bf69b0116..24f62fb7cf 100644 > > --- a/.travis.yml > > +++ b/.travis.yml > > @@ -74,9 +74,11 @@ git: > ># we want to do this ourselves > >submodules: false > > before_install: > > + # silent texinfo warnings > > (https://github.com/xiaohanyu/oh-my-emacs/blob/c664894e2f1c1cb0f95a9f2da88d41b00f190856/core/ome-basic.org#homebrew) > >- if [ "$TRAVIS_OS_NAME" == "osx" ]; then > > brew update ; > > -brew install libffi gettext glib pixman ; > > +brew install libffi gettext glib pixman texinfo ; > > +brew link texinfo --force ; > > fi The commit message is a bit lacking in detail about how it's fixing things. IIRC this message is caused because the stock OSX texinfo is too old, so installing a newer version via brew makes sense. But what does the "brew link" command do? thanks -- PMM
Re: [Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings
Hey Alex, Peter, what do you think about this patch? On Wed, Aug 9, 2017 at 10:27 PM Philippe Mathieu-Daudé wrote: > > $ make info > GEN qemu-doc.html > qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. > GEN qemu-doc.txt > qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. > > Signed-off-by: Philippe Mathieu-Daudé > --- > .travis.yml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.travis.yml b/.travis.yml > index 4bf69b0116..24f62fb7cf 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -74,9 +74,11 @@ git: ># we want to do this ourselves >submodules: false > before_install: > + # silent texinfo warnings > (https://github.com/xiaohanyu/oh-my-emacs/blob/c664894e2f1c1cb0f95a9f2da88d41b00f190856/core/ome-basic.org#homebrew) >- if [ "$TRAVIS_OS_NAME" == "osx" ]; then > brew update ; > -brew install libffi gettext glib pixman ; > +brew install libffi gettext glib pixman texinfo ; > +brew link texinfo --force ; > fi >- wget -O - > http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar > -xvJ >- travis_retry git submodule update --init --recursive > -- > 2.13.3 >
[Qemu-devel] [PATCH for-2.11 v3 12/16] travis/osx: silent texinfo warnings
$ make info GEN qemu-doc.html qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. GEN qemu-doc.txt qemu-doc.texi:8: warning: unrecognized encoding name `UTF-8'. Signed-off-by: Philippe Mathieu-Daudé--- .travis.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 4bf69b0116..24f62fb7cf 100644 --- a/.travis.yml +++ b/.travis.yml @@ -74,9 +74,11 @@ git: # we want to do this ourselves submodules: false before_install: + # silent texinfo warnings (https://github.com/xiaohanyu/oh-my-emacs/blob/c664894e2f1c1cb0f95a9f2da88d41b00f190856/core/ome-basic.org#homebrew) - if [ "$TRAVIS_OS_NAME" == "osx" ]; then brew update ; -brew install libffi gettext glib pixman ; +brew install libffi gettext glib pixman texinfo ; +brew link texinfo --force ; fi - wget -O - http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz | tar -xvJ - travis_retry git submodule update --init --recursive -- 2.13.3